{"id":23467,"url":"https://patchwork.libcamera.org/api/1.1/patches/23467/?format=json","web_url":"https://patchwork.libcamera.org/patch/23467/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250604130741.9228-7-laurent.pinchart@ideasonboard.com>","date":"2025-06-04T13:07:40","name":"[v2,6/7] gstreamer: Drop incorrect unref on caps","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7eb3579acbbdf160f26dd4ff93a73ecddb75f706","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23467/mbox/","series":[{"id":5204,"url":"https://patchwork.libcamera.org/api/1.1/series/5204/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5204","date":"2025-06-04T13:07:34","name":"gstreamer: Miscellaneous cleanups + two fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/5204/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23467/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23467/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4BE8C3325\n\tfor ;\n\tWed, 4 Jun 2025 13:08:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8A4868DC5;\n\tWed, 4 Jun 2025 15:08:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B66B968DC5\n\tfor ;\n\tWed, 4 Jun 2025 15:07:59 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D3E978C;\n\tWed, 4 Jun 2025 15:07:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"S1JXnwc3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749042476;\n\tbh=SkeLm18ckEG3XsrwVUnJoIMS/uEPea6GyYTPfXM4I3s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=S1JXnwc39gAv3FDhycoBYg7zb7E+MDr8PhYr31wmodqV8wuvsqwpzaSJeqiI/UnW6\n\tGQ3ifcg5ZMC6oALn71UqYESi21IrXt1NPbOZ/e0fD/bqKBT/4wJE01VfLenJIsOQpE\n\tS/U+nJzZavEHiQnxaIKZnnKBxRLTao/EnR+Cu7eU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Hou Qi ,\n\tNicolas Dufresne ","Subject":"[PATCH v2 6/7] gstreamer: Drop incorrect unref on caps","Date":"Wed, 4 Jun 2025 16:07:40 +0300","Message-ID":"<20250604130741.9228-7-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250604130741.9228-1-laurent.pinchart@ideasonboard.com>","References":"<20250604130741.9228-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The caps object passeed to the gst_libcamera_create_video_pool()\nfunction is managed as a g_autoptr() in the caller. The function doesn't\nacquire any new reference, so it shouldn't call gst_caps_unref(). Fix\nit.\n\nSigned-off-by: Laurent Pinchart \n---\nI believe this is right (or I wouldn't send it), but a confirmation that\nnothing in gst_libcamera_create_video_pool() acquires a reference to the\ncaps would be appreciated.\n---\n src/gstreamer/gstlibcamerasrc.cpp | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 0be64dd836ca..eec8163e88e7 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -580,7 +580,6 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self, GstPad *srcpad,\n \t}\n \n \tif (!gst_buffer_pool_set_active(pool, true)) {\n-\t\tgst_caps_unref(caps);\n \t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n \t\t\t\t (\"Failed to active buffer pool\"),\n \t\t\t\t (\"gst_libcamera_src_negotiate() failed.\"));\n","prefixes":["v2","6/7"]}