{"id":23456,"url":"https://patchwork.libcamera.org/api/1.1/patches/23456/?format=json","web_url":"https://patchwork.libcamera.org/patch/23456/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250528121827.87844-3-niklas.soderlund@ragnatech.se>","date":"2025-05-28T12:18:27","name":"[2/2] guides: pipeline-handler: Update name of pipeline handler stop function","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c52b0d51250c6cc9982996f8472a2ff193d5c895","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23456/mbox/","series":[{"id":5199,"url":"https://patchwork.libcamera.org/api/1.1/series/5199/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5199","date":"2025-05-28T12:18:25","name":"Small fixes to ipu3 and pipeline-handler guide","version":1,"mbox":"https://patchwork.libcamera.org/series/5199/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23456/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23456/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9647DC3292\n\tfor ;\n\tWed, 28 May 2025 12:20:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 333D468DA6;\n\tWed, 28 May 2025 14:20:14 +0200 (CEST)","from fout-a5-smtp.messagingengine.com\n\t(fout-a5-smtp.messagingengine.com [103.168.172.148])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E400614CE\n\tfor ;\n\tWed, 28 May 2025 14:20:10 +0200 (CEST)","from phl-compute-03.internal (phl-compute-03.phl.internal\n\t[10.202.2.43])\n\tby mailfout.phl.internal (Postfix) with ESMTP id A2C141383AE9;\n\tWed, 28 May 2025 08:20:09 -0400 (EDT)","from phl-mailfrontend-01 ([10.202.2.162])\n\tby phl-compute-03.internal (MEProxy); Wed, 28 May 2025 08:20:09 -0400","by mail.messagingengine.com (Postfix) with ESMTPA; Wed,\n\t28 May 2025 08:20:08 -0400 (EDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ragnatech.se header.i=@ragnatech.se\n\theader.b=\"WP5qnnxm\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"DZ6GGa36\"; \n\tdkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h=\n\tcc:cc:content-transfer-encoding:content-type:content-type:date\n\t:date:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to; s=fm3; t=1748434809;\n\tx=1748521209; bh=Th59CAVXAcgQNqVt2pSLs4lYt5ZtT33gKvEq3cPTCtc=; b=\n\tWP5qnnxmt1d/olWqItOZ0AD+pY+IUF/mUSBsh82fJc/8dtXQr1OXwmUCxNmKGRUt\n\tfurZEq2c/Jm/wDnnbGUj52ORN/gZYkblbM55QFi/JTesHqdwZe29xFeT3idydevO\n\tgajTdUIPKx6d4q2XZ/vnnYOeQW/GaaK7fG6q+J5lhOgf3WELM3D2wy/KFV7JTdZ1\n\t4jkRYRvZ80PbZZaBZZacb0EL6zKa2alxKFN+Fk35eGTTQos0w2pYOL8m15XstMpH\n\t6SEsfYgdPO5M7xl2VXFCM6hz1KKPNJZ5PzvcAH7864TukQboUqW0oOIaRmae8Llo\n\t0FyPTn3Hh5S0fiaXbOEGrg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:cc:content-transfer-encoding\n\t:content-type:content-type:date:date:feedback-id:feedback-id\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1748434809; x=\n\t1748521209; bh=Th59CAVXAcgQNqVt2pSLs4lYt5ZtT33gKvEq3cPTCtc=; b=D\n\tZ6GGa36xezNwY5MvwQV6gfKN+HWRS4Ly1/iRdjgR9SY51LjhgD0+GfaYbBWiHSII\n\tP1RJqLKO6751t3Z1CfttT8yrVE0WfRRRox/h8SlM98wC1ycYw2g77Gxl+xfWMULv\n\tHvj4EOg+rQLijEj4P8XnnpvJaABd94CfV3hlmOisWs3gi0HF5Z5jCAVJVRqmlVOd\n\tnQqJogWT6Htmn5Ryknho4aIjPkJM6VGwqcbP8JGkJ3ciEID4akh119n7s2fthrmv\n\tNX60Ga7nOKxK4a0vFqvvPgUDPAR1+v5v3SBv8XCG9X3zqn8+Vj2DdfpPHe8qQ+kt\n\tjak8D4uzN7wdS+qWOwBoQ=="],"X-ME-Sender":"\n\t","X-ME-Received":"","X-ME-Proxy-Cause":"gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddvfedvgeculddtuddrgeefvddrtd\n\tdtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggft\n\tfghnshhusghstghrihgsvgdpuffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftd\n\tdtnecunecujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhm\n\tpefpihhklhgrshcuufpnuggvrhhluhhnugcuoehnihhklhgrshdrshhouggvrhhluhhnug\n\tesrhgrghhnrghtvggthhdrshgvqeenucggtffrrghtthgvrhhnpedtjeegkeeiudffhefh\n\tgedugeefueekkeffgeeltdeifeekheejveeifeffheevueenucevlhhushhtvghrufhiii\n\tgvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehnihhklhgrshdrshhouggvrhhluhhn\n\tugesrhgrghhnrghtvggthhdrshgvpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmth\n\thpohhuthdprhgtphhtthhopehlihgstggrmhgvrhgrqdguvghvvghlsehlihhsthhsrdhl\n\tihgstggrmhgvrhgrrdhorhhgpdhrtghpthhtohepnhhikhhlrghsrdhsohguvghrlhhunh\n\tgusehrrghgnhgrthgvtghhrdhsvg","X-ME-Proxy":"\n\t\n\t\n\t\n\t","Feedback-ID":"i80c9496c:Fastmail","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"[PATCH 2/2] guides: pipeline-handler: Update name of pipeline\n\thandler stop function","Date":"Wed, 28 May 2025 14:18:27 +0200","Message-ID":"<20250528121827.87844-3-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250528121827.87844-1-niklas.soderlund@ragnatech.se>","References":"<20250528121827.87844-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since commit f6b6f15b54c2 (\"libcamera: pipeline: Introduce\nstopDevice()\") the stop function needed to be implemented by pipeline\nhandlers where renamed to stopDevice().\n\nUpdate the pipeline handler writers guide to match this.\n\nSigned-off-by: Niklas Söderlund \n---\n Documentation/guides/pipeline-handler.rst | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\nindex fe7529759650..3adb9ce24a85 100644\n--- a/Documentation/guides/pipeline-handler.rst\n+++ b/Documentation/guides/pipeline-handler.rst\n@@ -213,7 +213,7 @@ implementations for the overridden class members.\n std::vector> *buffers) override;\n \n int start(Camera *camera, const ControlList *controls) override;\n- void stop(Camera *camera) override;\n+ void stopDevice(Camera *camera) override;\n \n int queueRequestDevice(Camera *camera, Request *request) override;\n \n@@ -247,7 +247,7 @@ implementations for the overridden class members.\n return -1;\n }\n \n- void PipelineHandlerVivid::stop(Camera *camera)\n+ void PipelineHandlerVivid::stopDevice(Camera *camera)\n {\n }\n \n@@ -1152,7 +1152,7 @@ available to the devices which have to be started and ready to produce\n images. At the end of a capture session the ``Camera`` device needs to be\n stopped, to gracefully clean up any allocated memory and stop the hardware\n devices. Pipeline handlers implement two functions for these purposes, the\n-``start()`` and ``stop()`` functions.\n+``start()`` and ``stopDevice()`` functions.\n \n The memory initialization phase that happens at ``start()`` time serves to\n configure video devices to be able to use memory buffers exported as dma-buf\n","prefixes":["2/2"]}