{"id":23447,"url":"https://patchwork.libcamera.org/api/1.1/patches/23447/?format=json","web_url":"https://patchwork.libcamera.org/patch/23447/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250526214224.13631-3-stefan.klug@ideasonboard.com>","date":"2025-05-26T21:42:16","name":"[RFC,2/4] libcamera: internal: Allow to limit the number of queued requests","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"08c9a44ec38a46553e72a9615bb8f0303822218e","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23447/mbox/","series":[{"id":5196,"url":"https://patchwork.libcamera.org/api/1.1/series/5196/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5196","date":"2025-05-26T21:42:14","name":"rkisp1: Allow usage of more than 4 buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/5196/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23447/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23447/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7E45C31E9\n\tfor ;\n\tMon, 26 May 2025 21:42:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 30FF368DA6;\n\tMon, 26 May 2025 23:42:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A91B68DA3\n\tfor ;\n\tMon, 26 May 2025 23:42:42 +0200 (CEST)","from ideasonboard.com (tmo-070-11.customers.d1-online.com\n\t[80.187.70.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 720157EA;\n\tMon, 26 May 2025 23:42:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DKtPcP5t\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1748295737;\n\tbh=BNznKZkaSa88fwQKn0CvSMYDEw7MWg8RTSpdBw20qIE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DKtPcP5ti7mv0ZC2ncXEBU2Ls9TLMqyqSIsBs5LP8vOyNaTk1kTfI8AbH7F7psCrE\n\t7Dnzj3si8tta6A5m18POiGfH9qQr0gxL1UsLPKP2aLAZIyJucjbXPhS6yMq4bjJ+yu\n\tYFP9yQphyzXUq6aCPLbR8lFIPo8VC3qVq1Y1VimQ=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[RFC PATCH 2/4] libcamera: internal: Allow to limit the number of\n\tqueued requests","Date":"Mon, 26 May 2025 23:42:16 +0200","Message-ID":"<20250526214224.13631-3-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250526214224.13631-1-stefan.klug@ideasonboard.com>","References":"<20250526214224.13631-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Allow pipeline handler classes to limit the maximum number of requests that\nget queued using queueRequestDevice().\n\nSigned-off-by: Stefan Klug \n---\n include/libcamera/internal/pipeline_handler.h | 5 +++++\n src/libcamera/pipeline_handler.cpp | 3 +++\n 2 files changed, 8 insertions(+)","diff":"diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex dedc29e815fb..86b86d5971dc 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -79,6 +79,11 @@ protected:\n \tvirtual bool acquireDevice(Camera *camera);\n \tvirtual void releaseDevice(Camera *camera);\n \n+\tvirtual unsigned int maxQueuedRequestsDevice() const\n+\t{\n+\t\treturn std::numeric_limits::max();\n+\t}\n+\n \tCameraManager *manager_;\n \n private:\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 14d8602e67d8..1853bca71371 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -490,6 +490,9 @@ void PipelineHandler::doQueueRequests()\n \n \t\tCamera::Private *data = camera->_d();\n \t\twhile (!data->waitingRequests_.empty()) {\n+\t\t\tif (data->queuedRequests_.size() == maxQueuedRequestsDevice())\n+\t\t\t\tbreak;\n+\n \t\t\tRequest *request = data->waitingRequests_.front();\n \t\t\tif (!request->_d()->prepared_)\n \t\t\t\tbreak;\n","prefixes":["RFC","2/4"]}