{"id":23428,"url":"https://patchwork.libcamera.org/api/1.1/patches/23428/?format=json","web_url":"https://patchwork.libcamera.org/patch/23428/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250522130318.35533-1-david.plowman@raspberrypi.com>","date":"2025-05-22T13:03:18","name":"ipa: rpi: controller: rpi: Fix colour gain typo in AGC","commit_ref":"ad5326c926831fe7a943d10fd800de43e596f171","pull_url":null,"state":"accepted","archived":false,"hash":"91c315960980bebe044ab99b35a2138289363924","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23428/mbox/","series":[{"id":5191,"url":"https://patchwork.libcamera.org/api/1.1/series/5191/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5191","date":"2025-05-22T13:03:18","name":"ipa: rpi: controller: rpi: Fix colour gain typo in AGC","version":1,"mbox":"https://patchwork.libcamera.org/series/5191/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23428/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23428/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9465AC31E9\n\tfor ;\n\tThu, 22 May 2025 13:03:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BFAE68D96;\n\tThu, 22 May 2025 15:03:23 +0200 (CEST)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3418A68D8B\n\tfor ;\n\tThu, 22 May 2025 15:03:22 +0200 (CEST)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-442ed8a275fso100844215e9.2\n\tfor ;\n\tThu, 22 May 2025 06:03:22 -0700 (PDT)","from davidp-xps-13.pitowers.org\n\t([2a00:1098:3142:1f:93e2:135d:3fc5:ed2d])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-447f24b6471sm105414305e9.24.2025.05.22.06.03.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 22 May 2025 06:03:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Oi9ZPbtQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1747919001; x=1748523801;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=mvWf9TYTseIK2W8er/I173KMk2B2g4Bs0XpPOL9Qw1E=;\n\tb=Oi9ZPbtQ41XjlM2FkT43t1PEm77V1ncnzhncziGvNbTSVnPSJqoG0gyWmckSbBo1Xw\n\t1ZYdAjpZTfWoz9brnLBziKDSth0ms46WBXJrOjp3uDYS38ZLbU14ysTo6/SdSu3IA0Em\n\ts5n9NEmH8UC+rCN5vxZvgXfS/lhhVd84HKUo8O/GKYwTTfMoauC7EJi9km3idXQC18Tq\n\t59YuWNo/QbMA41MfLqaJEZPPbfhQb0H9joZqGpwwWN2/GXnnGgfvHrWoZs30Bx9DzCmI\n\tZaYRtbWTx1kzEKkX5Ir5Nc7sJVpThGeqIVwTSBio1nu/8ctodlv/tGb29fhehpmK8gND\n\tbd8g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1747919001; x=1748523801;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=mvWf9TYTseIK2W8er/I173KMk2B2g4Bs0XpPOL9Qw1E=;\n\tb=OA5QcG+ubnLcc+YguXd2MjtptEADrTlZjMTZ4SpUvgroC+w3uxcS7fQT6+qjmDRyse\n\tg2yk+gic96N7Gm3xw0S7Wi3ES/L5WCExTB1ByM1eo5aFkYP5n2iTSVzOU7MnBg9nwJJx\n\tTljE6lht0ld12bmutVN2iVlo9V0CrT/GtAXCxwnS1f0s8dYsrO0pgfkSFP9F82W75LDR\n\tRKxug5648wmWRcUQrJfb0/6w3Ag+w3XyMKjM+mslSwN7U+E9o5WSDGWBK1fLTZo+nomf\n\tgPwsF3N1eKKH0t96I4FaFzAYbYgJ2XSrLz8NCT8V/4m5E4xntdgySZXNQzUPWvi24P/9\n\tEzEQ==","X-Gm-Message-State":"AOJu0Ywep/YIL4okXXT3JCMy73S6t1Sr2a9gX3dVPK6Y16Xy6QVySNss\n\t50DKHujB2fHQpC5smDpD5hcve6vcYguvFr1E9ak/W4QaSUIPwCSSOtmoDyVDlAcmyAarzB0R8Qk\n\t3o/5yRFg=","X-Gm-Gg":"ASbGncsyLZHlXPjLTzooboNmwNwcqMzQr1PWoEMXBP0dC3owFnd386k8sbZ7GvjbeVQ\n\tQkCktvArxSuZ8yQ5kPf0LI3fiRDs4zXqvpT+5fIEP7EcnaeF7bDG9f/mt8a5+YatKq7LVh65rYK\n\tssv2TEuhIlEVjjLgdJcmHdSoh4M9DG+xawNV945Sq9meT4c+s/LP4ubDaXamV1U7MaudBT0d+X1\n\thvX9xP8BI55PUFnXRqJlAADK4woZ4mGRlJLEJaI5ZY8es85sW4ne36iy0uKyYW7TiU/h8JrRyqy\n\tKn+LxwQoQ491UImElWEj3lztb//B38iah1eYVaFk0XG6MAJWnSYt694azf1NNOhfhUjemVzBJxa\n\tdv0tjx03RZA==","X-Google-Smtp-Source":"AGHT+IEgMfK8icqCZ6K+5kBBA9INcvICL4kaskZ29GI698ojBp/HL12wTQSVzJHNUJif8B3DLs1mSg==","X-Received":"by 2002:a05:600c:c092:b0:440:66a4:8d1a with SMTP id\n\t5b1f17b1804b1-442fd950b76mr207384695e9.7.1747919001089; \n\tThu, 22 May 2025 06:03:21 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Cc":"David Plowman ","Subject":"[PATCH] ipa: rpi: controller: rpi: Fix colour gain typo in AGC","Date":"Thu, 22 May 2025 14:03:18 +0100","Message-Id":"<20250522130318.35533-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A simple typo crept in where the red gain had been re-typed rather\nthan using the correct green gain. In particular, this was causing\nvery dark images for sensors that use large red gains, such as the\nIMX477 outdoors.\n\nFixes: 29892f1c56c6 (\"ipa: libipa: colour: Use the RGB class to model RGB values\")\nSigned-off-by: David Plowman \n---\n src/ipa/rpi/controller/rpi/agc_channel.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rpi/controller/rpi/agc_channel.cpp b/src/ipa/rpi/controller/rpi/agc_channel.cpp\nindex a5562760..b2999364 100644\n--- a/src/ipa/rpi/controller/rpi/agc_channel.cpp\n+++ b/src/ipa/rpi/controller/rpi/agc_channel.cpp\n@@ -717,7 +717,7 @@ static double computeInitialY(StatisticsPtr &stats, AwbStatus const &awb,\n \n \t/* Factor in the AWB correction if needed. */\n \tif (stats->agcStatsPos == Statistics::AgcStatsPos::PreWb)\n-\t\tsum *= RGB{ { awb.gainR, awb.gainR, awb.gainB } };\n+\t\tsum *= RGB{ { awb.gainR, awb.gainG, awb.gainB } };\n \n \tdouble ySum = ipa::rec601LuminanceFromRGB(sum);\n \n","prefixes":[]}