{"id":23416,"url":"https://patchwork.libcamera.org/api/1.1/patches/23416/?format=json","web_url":"https://patchwork.libcamera.org/patch/23416/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250522075244.1198110-2-naush@raspberrypi.com>","date":"2025-05-22T07:48:17","name":"[v2,1/6] libcamera: framebuffer: Add FrameMetadata::Status::FrameStartup","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f0f1916ebd6c518b278708915b763263af80c644","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23416/mbox/","series":[{"id":5188,"url":"https://patchwork.libcamera.org/api/1.1/series/5188/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5188","date":"2025-05-22T07:48:16","name":"Eliminating startup frames","version":2,"mbox":"https://patchwork.libcamera.org/series/5188/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23416/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23416/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8EC7C31E9\n\tfor ;\n\tThu, 22 May 2025 07:52:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7846868D9C;\n\tThu, 22 May 2025 09:52:53 +0200 (CEST)","from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2D0568D85\n\tfor ;\n\tThu, 22 May 2025 09:52:48 +0200 (CEST)","by mail-wr1-x432.google.com with SMTP id\n\tffacd0b85a97d-3a36977f261so759925f8f.1\n\tfor ;\n\tThu, 22 May 2025 00:52:48 -0700 (PDT)","from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3a3ca066eb7sm4191516f8f.2.2025.05.22.00.52.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 22 May 2025 00:52:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"erC//0aG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1747900368; x=1748505168;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=7kayUoIMXpwu00j/brvCdM7ksfHri9lnN79748W/YaY=;\n\tb=erC//0aGiif6kN17Aiw2ynzh5NE2xV6fu0xCuoOUntOdULuqSY4Wn1m/XU6DiRg1qJ\n\th4Jo4WcVQUyJL3110IHMbDVYYWP0qO2HkSwjiWfjHxqzPO+yy0blYjBC3d4v4aEDTLtc\n\tZxEZLQw9+1jpNjenMZXzGyWTE+U9VMKgkk1HbOa3bm/198+Bn3EwOcKid1iiDewEpH3r\n\t5JaMBkOfMuBHtWmHaw1AqWL8R2uePokeY3iJoqeRMacpZmmBThPcCh8RGMc9toWvloMt\n\tfMK/q1lU4v9K2qzOE+BEzvZEkNka4CRZfboIMQBk7Kdap65qfQ85xgx3aLJ6FaX/PLif\n\trBAQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1747900368; x=1748505168;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=7kayUoIMXpwu00j/brvCdM7ksfHri9lnN79748W/YaY=;\n\tb=ZlGmi70g/YSjs/+Nkimxvg/g+50JBCpQtrI158S8Cg5qAAwUhN9f3mbh16S3rrKQhm\n\tvqDozvohroqBdEg3rCIHGHQiTLMloo/0N5q/OyVHdt4VYtgQnFkV/4B5FrUpt6fEvKc4\n\thNXx39+BoG0YqkBRItMOgqSOkY1t4WUj8ZGVuDh9RNC7w91L4zHIUJi/A7rb4n+8g54o\n\tPnTLjdCQRO3s+SHodXtQlvT0YDCjtpWvaJOUcExnfqXRTlhEWhsx4B3cPIP+1P+AkPLM\n\tQRsL1r3reFpk5a6CXBXE5HIGqWlSyJ5QoThIZU8U2JQZbS+K0DFJBy3wRHaYRlcd5Tqe\n\tKKsA==","X-Gm-Message-State":"AOJu0YyK86s8voWWhb99JEVmtCJ+vtXhWCVGYf1NAchDWB0k95ZJ58vn\n\t/frvqegH4n5EfRFaFx6Mse+7SR0zn1pGz5IVtAmWFbeTHq9ofkcW/2Y3zUIi+ApayIWsu0UvneJ\n\tYKod+","X-Gm-Gg":"ASbGncsxPNrGrtbmY5AjuzZ7o4Wj1zR/aO+pFdgpKeg84SAORJAv76MtDL60yZVDMFZ\n\t3sIaXpbrZHyzNjTOxeUuyRgK+47inE6L0V/dtf+tDdMFkiyNxiDSqRbsid+5zbQJgMdJJXzChZv\n\tgZSD0VBZBjuQv5FJoebeIaaQo7Dx8mjO2o5KJ/rCLiRw9AorMNbdJg68xHvHz+n7ZNbsZavszEy\n\tVMJ00flglZypzTzYGtdexKy15Nfy4VXJthkqLiMzwrWRB3feiYbCM9lqZstNELwSCjMkbE3px2d\n\tfmOJOgVcNfljmbtSTG5mdub07KFroBCcmD63N9rINZctRd6Ee+XIHN1Z2P6/6+VM5JefdjL4+Ag\n\tzIf0cBw==","X-Google-Smtp-Source":"AGHT+IHM7X6ypTp7FpdsQW8WofCwrmZj5vVnUYpkWX/0xUqzhS4XXJLTmEsIn4i6h73/Tn6S9p4EbQ==","X-Received":"by 2002:a05:600c:a07:b0:442:f97a:fee7 with SMTP id\n\t5b1f17b1804b1-442fd6770e0mr85986315e9.6.1747900367926; \n\tThu, 22 May 2025 00:52:47 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ,\n\tDavid Plowman ","Subject":"[PATCH v2 1/6] libcamera: framebuffer: Add\n\tFrameMetadata::Status::FrameStartup","Date":"Thu, 22 May 2025 08:48:17 +0100","Message-ID":"<20250522075244.1198110-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250522075244.1198110-1-naush@raspberrypi.com>","References":"<20250522075244.1198110-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a new status enum, FrameStartup, used to denote that even though\nthe frame has been successfully captured, the IQ parameters set by the\nIPA will cause the frame to be unusable and applications are advised to\nnot consume this frame. An example of this would be on a cold-start of\nthe 3A algorithms, and there will be large oscillations to converge to\na stable state quickly.\n\nAdditional, update the definition of the FrameError state to cover the\nusage when the sensor is known to produce a number of invalid/error\nframes after stream-on.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \n---\n include/libcamera/framebuffer.h | 1 +\n src/libcamera/framebuffer.cpp | 13 ++++++++++---\n 2 files changed, 11 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex ff83924300ac..e83825b466aa 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -26,6 +26,7 @@ struct FrameMetadata {\n \t\tFrameSuccess,\n \t\tFrameError,\n \t\tFrameCancelled,\n+\t\tFrameStartup,\n \t};\n \n \tstruct Plane {\ndiff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\nindex 826848f75a56..93be497be052 100644\n--- a/src/libcamera/framebuffer.cpp\n+++ b/src/libcamera/framebuffer.cpp\n@@ -43,12 +43,19 @@ LOG_DEFINE_CATEGORY(Buffer)\n * The frame has been captured with success and contains valid data. All fields\n * of the FrameMetadata structure are valid.\n * \\var FrameMetadata::FrameError\n- * An error occurred during capture of the frame. The frame data may be partly\n- * or fully invalid. The sequence and timestamp fields of the FrameMetadata\n- * structure is valid, the other fields may be invalid.\n+ * The frame data is partly or fully corrupted, missing or otherwise invalid.\n+ * This can for instance indicate a hardware transmission error, or invalid data\n+ * produced by the sensor during its startup phase. The sequence and timestamp\n+ * fields of the FrameMetadata structure is valid, all the other fields may be\n+ * invalid.\n * \\var FrameMetadata::FrameCancelled\n * Capture stopped before the frame completed. The frame data is not valid. All\n * fields of the FrameMetadata structure but the status field are invalid.\n+ * \\var FrameMetadata::FrameStartup The frame has been successfully captured.\n+ * However, the IPA is in a cold-start or reset phase and will result in image\n+ * quality parameters producing unusable images. Applications are recommended to\n+ * not consume these frames. All other fields of the FrameMetadata structure are\n+ * valid.\n */\n \n /**\n","prefixes":["v2","1/6"]}