{"id":23414,"url":"https://patchwork.libcamera.org/api/1.1/patches/23414/?format=json","web_url":"https://patchwork.libcamera.org/patch/23414/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250521-djrscally-c55-cleanup-v1-2-aa171b2aed38@ideasonboard.com>","date":"2025-05-21T13:21:02","name":"[2/2] libcamera/mali-c55: Remove tpgSizes_ member from MaliC55CameraData","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"78d8b582230cda79ced708fab08e6c82c8a51229","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/1.1/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23414/mbox/","series":[{"id":5187,"url":"https://patchwork.libcamera.org/api/1.1/series/5187/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5187","date":"2025-05-21T13:21:00","name":"Mali-C55 Cleanup Patches","version":1,"mbox":"https://patchwork.libcamera.org/series/5187/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23414/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23414/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67ECCBD78E\n\tfor ;\n\tWed, 21 May 2025 13:21:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4BB168D9A;\n\tWed, 21 May 2025 15:21:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCDF468D8E\n\tfor ;\n\tWed, 21 May 2025 15:21:30 +0200 (CEST)","from [127.0.1.1]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EC09E8A;\n\tWed, 21 May 2025 15:21:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MVTnURyC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747833669;\n\tbh=csuodIz9Yl1ShfGdzGSCyBgu4RHAswwnYKSpI6Gkssc=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=MVTnURyCShumiUqLhNnycnHWoviY9c8UOlX7bWi4zcEgrKat2IATalT2yKny57Zi8\n\tArOlIHB979badvFYNonSTqY0BwaxauQeAF9oSsQW16yAmWxXe/PYwXjpo10ges1Z4j\n\tjLijnhPt9BXY+YAELLlIjz2DmUkDw8L7+pAILock=","From":"Daniel Scally ","Date":"Wed, 21 May 2025 14:21:02 +0100","Subject":"[PATCH 2/2] libcamera/mali-c55: Remove tpgSizes_ member from\n\tMaliC55CameraData","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250521-djrscally-c55-cleanup-v1-2-aa171b2aed38@ideasonboard.com>","References":"<20250521-djrscally-c55-cleanup-v1-0-aa171b2aed38@ideasonboard.com>","In-Reply-To":"<20250521-djrscally-c55-cleanup-v1-0-aa171b2aed38@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1614;\n\ti=dan.scally@ideasonboard.com; h=from:subject:message-id;\n\tbh=csuodIz9Yl1ShfGdzGSCyBgu4RHAswwnYKSpI6Gkssc=;\n\tb=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBoLdNZd83Ekw4BCvdUpZQ5LYHsPl5hZaUvFNhMb\n\tg1Wnk7Qo32JAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCaC3TWQAKCRDISVd6bEV1\n\tMjgKD/9rzNXXupOHS1Fc4vXzYxUL0jcVu0mS1MWJUBcb9TObElr9AFzrGBSm34nrAICjhxzhwLI\n\tINGq5bBiPvbPpXKRVG+m5MiGLX6wji36YQSPYtAUZJQ+o3I09gLLmSTjftR8QKaQFDPRCgmv8l2\n\t58eufbHHvmk+h1t2z+TnsnSmZRO25CIrDMeTZlTui2RP/1m+F9OlsXVF6rQkL+Ofumogi2LVzot\n\tbjV/myo/AuZKb1rIfjpa54gUPJj2sIdBFuTIS3nT6hAUuZG8hJrbLDZD3wG8Y8PJJ6cuYO7Bkus\n\t461M9jlHu8SdCbMY8MJOeBc5HUbFoytafyukcZ+FZSKvaQ5VZMsNcAORCDjhSYA/oq+d1IRwC8L\n\t4AoFfevHv+fYEcA8QgzJ7MeF3hcGLuBDj2UuYYuoAvQukLDl/ysHZ4HclXsiWI0Uif/5dmBJfHW\n\tPSKCPJ6d/n2pxMSN7xGrv+XpIgAl1941mMqhJ7AflVt8Yd82uF7rJ2pKp0LfeS6qbQRWZ3qWd8u\n\tnsSIOYwy0hp4FwJrNgFsZMEfTyymUQY43GTFfiZ5hBDYzEfF6paPThR0kwk+QXCWygkqeITsyyu\n\thnTeTbwEXH5HNjW7I6Pt0QfPfut8eEArsoZB5pOP9YFR/IXBeRtCGEZycCOrkr5uyZwUbyxatz0\n\tlURtAXCxdDiCgcQ==","X-Developer-Key":"i=dan.scally@ideasonboard.com; a=openpgp;\n\tfpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The tpgSizes_ vector is only used within the initTPGData() function.\nDrop it and use a local variable instead.\n\nSigned-off-by: Daniel Scally \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 35372ee1ed6f694166c395088c65509d32b9d1f2..e8c03ee9aafb44d47e3853e9987f8749dc385bb2 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -131,7 +131,6 @@ private:\n \tvoid setSensorControls(const ControlList &sensorControls);\n \n \tstd::string id_;\n-\tstd::vector tpgSizes_;\n \tSize tpgResolution_;\n };\n \n@@ -174,6 +173,8 @@ int MaliC55CameraData::init()\n \n void MaliC55CameraData::initTPGData()\n {\n+\tstd::vector tpgSizes;\n+\n \t/* Replicate the CameraSensor implementation for TPG. */\n \tV4L2Subdevice::Formats formats = sd_->formats(0);\n \tif (formats.empty())\n@@ -181,11 +182,11 @@ void MaliC55CameraData::initTPGData()\n \n \tfor (const auto &format : formats) {\n \t\tconst std::vector &ranges = format.second;\n-\t\tstd::transform(ranges.begin(), ranges.end(), std::back_inserter(tpgSizes_),\n+\t\tstd::transform(ranges.begin(), ranges.end(), std::back_inserter(tpgSizes),\n \t\t\t [](const SizeRange &range) { return range.max; });\n \t}\n \n-\ttpgResolution_ = tpgSizes_.back();\n+\ttpgResolution_ = tpgSizes.back();\n }\n \n void MaliC55CameraData::setSensorControls(const ControlList &sensorControls)\n","prefixes":["2/2"]}