{"id":23257,"url":"https://patchwork.libcamera.org/api/1.1/patches/23257/?format=json","web_url":"https://patchwork.libcamera.org/patch/23257/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250424114103.451395-6-barnabas.pocze@ideasonboard.com>","date":"2025-04-24T11:40:59","name":"[RFC,v5,5/9] libcamera: process: Ensure that file descriptors are nonnegative","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e24aba5bb5514612e4e953700b0fed705a35b990","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23257/mbox/","series":[{"id":5145,"url":"https://patchwork.libcamera.org/api/1.1/series/5145/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5145","date":"2025-04-24T11:40:54","name":"libcamera: process: Remove `ProcessManager` singleton","version":5,"mbox":"https://patchwork.libcamera.org/series/5145/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23257/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23257/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 851C8C331F\n\tfor ;\n\tThu, 24 Apr 2025 11:41:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE83368B24;\n\tThu, 24 Apr 2025 13:41:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2A8B68AD3\n\tfor ;\n\tThu, 24 Apr 2025 13:41:08 +0200 (CEST)","from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89E5318E5;\n\tThu, 24 Apr 2025 13:41:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QkbU2kfD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745494866;\n\tbh=6SAo2VztWOdl3IaEm7dGNgRt6EEEbGm3QhaZW53aXf4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QkbU2kfDj+QfPb9WRC5gR/nP0m+GvYq1a7O+hkZOifnFgcUd728ClJ8hjfBfqDpgh\n\tJZxi1XivkRjnc9oXTnro/hTBNbcbjh0v80UTNCFDxgxfPcIKM0SGdPu1aTJpJZVPaU\n\t64vrvMkc8izwWqMnz86Wi/+0z25wAjoGqNaGbdBI=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ,\n\tLaurent Pinchart ","Subject":"[RFC PATCH v5 5/9] libcamera: process: Ensure that file descriptors\n\tare nonnegative","Date":"Thu, 24 Apr 2025 13:40:59 +0200","Message-ID":"<20250424114103.451395-6-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250424114103.451395-1-barnabas.pocze@ideasonboard.com>","References":"<20250424114103.451395-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Return `-EINVAL` from `Process::start()` if any of the file descriptors\nare negative as those most likely signal some kind of issue such as\nmissed error checking.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/process.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex ca9733d77..1bc7a7f9a 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -243,6 +243,11 @@ int Process::start(const std::string &path,\n \tif (pid_ > 0)\n \t\treturn -EBUSY;\n \n+\tfor (int fd : fds) {\n+\t\tif (fd < 0)\n+\t\t\treturn -EINVAL;\n+\t}\n+\n \tint childPid = fork();\n \tif (childPid == -1) {\n \t\tret = -errno;\n@@ -282,6 +287,8 @@ void Process::closeAllFdsExcept(const std::vector &fds)\n \tstd::vector v(fds);\n \tsort(v.begin(), v.end());\n \n+\tASSERT(v.empty() || v.front() >= 0);\n+\n \tDIR *dir = opendir(\"/proc/self/fd\");\n \tif (!dir)\n \t\treturn;\n","prefixes":["RFC","v5","5/9"]}