{"id":23218,"url":"https://patchwork.libcamera.org/api/1.1/patches/23218/?format=json","web_url":"https://patchwork.libcamera.org/patch/23218/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250422215920.4297-6-bryan.odonoghue@linaro.org>","date":"2025-04-22T21:58:58","name":"[05/27] libcamera: swstats_cpu: Drop patternSize_ documentation","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"59741e75c523b0031de9169f512623c1b3987ba1","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23218/mbox/","series":[{"id":5142,"url":"https://patchwork.libcamera.org/api/1.1/series/5142/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5142","date":"2025-04-22T21:58:53","name":"RFC: Add in a eGL based GPUISP in libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/5142/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23218/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23218/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68A50C331E\n\tfor ;\n\tTue, 22 Apr 2025 21:59:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C756268B24;\n\tTue, 22 Apr 2025 23:59:31 +0200 (CEST)","from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 093D568ACA\n\tfor ;\n\tTue, 22 Apr 2025 23:59:28 +0200 (CEST)","by mail-wm1-x331.google.com with SMTP id\n\t5b1f17b1804b1-43cfe574976so42544365e9.1\n\tfor ;\n\tTue, 22 Apr 2025 14:59:28 -0700 (PDT)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-44092d2eccesm2726615e9.20.2025.04.22.14.59.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Apr 2025 14:59:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"SUWpLBvA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1745359167; x=1745963967;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=smZwtpbTz29j4hcPfA9P6oUHmTi9LVToPOlGCRTmB7Y=;\n\tb=SUWpLBvAaMy0vhEKdiCx7KPIkmJqnX3eaTqyVR5cKNvK06Y5E/ELEvqHWzvvC2hF9r\n\tQzJX+JnSDW/drhmhmwmBxrR4N0miO+UeD4QvWbqOKA8yz2Baaea6cpjVG5ctbn+bZxqf\n\tfUNaHnb8PKUZ3g9+D59jmN3i9Iy+sibTXGpQubSmHb9QS1s0XQbiigL6Pq8CCuhx+Ibv\n\tYB4YHBhvSzLTDR6bNsQwAEjoZmu2DHy0IfnuBLuHSNyA4H65JdKwX4a8mO6AbnW9lbpD\n\twX+o0FhLZgQlssBIbaYpTavzl2EkyugzfjNAkGtXl/mhJbnUckqDUJgaH2Jfm7nlVpGx\n\tv40w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745359167; x=1745963967;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=smZwtpbTz29j4hcPfA9P6oUHmTi9LVToPOlGCRTmB7Y=;\n\tb=X/otsHRAtzG4kN19XT011W/UAZNlH5vNymw9mVDnpm/Y7zLmObicqP8Kjh26VcTOOD\n\tv7nIgyMqmmWVtiV6w30sxNthB7hZvksH6/4q91typFy8HZJn2NhniXeRrZ4bYGO0Yo9y\n\t7s5KbP3UIFhwRDxfuJkQz2S5bvZqPzQxhiWd4d2fcYkqZeCpCCwhckLJlR7nAJnhed+i\n\tWfK+TkM0+c/XDhgJDJA/1UCjsLMGOP40zVDMynZxEnZBGqWi9AR57LZVxT9uQWxBGuhi\n\tH62zv2y+shSUZOfnUqk75/cFuRnYbJNXTur4+K4LQdt5dByoT6/0q1XspFA7QutZ31DC\n\tvPxw==","X-Gm-Message-State":"AOJu0Yz+hR8vPTyFCDt78TmT/ZjO4y+A0FgD4Xf8WBqwsVSbAnFnmgsb\n\t3+9KGckgE5Jd73C4et/RIXM+kI9GfMl2bcUIAgzt4Fvp5iCZkEVVkPBbhc/ssAE0khemYwOWLqQ\n\th19k=","X-Gm-Gg":"ASbGncvfAak8NIYUbR/FcBrKAN7AM8GR0RuMr+8L5hD1dsD+h0mBD9Uwce0jf76rKrF\n\trvymPJJzR9YLXBQqRojOonOjDOH2OwydiR8ZArpTbR6l2Qgk9iG5uids/Tf7IcWGDDw+a0H0L1f\n\tmJmrqsmZIdb3C4yEFZxh98WIay9UpWahKtm21UNtmCon37P/+He3UZmq5sd5JJEBOwgKo0O2WTa\n\tueHsWqaM0CbF4jAaiZwYjWuJFfm84xxpnqG2KLIqMeqXoeVrrIr8jUwWPvNZ8LBEgi0qHHSoK2n\n\t4OQ6HRPWAajKxyA9fFpAJp75NrX/OdZeEGYD24F79db6WFmfVs+R6g8ImjAULxERlOJ2omr7wxG\n\tCfMMWAaFiAzk7hnvKqErM","X-Google-Smtp-Source":"AGHT+IErBE9F/OlI/GautObTB87ngxUybNwQwc920fwDAlivg2ay5xKeywVxkGGZPBCydYZQTwrdEg==","X-Received":"by 2002:a05:600c:4ecc:b0:43b:c0fa:f9dd with SMTP id\n\t5b1f17b1804b1-4406ac007b8mr135722955e9.25.1745359167359; \n\tTue, 22 Apr 2025 14:59:27 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie, Kieran Bingham ","Subject":"[PATCH 05/27] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation","Date":"Tue, 22 Apr 2025 22:58:58 +0100","Message-ID":"<20250422215920.4297-6-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250422215920.4297-1-bryan.odonoghue@linaro.org>","References":"<20250422215920.4297-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Hans de Goede \n\npatternSize_ is a private variable and its meaning is already documented\nin the patternSize() getter documentation.\n\nMove the list of valid sizes to the patternSize() getter documentation\nand drop the patternSize_ documentation.\n\nWhile at it also add 1x1 as valid size for use with future support\nof single plane non Bayer input data.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Milan Zamazal \nSigned-off-by: Hans de Goede \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex a9a3e77a..5e4246a9 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -58,6 +58,8 @@ namespace libcamera {\n * also indicates if processLine2() should be called or not.\n * This may only be called after a successful configure() call.\n *\n+ * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n+ *\n * \\return The pattern size\n */\n \n@@ -112,13 +114,6 @@ namespace libcamera {\n * \\brief Statistics window, set by setWindow(), used every line\n */\n \n-/**\n- * \\var Size SwStatsCpu::patternSize_\n- * \\brief The size of the bayer pattern\n- *\n- * Valid sizes are: 2x2, 4x2 or 4x4.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::xShift_\n * \\brief The offset of x, applied to window_.x for bayer variants\n","prefixes":["05/27"]}