{"id":23201,"url":"https://patchwork.libcamera.org/api/1.1/patches/23201/?format=json","web_url":"https://patchwork.libcamera.org/patch/23201/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250421155109.175930-6-barnabas.pocze@ideasonboard.com>","date":"2025-04-21T15:51:09","name":"[RFC,v1,5/5] apps: cam: sdl_sink: Support `{RGB,BGR}888`","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bca5062ac2d40a4317ef896c92da222b51a0c667","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23201/mbox/","series":[{"id":5136,"url":"https://patchwork.libcamera.org/api/1.1/series/5136/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5136","date":"2025-04-21T15:51:04","name":"apps: cam: Support {RGB,BGR}888 format","version":1,"mbox":"https://patchwork.libcamera.org/series/5136/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23201/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23201/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B221C331E\n\tfor ;\n\tMon, 21 Apr 2025 15:51:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 255DD68AD8;\n\tMon, 21 Apr 2025 17:51:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACA2A68AC3\n\tfor ;\n\tMon, 21 Apr 2025 17:51:14 +0200 (CEST)","from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AF966D5\n\tfor ;\n\tMon, 21 Apr 2025 17:49:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"apEizoY3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745250548;\n\tbh=qilTFUMYiT0u0a0gF9NFLhvjVqE9yf0FqqheIQRhkG0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=apEizoY3cfHXpNnztj4L7cgsvv/q8jDCQA5whoWKo25LQKn8krZU69yemJzz0oDRj\n\tkk/jRbN4hZ2HNi4ZTnxsfVfM8xeaJPMJd0Yb/CjOn+W+As1d/jts0DdIX1JC5soZh5\n\tT8PtbotH034K8Iwo2VKjmkm9U5HEYcJbt6ATf7hE=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 5/5] apps: cam: sdl_sink: Support `{RGB,BGR}888`","Date":"Mon, 21 Apr 2025 17:51:09 +0200","Message-ID":"<20250421155109.175930-6-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250421155109.175930-1-barnabas.pocze@ideasonboard.com>","References":"<20250421155109.175930-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"These two formats map to `SDL_PIXELFORMAT_{RGB,BGR}24`, respectively;\nuse the generic `SDLTexture1Plane` to handle them.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/apps/cam/sdl_sink.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/src/apps/cam/sdl_sink.cpp b/src/apps/cam/sdl_sink.cpp\nindex b295675dc..51c8cfb52 100644\n--- a/src/apps/cam/sdl_sink.cpp\n+++ b/src/apps/cam/sdl_sink.cpp\n@@ -77,6 +77,12 @@ int SDLSink::configure(const libcamera::CameraConfiguration &config)\n \tcase libcamera::formats::YUYV:\n \t\ttexture_ = std::make_unique(rect_, SDL_PIXELFORMAT_YUY2, cfg.stride);\n \t\tbreak;\n+\tcase libcamera::formats::RGB888:\n+\t\ttexture_ = std::make_unique(rect_, SDL_PIXELFORMAT_RGB24, cfg.stride);\n+\t\tbreak;\n+\tcase libcamera::formats::BGR888:\n+\t\ttexture_ = std::make_unique(rect_, SDL_PIXELFORMAT_BGR24, cfg.stride);\n+\t\tbreak;\n \tdefault:\n \t\tstd::cerr << \"Unsupported pixel format \"\n \t\t\t << cfg.pixelFormat.toString() << std::endl;\n","prefixes":["RFC","v1","5/5"]}