{"id":23192,"url":"https://patchwork.libcamera.org/api/1.1/patches/23192/?format=json","web_url":"https://patchwork.libcamera.org/patch/23192/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250421153556.171192-3-barnabas.pocze@ideasonboard.com>","date":"2025-04-21T15:35:53","name":"[v2,2/5] libcamera: controls: Replace `numElements_` bit field","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5f8e0b5be96dc010853e58dddadf8ddfab2d0748","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23192/mbox/","series":[{"id":5135,"url":"https://patchwork.libcamera.org/api/1.1/series/5135/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5135","date":"2025-04-21T15:35:51","name":"libcamera: controls: Move constructor/assignment + swap","version":2,"mbox":"https://patchwork.libcamera.org/series/5135/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23192/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23192/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E230C32A2\n\tfor ;\n\tMon, 21 Apr 2025 15:36:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88D0468AD0;\n\tMon, 21 Apr 2025 17:36:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6300868ABA\n\tfor ;\n\tMon, 21 Apr 2025 17:36:00 +0200 (CEST)","from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C1AD66D5\n\tfor ;\n\tMon, 21 Apr 2025 17:33:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VQryxAPW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745249633;\n\tbh=Wq3YC8y0FCw4YsT9h4BTerhI+7A5jfaxldCogU8rsHM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=VQryxAPWRzAKxH/VZ3IcsXltvVw+JOv6LK6axLaJugV80r6HyGaKcnZ1JgUTcBNIN\n\tHbbAFr+j/flKvb5tUEHGTI5icgJiCBFAy+NBfSIoCKg6ZegzJPdKU1YZldXd15mHKr\n\tceD7NGPWm59j9Lo4eGEZq8OphHdolotL9vfSBhWU=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 2/5] libcamera: controls: Replace `numElements_` bit field","Date":"Mon, 21 Apr 2025 17:35:53 +0200","Message-ID":"<20250421153556.171192-3-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250421153556.171192-1-barnabas.pocze@ideasonboard.com>","References":"<20250421153556.171192-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of using a 32-bit wide bit field of `std::size_t`, simply\nuse a `uint32_t` to store the number of elements. This makes it\npossible to construct references, and use e.g. `std::swap()`.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/controls.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 1dc6ccffa..3f3580036 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -236,7 +236,7 @@ public:\n private:\n \tControlType type_ : 8;\n \tbool isArray_;\n-\tstd::size_t numElements_ : 32;\n+\tuint32_t numElements_;\n \tunion {\n \t\tuint64_t internal;\n \t\tvoid *external;\n","prefixes":["v2","2/5"]}