{"id":23182,"url":"https://patchwork.libcamera.org/api/1.1/patches/23182/?format=json","web_url":"https://patchwork.libcamera.org/patch/23182/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250325134231.1394418-1-barnabas.pocze@ideasonboard.com>","date":"2025-03-25T13:42:31","name":"[v2] libcamera: controls: Generate macro for each control","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"286564f18c7de1996d5b87c05127ac7870260608","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23182/mbox/","series":[{"id":5129,"url":"https://patchwork.libcamera.org/api/1.1/series/5129/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5129","date":"2025-03-25T13:42:31","name":"[v2] libcamera: controls: Generate macro for each control","version":2,"mbox":"https://patchwork.libcamera.org/series/5129/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23182/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23182/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":["parsemail@patchwork.libcamera.org","kbingham@ideasonboard.com"],"Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 015F5C327D\n\tfor ;\n\tThu, 17 Apr 2025 10:48:28 +0000 (UTC)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net\n\t[86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3813E55\n\tfor ;\n\tThu, 17 Apr 2025 12:46:25 +0200 (CEST)","from perceval.ideasonboard.com\n\tby perceval.ideasonboard.com with LMTP id 4OyMFF+y4mdHkC4A4E0KoQ\n\t(envelope-from )\n\tfor ; Tue, 25 Mar 2025 14:40:47 +0100","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\tby perceval.ideasonboard.com (Postfix) with\n\tESMTPSA id 0AE72353;\tTue, 25 Mar 2025 14:40:46 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744886785;\n\tbh=hWY+8HGZ0+XNHNvNm0h25Qj7jaFuqzBfYuLIxPkcQ5Y=;\n\th=From:To:Cc:Subject:Date:Resent-From:Resent-To:From;\n\tb=VcfZv5lcc/Dmc1Xg8imYMkbbJAKGxBp5pr78DgvXIghMHy0La0uDtPB0ipbt1SKDo\n\txYK0O4KzObk4JgnlmqizX0RTO1r13E07e+Jc9hRZEffsyW3IJyg8KN3gReAj514MxV\n\tSbOmsKJnEQANpSuewFwn6IOyyi1eVkLl/GuzNONs=","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742910047;\n\tbh=v5gXxSbhlP0InE7Psfvd0w+X4pbpEEe40A33IuzHck0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=DAMlsEDD9DOb0xdUG0Lf6rn/Z3rZ+cWXYB7KPY/jSV6A/q1iGPfBlaPKTvte3p8tJ\n\tjjhUMv/J2nIAmCCEwhflG6o61nzi4B8Xu4JnjleKVv+/OBH943l8E7xz3iQcuPt7Qo\n\tAChkx8nXapgxbzXBFtWFSVqOw5GhWB7B3wZ+iSbc="],"From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ,\n\tLaurent Pinchart ","Subject":"[PATCH v2] libcamera: controls: Generate macro for each control","Date":"Tue, 25 Mar 2025 14:42:31 +0100","Message-ID":"<20250325134231.1394418-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","X-TUID":"iv5ZLKZGXZjw","Resent-From":"Kieran Bingham ","Resent-To":"parsemail@patchwork.libcamera.org"},"content":"Generate a macro in the form of LIBCAMERA_HAS_$VENDOR_VENDOR_$MODE_$NAME\nfor each control so that its existence can be checked easily and without\nextra version checks.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\nchanges in v2:\n * rename macro from `LIBCAMERA_HAS_$VENDOR_$MODE_$NAME` to\n `LIBCAMERA_HAS_$VENDOR_VENDOR_$MODE_$NAME` so that has the\n ^^^^^^^\n name of the macro already generated for the control namespaces\n as prefix\n\nv1: https://patchwork.libcamera.org/patch/22972/\n---\n include/libcamera/control_ids.h.in | 1 +\n 1 file changed, 1 insertion(+)\n\n--\n2.49.0","diff":"diff --git a/include/libcamera/control_ids.h.in b/include/libcamera/control_ids.h.in\nindex 5d0594c68..6b5712339 100644\n--- a/include/libcamera/control_ids.h.in\n+++ b/include/libcamera/control_ids.h.in\n@@ -49,6 +49,7 @@ extern const std::array {{ctrl.n\n extern const std::map {{ctrl.name}}NameValueMap;\n {% endif -%}\n extern const Control<{{ctrl.type}}> {{ctrl.name}};\n+#define LIBCAMERA_HAS_{{vendor|upper}}_VENDOR_{{mode|upper}}_{{ctrl.name|snake_case|upper}}\n {% endfor -%}\n\n {% if vendor != 'libcamera' %}\n","prefixes":["v2"]}