{"id":23164,"url":"https://patchwork.libcamera.org/api/1.1/patches/23164/?format=json","web_url":"https://patchwork.libcamera.org/patch/23164/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250411123641.2144530-8-stefan.klug@ideasonboard.com>","date":"2025-04-11T12:36:35","name":"[v2,7/9] pipeline: rkisp1: Add color space information to debug log","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b1fc5bc17f109af811e49a18b568c6665ea134bd","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23164/mbox/","series":[{"id":5121,"url":"https://patchwork.libcamera.org/api/1.1/series/5121/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5121","date":"2025-04-11T12:36:28","name":"Wdr preparations","version":2,"mbox":"https://patchwork.libcamera.org/series/5121/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23164/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23164/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A28DC327D\n\tfor ;\n\tFri, 11 Apr 2025 12:37:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 108BF68AB7;\n\tFri, 11 Apr 2025 14:37:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B963C68AB4\n\tfor ;\n\tFri, 11 Apr 2025 14:37:06 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:5b21:2ad5:1023:7179])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 69502667;\n\tFri, 11 Apr 2025 14:35:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cc1WT0hL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744374907;\n\tbh=SeLXgg9s3PLEqT2OXDoSLbE6kZAMyEtled4XP+VsL7w=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cc1WT0hLCD7HqjHkQI/iJzJuMIAYKZq8mpn8yTlKK4XPL8euAr4ChrICXJCECPPSD\n\tELCMf39DIecPAodG4bK3O3Edqg+rzoLIT6guog9QYiWhUV8ICcJK/nsyc/WH+xZocA\n\tDpVotJg3RKzjxXC9exw8qe4yysWe9vz/BT11BJjM=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ","Subject":"[PATCH v2 7/9] pipeline: rkisp1: Add color space information to\n\tdebug log","Date":"Fri, 11 Apr 2025 14:36:35 +0200","Message-ID":"<20250411123641.2144530-8-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not\napplied correctly. Add the color space to the debug log output to be\nable to detect that now and later.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \n\n---\n\nChanges in v2:\n- Collected tag\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 9d7a3bd57ada..2708cecca0b0 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \n \tLOG(RkISP1, Debug)\n \t\t<< \"ISP output pad configured with \" << format\n-\t\t<< \" crop \" << outputCrop;\n+\t\t<< \" crop \" << outputCrop\n+\t\t<< \" color space \" << ColorSpace::toString(format.colorSpace);\n \n \tIPACameraSensorInfo sensorInfo;\n \tret = data->sensor_->sensorInfo(&sensorInfo);\n","prefixes":["v2","7/9"]}