{"id":23161,"url":"https://patchwork.libcamera.org/api/1.1/patches/23161/?format=json","web_url":"https://patchwork.libcamera.org/patch/23161/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250411123641.2144530-5-stefan.klug@ideasonboard.com>","date":"2025-04-11T12:36:32","name":"[v2,4/9] libipa: agc_mean_luminance: Add debug logging","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"01174f0b25c6f0702b3d18fd141801c1c8a99681","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23161/mbox/","series":[{"id":5121,"url":"https://patchwork.libcamera.org/api/1.1/series/5121/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5121","date":"2025-04-11T12:36:28","name":"Wdr preparations","version":2,"mbox":"https://patchwork.libcamera.org/series/5121/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23161/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23161/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49C65C327D\n\tfor ;\n\tFri, 11 Apr 2025 12:37:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3B5368AB0;\n\tFri, 11 Apr 2025 14:36:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 106AE68AA8\n\tfor ;\n\tFri, 11 Apr 2025 14:36:58 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:5b21:2ad5:1023:7179])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A91911E6;\n\tFri, 11 Apr 2025 14:34:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YyVzz7sp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744374898;\n\tbh=AnGC7HT7rautr3JzU7N6bgqoP+fsGrVKtGRYvOLkXgo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YyVzz7sp9K+HrcjNbPAa1tfxlkacXMqkzoU+uP7wpOM2YtMlp3fR3TfM/HLSqIrxT\n\tmbJojjQyB2D1uliLL5f6gE6hvdoDBx36KXpzjWtBRl6GQAUZFNbbKA59vh2ynTBmO3\n\txNjoSYJTD8RjlOAmmSid2pVXa8FhS8ZDNl7Jk+sA=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tDaniel Scally ","Subject":"[PATCH v2 4/9] libipa: agc_mean_luminance: Add debug logging","Date":"Fri, 11 Apr 2025 14:36:32 +0200","Message-ID":"<20250411123641.2144530-5-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When debugging the AEGC it is important to know when the constraints\napply. As this is important information for anyone doing tuning file\noptimization, add it upstream.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Daniel Scally \n\n---\n\nChanges in v2:\n- Collected tags\n---\n src/ipa/libipa/agc_mean_luminance.cpp | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex f617fde81101..9154f083a510 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -468,12 +468,16 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \t\t\t\t hist.interQuantileMean(constraint.qLo, constraint.qHi);\n \n \t\tif (constraint.bound == AgcConstraint::Bound::Lower &&\n-\t\t newGain > gain)\n+\t\t newGain > gain) {\n \t\t\tgain = newGain;\n+\t\t\tLOG(AgcMeanLuminance, Debug) << \"Apply lower bound: \" << gain << \" to \" << newGain;\n+\t\t}\n \n \t\tif (constraint.bound == AgcConstraint::Bound::Upper &&\n-\t\t newGain < gain)\n+\t\t newGain < gain) {\n \t\t\tgain = newGain;\n+\t\t\tLOG(AgcMeanLuminance, Debug) << \"Apply upper bound: \" << gain << \" to \" << newGain;\n+\t\t}\n \t}\n \n \treturn gain;\n","prefixes":["v2","4/9"]}