{"id":23130,"url":"https://patchwork.libcamera.org/api/1.1/patches/23130/?format=json","web_url":"https://patchwork.libcamera.org/patch/23130/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250403154925.382973-15-stefan.klug@ideasonboard.com>","date":"2025-04-03T15:49:19","name":"[v3,14/16] ipa: rkisp1: Damp color temperature regulation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"33194b578d0b61a2788a0842434406efec82ba34","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23130/mbox/","series":[{"id":5111,"url":"https://patchwork.libcamera.org/api/1.1/series/5111/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5111","date":"2025-04-03T15:49:05","name":"Some rkisp1 awb improvements","version":3,"mbox":"https://patchwork.libcamera.org/series/5111/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23130/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23130/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03D0FC327D\n\tfor ;\n\tThu, 3 Apr 2025 15:50:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC4A968AAA;\n\tThu, 3 Apr 2025 17:50:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8086D68AAA\n\tfor ;\n\tThu, 3 Apr 2025 17:50:17 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6d9d:9854:3fc1:4bb2])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B669216B0;\n\tThu, 3 Apr 2025 17:48:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U1OiH8SA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743695303;\n\tbh=ZzN7OkSIfM672x0jenTKoBWqnOwUQxCwrET3J40FR88=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=U1OiH8SA1WTxVjVOPAUh8rZKBWMfta/UuyVD/PpK7tte+8D1wrrFL8Y9TiWhz0Rcm\n\tX+C2MQBcpA4FRP+9sTmY3G5zb9mxVzUD/GvIq2u9giQGi2KL8q78yNmFfNq7n/P8A4\n\tWFjYk5ws4hKUZoQoQ8rP2g8VBW0TfQrV6R8R+KQo=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ","Subject":"[PATCH v3 14/16] ipa: rkisp1: Damp color temperature regulation","Date":"Thu, 3 Apr 2025 17:49:19 +0200","Message-ID":"<20250403154925.382973-15-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250403154925.382973-1-stefan.klug@ideasonboard.com>","References":"<20250403154925.382973-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Damp the regulation of the color temperature with the same factor as the\ngains. Not damping the color temperature leads to visible flicker, as\nthe CCM changes too much.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \n\n---\n\nChanges in v2:\n- Collected tags\n\nChanges in v3:\n- Dropped incorrect call to estimateCCT()\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 5 +++--\n src/ipa/rkisp1/algorithms/ccm.cpp | 4 ----\n 2 files changed, 3 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex f5415a0bb99d..47b29725af51 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -317,8 +317,6 @@ void Awb::process(IPAContext &context,\n \tRkISP1AwbStats awbStats{ rgbMeans };\n \tAwbResult awbResult = awbAlgo_->calculateAwb(awbStats, frameContext.lux.lux);\n \n-\tactiveState.awb.automatic.temperatureK = awbResult.colourTemperature;\n-\n \t/*\n \t * Clamp the gain values to the hardware, which expresses gains as Q2.8\n \t * unsigned integer values. Set the minimum just above zero to avoid\n@@ -329,9 +327,12 @@ void Awb::process(IPAContext &context,\n \n \t/* Filter the values to avoid oscillations. */\n \tdouble speed = 0.2;\n+\tdouble ct = awbResult.colourTemperature;\n+\tct = ct * speed + activeState.awb.automatic.temperatureK * (1 - speed);\n \tawbResult.gains = awbResult.gains * speed +\n \t\t\t activeState.awb.automatic.gains * (1 - speed);\n \n+\tactiveState.awb.automatic.temperatureK = static_cast(ct);\n \tactiveState.awb.automatic.gains = awbResult.gains;\n \n \tLOG(RkISP1Awb, Debug)\ndiff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\nindex 3a96a5427bc6..de2b6fe775aa 100644\n--- a/src/ipa/rkisp1/algorithms/ccm.cpp\n+++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n@@ -142,10 +142,6 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \t}\n \n \tuint32_t ct = frameContext.awb.temperatureK;\n-\t/*\n-\t * \\todo The colour temperature will likely be noisy, add filtering to\n-\t * avoid updating the CCM matrix all the time.\n-\t */\n \tif (frame > 0 && ct == ct_) {\n \t\tframeContext.ccm.ccm = context.activeState.ccm.automatic;\n \t\treturn;\n","prefixes":["v3","14/16"]}