{"id":23113,"url":"https://patchwork.libcamera.org/api/1.1/patches/23113/?format=json","web_url":"https://patchwork.libcamera.org/patch/23113/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250403074551.263496-5-stanislaw.gruszka@linux.intel.com>","date":"2025-04-03T07:45:50","name":"[v7,4/5] pipeline: simple: Create DelayedControls instance once only","commit_ref":"8a7980008933ca3c549f86c5105d9562273edc93","pull_url":null,"state":"accepted","archived":false,"hash":"81213dc8c1e900ec36adaddfda23efdba6a181d6","submitter":{"id":211,"url":"https://patchwork.libcamera.org/api/1.1/people/211/?format=json","name":"Stanislaw Gruszka","email":"stanislaw.gruszka@linux.intel.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23113/mbox/","series":[{"id":5109,"url":"https://patchwork.libcamera.org/api/1.1/series/5109/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5109","date":"2025-04-03T07:45:46","name":"libcamera: start frame events changes","version":7,"mbox":"https://patchwork.libcamera.org/series/5109/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23113/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23113/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A992CC3213\n\tfor ;\n\tThu, 3 Apr 2025 07:46:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55B45689A6;\n\tThu, 3 Apr 2025 09:46:19 +0200 (CEST)","from mgamail.intel.com (mgamail.intel.com [198.175.65.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3F3A689A0\n\tfor ;\n\tThu, 3 Apr 2025 09:46:16 +0200 (CEST)","from orviesa001.jf.intel.com ([10.64.159.141])\n\tby orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2025 00:46:16 -0700","from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.246.8.237])\n\tby smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2025 00:46:13 -0700"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"CcCeeVMn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1743666377; x=1775202377;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=qBUl+9nQXJ/cOw+W0Ys07mYDrg2vpWXEtVlAozbyPgA=;\n\tb=CcCeeVMnhdCV8vy3g8UeBs2Q7Rr0zzVKGXu5st1UAmDJp9tvTJ4D2Kp5\n\tKmuB9wsJPcpd3nMkYy2dI7L94o83O9J0jWXkj06tfKEzpxeuW/CGFGk08\n\tfVD1CRl3eJsLpGBqKPrWXEmNDw3XW2lGKl9PDX5v7tgBmvgNpGK1f0she\n\tUfN9iORx6zomkBJTNfaguR5wcfWNvHXxvgoGayaESJUxosN+mGRLl4hKq\n\tHFNx6iSdGoqeSPzF/RylBX4QwOI1PlUIB+QY7IuH+g27FHGAxRSRad2eM\n\tqYtRDew5CMJT0DIpbGQpDXmkcyEJPbrvY+jJ73GxtBOS9ZXk25URYPmuw A==;","X-CSE-ConnectionGUID":["Hy3/JCxCQnKuTESRiQrbYA==","GUPuFUV3RSarpg9DYf8/8Q=="],"X-CSE-MsgGUID":["XqqP4ozPSA+JZ3BmzjWE/w==","29NOJPhZTmqKO461LOcg0g=="],"X-IronPort-AV":["E=McAfee;i=\"6700,10204,11392\"; a=\"48721721\"","E=Sophos;i=\"6.15,184,1739865600\"; d=\"scan'208\";a=\"48721721\"","E=Sophos;i=\"6.15,184,1739865600\"; d=\"scan'208\";a=\"164159703\""],"X-ExtLoop1":"1","From":"Stanislaw Gruszka ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Hans de Goede ,\n\tLaurent Pinchart ,\n\tKieran Bingham ,\n\tSakari Ailus ,\n\tStefan Klug ","Subject":"[PATCH v7 4/5] pipeline: simple: Create DelayedControls instance\n\tonce only","Date":"Thu, 3 Apr 2025 09:45:50 +0200","Message-Id":"<20250403074551.263496-5-stanislaw.gruszka@linux.intel.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20250403074551.263496-1-stanislaw.gruszka@linux.intel.com>","References":"<20250403074551.263496-1-stanislaw.gruszka@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Laurent Pinchart \n\nThe DelayedControls instance for the camera sensor is created in\nSimplePipelineHandler::configure(). Constant deletion and reconstruction\nof a new object is unnecessary, as the control delays are an intrinsic\nproperty of the sensor and are known at initialization time. Move the\nDelayedControls creation to the SimpleCameraData class constructor.\n\nReviewed-by: Stefan Klug # v6\nSigned-off-by: Laurent Pinchart \nSigned-off-by: Stanislaw Gruszka \n---\n src/libcamera/pipeline/simple/simple.cpp | 16 +++++++---------\n 1 file changed, 7 insertions(+), 9 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex c97904076b63..262192b849e2 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -542,6 +542,13 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n \tif (!sensor_)\n \t\treturn;\n \n+\tconst CameraSensorProperties::SensorDelays &delays = sensor_->sensorDelays();\n+\tstd::unordered_map params = {\n+\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n+\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n+\t};\n+\tdelayedCtrls_ = std::make_unique(sensor_->device(), params);\n+\n \tLOG(SimplePipeline, Debug)\n \t\t<< \"Found pipeline: \"\n \t\t<< utils::join(entities_, \" -> \",\n@@ -1388,15 +1395,6 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tif (outputCfgs.empty())\n \t\treturn 0;\n \n-\tconst CameraSensorProperties::SensorDelays &delays = data->sensor_->sensorDelays();\n-\tstd::unordered_map params = {\n-\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n-\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n-\t};\n-\tdata->delayedCtrls_ =\n-\t\tstd::make_unique(data->sensor_->device(),\n-\t\t\t\t\t\t params);\n-\n \tStreamConfiguration inputCfg;\n \tinputCfg.pixelFormat = pipeConfig->captureFormat;\n \tinputCfg.size = pipeConfig->captureSize;\n","prefixes":["v7","4/5"]}