{"id":23110,"url":"https://patchwork.libcamera.org/api/1.1/patches/23110/?format=json","web_url":"https://patchwork.libcamera.org/patch/23110/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250403074551.263496-2-stanislaw.gruszka@linux.intel.com>","date":"2025-04-03T07:45:47","name":"[v7,1/5] libcamera: v4l2_device: add frame start event helpers","commit_ref":"b2eccef711e621748c90fe5bf69ae91d1bd901e8","pull_url":null,"state":"accepted","archived":false,"hash":"6792a3aa33671b3df1bad821596bb0c71370e923","submitter":{"id":211,"url":"https://patchwork.libcamera.org/api/1.1/people/211/?format=json","name":"Stanislaw Gruszka","email":"stanislaw.gruszka@linux.intel.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23110/mbox/","series":[{"id":5109,"url":"https://patchwork.libcamera.org/api/1.1/series/5109/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5109","date":"2025-04-03T07:45:46","name":"libcamera: start frame events changes","version":7,"mbox":"https://patchwork.libcamera.org/series/5109/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23110/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23110/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8944C3213\n\tfor ;\n\tThu, 3 Apr 2025 07:46:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A82C6899C;\n\tThu, 3 Apr 2025 09:46:04 +0200 (CEST)","from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F8AD6899A\n\tfor ;\n\tThu, 3 Apr 2025 09:46:01 +0200 (CEST)","from orviesa003.jf.intel.com ([10.64.159.143])\n\tby fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2025 00:46:01 -0700","from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.246.8.237]) by ORVIESA003-auth.jf.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2025 00:45:59 -0700"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"iYHlwgKr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1743666362; x=1775202362;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=7gNkBCS+9eOAC6ByJMdpQJ24EewFwjpekuV8RTbAeDQ=;\n\tb=iYHlwgKrOOcdvQaX4by+kqxdO3XW6OShS4qa2Mo4TIe4ySzXTxxFNdgN\n\tb/Ilsx7q3MoYI/XPZekRoppqF8mdyLKbwkWRXRreiqGhPBrxyH3o0ZDPC\n\tG6ImQ+/ortwNqqLtLRKePAWKm/iD2kbMfMPJoEzs/gOcJc+H5RrezQ9LR\n\tRaUdZCbQVfWW9j0RAKvDK6YrJbpFbQYeq2Dvw7NxvXFfSK5AxCT/GFk+R\n\tcaBEkSHGS5wq2xR3PllL/QSu2OlnHentEZcVtKml59VA0EnpMU75OqyIf\n\tWBOy+02qwxoWZJ19VWhjqBSZZMGVpp1f69Q32BHzRNx1pOVRXQtux3wHi A==;","X-CSE-ConnectionGUID":["XFA+Es8NSuGZ35o/ptJuXA==","LjaaaMbSS6O/4MdG+QSv6Q=="],"X-CSE-MsgGUID":["xCKVpkEwQUqLylnrE+UDmw==","vSoDpjDVSS+Qcx1gAssPUg=="],"X-IronPort-AV":["E=McAfee;i=\"6700,10204,11392\"; a=\"70425135\"","E=Sophos;i=\"6.15,184,1739865600\"; d=\"scan'208\";a=\"70425135\"","E=Sophos;i=\"6.15,184,1739865600\"; d=\"scan'208\";a=\"131785136\""],"X-ExtLoop1":"1","From":"Stanislaw Gruszka ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Hans de Goede ,\n\tLaurent Pinchart ,\n\tKieran Bingham ,\n\tSakari Ailus ","Subject":"[PATCH v7 1/5] libcamera: v4l2_device: add frame start event helpers","Date":"Thu, 3 Apr 2025 09:45:47 +0200","Message-Id":"<20250403074551.263496-2-stanislaw.gruszka@linux.intel.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20250403074551.263496-1-stanislaw.gruszka@linux.intel.com>","References":"<20250403074551.263496-1-stanislaw.gruszka@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add helper to check if frame start event are supported by subdevice.\nSince kernel does not have interface to query supported events\nuse subscribe interface.\n\nReviewed-by: Kieran Bingham # v3\nReviewed-by: Laurent Pinchart # v5\nSigned-off-by: Stanislaw Gruszka \n---\n include/libcamera/internal/v4l2_device.h | 1 +\n src/libcamera/v4l2_device.cpp | 22 ++++++++++++++++++++++\n 2 files changed, 23 insertions(+)","diff":"diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\nindex affe52c2ad3f..a647c96a5eb7 100644\n--- a/include/libcamera/internal/v4l2_device.h\n+++ b/include/libcamera/internal/v4l2_device.h\n@@ -45,6 +45,7 @@ public:\n \tconst std::string &deviceNode() const { return deviceNode_; }\n \tstd::string devicePath() const;\n \n+\tbool supportsFrameStartEvent();\n \tint setFrameStartEnabled(bool enable);\n \tSignal frameStart;\n \ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 2f65a43a0547..0db92c19ca4a 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -449,6 +449,28 @@ std::string V4L2Device::devicePath() const\n \treturn path;\n }\n \n+/**\n+ * \\brief Check if frame start event is supported\n+ *\n+ * Due to limitations in the kernel API, this function may disable the frame\n+ * start event as a side effect. It should only be called during initialization,\n+ * before enabling the frame start event with setFrameStartEnabled().\n+ *\n+ * \\return True if frame start event is supported, false otherwise\n+ */\n+bool V4L2Device::supportsFrameStartEvent()\n+{\n+\tstruct v4l2_event_subscription event{};\n+\tevent.type = V4L2_EVENT_FRAME_SYNC;\n+\n+\tint ret = ioctl(VIDIOC_SUBSCRIBE_EVENT, &event);\n+\tif (ret)\n+\t\treturn false;\n+\n+\tioctl(VIDIOC_UNSUBSCRIBE_EVENT, &event);\n+\treturn true;\n+}\n+\n /**\n * \\brief Enable or disable frame start event notification\n * \\param[in] enable True to enable frame start events, false to disable them\n","prefixes":["v7","1/5"]}