{"id":231,"url":"https://patchwork.libcamera.org/api/1.1/patches/231/?format=json","web_url":"https://patchwork.libcamera.org/patch/231/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190115140749.8297-5-jacopo@jmondi.org>","date":"2019-01-15T14:07:49","name":"[libcamera-devel,4/4] libcamera: pipeline: Add Intel IPU3 pipeline","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7bd7853d2d8dcbf026db5a2812ec219388f72e9e","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/231/mbox/","series":[{"id":80,"url":"https://patchwork.libcamera.org/api/1.1/series/80/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=80","date":"2019-01-15T14:07:45","name":"libcamera: IPU3: Add pipeline handler","version":1,"mbox":"https://patchwork.libcamera.org/series/80/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/231/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/231/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BCF260C8D\n\tfor ;\n\tTue, 15 Jan 2019 15:07:49 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id D5B5B200011;\n\tTue, 15 Jan 2019 14:07:48 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 15 Jan 2019 15:07:49 +0100","Message-Id":"<20190115140749.8297-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190115140749.8297-1-jacopo@jmondi.org>","References":"<20190115140749.8297-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/4] libcamera: pipeline: Add Intel IPU3\n\tpipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Jan 2019 14:07:49 -0000"},"content":"Add a pipeline handler for the Intel IPU3 device.\n\nThe pipeline handler creates a Camera for each image sensor it finds to be\nconnected to an IPU3 CSI-2 receiver, and enables the link between the two.\n\nTested on Soraka, listing detected cameras on the system, verifying the\npipeline handler gets matched and links properly enabled.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 249 ++++++++++++++++++++++++\n src/libcamera/pipeline/ipu3/meson.build | 3 +\n src/libcamera/pipeline/meson.build | 2 +\n 3 files changed, 254 insertions(+)\n create mode 100644 src/libcamera/pipeline/ipu3/ipu3.cpp\n create mode 100644 src/libcamera/pipeline/ipu3/meson.build","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nnew file mode 100644\nindex 0000000..4c24c79\n--- /dev/null\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -0,0 +1,249 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * ipu3.cpp - Pipeline handler for Intel IPU3\n+ */\n+\n+#include \n+#include \n+\n+#include \n+\n+#include \"device_enumerator.h\"\n+#include \"log.h\"\n+#include \"media_device.h\"\n+#include \"pipeline_handler.h\"\n+\n+namespace libcamera {\n+\n+class PipelineHandlerIPU3 : public PipelineHandler\n+{\n+public:\n+\tPipelineHandlerIPU3();\n+\t~PipelineHandlerIPU3();\n+\n+\tbool match(DeviceEnumerator *enumerator);\n+\n+\tunsigned int count();\n+\tCamera *camera(unsigned int id) final;\n+\n+private:\n+\tMediaDevice *cio2_;\n+\tMediaDevice *imgu_;\n+\n+\tunsigned int numCameras_;\n+\tstd::map cameras_;\n+\n+\tunsigned int registerCameras();\n+};\n+\n+PipelineHandlerIPU3::PipelineHandlerIPU3()\n+\t: cio2_(nullptr), imgu_(nullptr), numCameras_(0)\n+{\n+}\n+\n+PipelineHandlerIPU3::~PipelineHandlerIPU3()\n+{\n+\tif (cio2_)\n+\t\tcio2_->release();\n+\n+\tif (imgu_)\n+\t\timgu_->release();\n+\n+\tfor (auto camera : cameras_) {\n+\t\tif (!camera.second)\n+\t\t\tcontinue;\n+\n+\t\tcamera.second->put();\n+\n+\t\t/*\n+\t\t * FIXME\n+\t\t * The lifetime management of Camera instances will be\n+\t\t * soon changed: as of now, the handler creates cameras, and\n+\t\t * -shall- destroy them as well to avoid leaks.\n+\t\t */\n+\t\tdelete camera.second;\n+\t}\n+\n+\tcio2_ = nullptr;\n+\timgu_ = nullptr;\n+\tcameras_.clear();\n+}\n+\n+unsigned int PipelineHandlerIPU3::count()\n+{\n+\treturn numCameras_;\n+}\n+\n+Camera *PipelineHandlerIPU3::camera(unsigned int id)\n+{\n+\tif (id >= numCameras_)\n+\t\treturn nullptr;\n+\n+\t/*\n+\t * The requested camera id does not match the key index used to store\n+\t * Camera instances in the 'cameras_' map.\n+\t *\n+\t * The 'id' argument represent the n-th valid cameras registered\n+\t * in the system, while the indexing key is the CSI-2 receiver index\n+\t * the camera sensor is associated to, and some receiver might have no\n+\t * camera sensor connected.\n+\t */\n+\tfor (auto it = cameras_.begin(); it != cameras_.end(); ++it, --id) {\n+\t\tif (id == 0)\n+\t\t\treturn (*it).second;\n+\t}\n+\n+\treturn nullptr;\n+}\n+\n+bool PipelineHandlerIPU3::match(DeviceEnumerator *enumerator)\n+{\n+\tDeviceMatch cio2_dm(\"ipu3-cio2\");\n+\tcio2_dm.add(\"ipu3-csi2 0\");\n+\tcio2_dm.add(\"ipu3-cio2 0\");\n+\tcio2_dm.add(\"ipu3-csi2 1\");\n+\tcio2_dm.add(\"ipu3-cio2 1\");\n+\tcio2_dm.add(\"ipu3-csi2 2\");\n+\tcio2_dm.add(\"ipu3-cio2 2\");\n+\tcio2_dm.add(\"ipu3-csi2 3\");\n+\tcio2_dm.add(\"ipu3-cio2 3\");\n+\n+\tcio2_ = enumerator->search(cio2_dm);\n+\tif (!cio2_)\n+\t\treturn false;\n+\n+\tcio2_->acquire();\n+\n+\tDeviceMatch imgu_dm(\"ipu3-imgu\");\n+\timgu_dm.add(\"ipu3-imgu 0\");\n+\timgu_dm.add(\"ipu3-imgu 0 input\");\n+\timgu_dm.add(\"ipu3-imgu 0 parameters\");\n+\timgu_dm.add(\"ipu3-imgu 0 output\");\n+\timgu_dm.add(\"ipu3-imgu 0 viewfinder\");\n+\timgu_dm.add(\"ipu3-imgu 0 3a stat\");\n+\timgu_dm.add(\"ipu3-imgu 1\");\n+\timgu_dm.add(\"ipu3-imgu 1 input\");\n+\timgu_dm.add(\"ipu3-imgu 1 parameters\");\n+\timgu_dm.add(\"ipu3-imgu 1 output\");\n+\timgu_dm.add(\"ipu3-imgu 1 viewfinder\");\n+\timgu_dm.add(\"ipu3-imgu 1 3a stat\");\n+\n+\timgu_ = enumerator->search(imgu_dm);\n+\tif (!imgu_) {\n+\t\tcio2_->release();\n+\t\treturn false;\n+\t}\n+\n+\timgu_->acquire();\n+\n+\t/*\n+\t * Disable all links that are enabled by default on CIO2, as camera\n+\t * creation enables all valid links it finds.\n+\t *\n+\t * Close the CIO2 media device after, as links are enabled and should\n+\t * not need to be changed after.\n+\t */\n+\tif (cio2_->open()) {\n+\t\tcio2_->release();\n+\t\timgu_->release();\n+\t\treturn false;\n+\t}\n+\tcio2_->disableLinks();\n+\n+\tnumCameras_ = registerCameras();\n+\tLOG(Debug) << \"\\\"Intel IPU3\\\" pipeline handler initialized with \"\n+\t\t << numCameras_ << \" cameras registered\";\n+\n+\tcio2_->close();\n+\n+\treturn true;\n+}\n+\n+/*\n+ * Cameras are created associating an image sensor (represented by a\n+ * media entity with function MEDIA_ENT_F_CAM_SENSOR) to one of the four\n+ * CIO2 CSI-2 receivers.\n+ *\n+ * Cameras are here created and stored in the member field 'cameras_' map,\n+ * indexed by the id of the CSI-2 receiver they are connected, to maintain\n+ * an ordering that does not depend on the device enumeration order.\n+ *\n+ * The function returns the number of cameras found in the system.\n+ */\n+unsigned int PipelineHandlerIPU3::registerCameras()\n+{\n+\tconst std::vector entities = cio2_->entities();\n+\tunsigned int numCameras = 0;\n+\tstruct {\n+\t\tunsigned int id;\n+\t\tMediaEntity *csi2;\n+\t} csi2Receivers[] = {\n+\t\t{ 0, cio2_->getEntityByName(\"ipu3-csi2 0\") },\n+\t\t{ 1, cio2_->getEntityByName(\"ipu3-csi2 1\") },\n+\t\t{ 2, cio2_->getEntityByName(\"ipu3-csi2 2\") },\n+\t\t{ 3, cio2_->getEntityByName(\"ipu3-csi2 3\") },\n+\t};\n+\n+\t/*\n+\t * For each CSI-2 receiver on the IPU3, create a Camera if an\n+\t * image sensor is connected to it.\n+\t */\n+\tfor (auto csi2Receiver : csi2Receivers) {\n+\t\tMediaEntity *csi2 = csi2Receiver.csi2;\n+\t\tunsigned int id = csi2Receiver.id;\n+\n+\t\t/* IPU3 CSI-2 receivers have a single sink pad. */\n+\t\tstd::vector pads = csi2->pads();\n+\t\tMediaPad *sink;\n+\t\tfor (MediaPad *pad : pads) {\n+\t\t\tif (!(pad->flags() & MEDIA_PAD_FL_SINK))\n+\t\t\t\tcontinue;\n+\n+\t\t\tsink = pad;\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\t/* Verify that the receiver is connected to a sensor. */\n+\t\tstd::vector links = sink->links();\n+\t\tif (links.empty())\n+\t\t\tcontinue;\n+\n+\t\t/*\n+\t\t * FIXME\n+\t\t * This supports creating a single camera per CSI-2 receiver.\n+\t\t */\n+\t\tfor (MediaLink *link : links) {\n+\t\t\tMediaEntity *sensor = link->source()->entity();\n+\t\t\tif (!sensor)\n+\t\t\t\tcontinue;\n+\n+\t\t\tif (sensor->function() != MEDIA_ENT_F_CAM_SENSOR)\n+\t\t\t\tcontinue;\n+\n+\t\t\t/* Enable the link between sensor and CSI-2 receiver. */\n+\t\t\tif (link->setEnabled(true))\n+\t\t\t\tcontinue;\n+\n+\t\t\t/* Create the camera using the sensor name. */\n+\t\t\tstd::size_t pos = sensor->name().find(\" \");\n+\t\t\tstd::string cameraName = sensor->name().substr(0, pos);\n+\n+\t\t\tcameras_[id] = new Camera(cameraName);\n+\n+\t\t\tLOG(Debug) << \"Registered Camera[\" << numCameras\n+\t\t\t\t << \"] \\\"\" << cameraName << \"\\\"\"\n+\t\t\t\t << \" connected to CSI-2 receiver \" << id;\n+\n+\t\t\tnumCameras++;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\treturn numCameras;\n+}\n+\n+REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3);\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/ipu3/meson.build b/src/libcamera/pipeline/ipu3/meson.build\nnew file mode 100644\nindex 0000000..0ab766a\n--- /dev/null\n+++ b/src/libcamera/pipeline/ipu3/meson.build\n@@ -0,0 +1,3 @@\n+libcamera_sources += files([\n+ 'ipu3.cpp',\n+])\ndiff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build\nindex 615ecd2..811c075 100644\n--- a/src/libcamera/pipeline/meson.build\n+++ b/src/libcamera/pipeline/meson.build\n@@ -1,3 +1,5 @@\n libcamera_sources += files([\n 'vimc.cpp',\n ])\n+\n+subdir('ipu3')\n","prefixes":["libcamera-devel","4/4"]}