{"id":23097,"url":"https://patchwork.libcamera.org/api/1.1/patches/23097/?format=json","web_url":"https://patchwork.libcamera.org/patch/23097/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250401131939.749583-4-barnabas.pocze@ideasonboard.com>","date":"2025-04-01T13:19:38","name":"[v1,3/4] libcamera: controls: Arrays of arrays are not supported","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"11cbb6eb64a25668634e3ca580d2b76bce10fefc","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23097/mbox/","series":[{"id":5101,"url":"https://patchwork.libcamera.org/api/1.1/series/5101/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5101","date":"2025-04-01T13:19:35","name":"libcamera: controls: Misc. changes","version":1,"mbox":"https://patchwork.libcamera.org/series/5101/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23097/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23097/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1D06C3285\n\tfor ;\n\tTue, 1 Apr 2025 13:19:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 185E768990;\n\tTue, 1 Apr 2025 15:19:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFC3068986\n\tfor ;\n\tTue, 1 Apr 2025 15:19:43 +0200 (CEST)","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92B7B741\n\tfor ;\n\tTue, 1 Apr 2025 15:17:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JC3Y7/52\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743513471;\n\tbh=EpkGhHNS5HImyJZXfISov2jRw9zVlkHDv1JtN4TxPNE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=JC3Y7/52MJp3RO/L8eO7i7YDTm2zQOcXROXiya2ZmemJfYLD7WNWnC2L1t7BEFgkI\n\tDvvRsD2p4gcpfpERwbbfM2ZezYMcEgrxJMMxQKa7sqvf0AKYWAXqjSac05wbbl7jkf\n\tLXNzw9Ca7kwZX7K9qtMrZKG0qeGrqiVdQ68W+bZ4=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1 3/4] libcamera: controls: Arrays of arrays are not\n\tsupported","Date":"Tue, 1 Apr 2025 15:19:38 +0200","Message-ID":"<20250401131939.749583-4-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250401131939.749583-1-barnabas.pocze@ideasonboard.com>","References":"<20250401131939.749583-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Arrays of arrays, even arrays of strings, are not supported by\nthe current `ControlValue` mechanism, so disable them to trigger\ncomptime errors if attempts are made to use them.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/controls.h | 2 +-\n src/apps/cam/capture_script.cpp | 4 ----\n 2 files changed, 1 insertion(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex d35347f4c..85c724ec1 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -120,7 +120,7 @@ struct control_type {\n };\n \n template\n-struct control_type> : public control_type> {\n+struct control_type, std::enable_if_t>::size == 0>> : public control_type> {\n \tstatic constexpr std::size_t size = N;\n };\n \ndiff --git a/src/apps/cam/capture_script.cpp b/src/apps/cam/capture_script.cpp\nindex fc1dfa75f..f3262af98 100644\n--- a/src/apps/cam/capture_script.cpp\n+++ b/src/apps/cam/capture_script.cpp\n@@ -600,10 +600,6 @@ ControlValue CaptureScript::parseArrayControl(const ControlId *id,\n \t\tvalue = Span(values.data(), values.size());\n \t\tbreak;\n \t}\n-\tcase ControlTypeString: {\n-\t\tvalue = Span(repr.data(), repr.size());\n-\t\tbreak;\n-\t}\n \tdefault:\n \t\tstd::cerr << \"Unsupported control type\" << std::endl;\n \t\tbreak;\n","prefixes":["v1","3/4"]}