{"id":23086,"url":"https://patchwork.libcamera.org/api/1.1/patches/23086/?format=json","web_url":"https://patchwork.libcamera.org/patch/23086/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250401093308.475810-1-stanislaw.gruszka@linux.intel.com>","date":"2025-04-01T09:33:08","name":"ipa: simple: Initialize ccmEnabled to false","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"558ab6e1132a6e88f8d4023c442e7cbda92288ce","submitter":{"id":211,"url":"https://patchwork.libcamera.org/api/1.1/people/211/?format=json","name":"Stanislaw Gruszka","email":"stanislaw.gruszka@linux.intel.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23086/mbox/","series":[{"id":5098,"url":"https://patchwork.libcamera.org/api/1.1/series/5098/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5098","date":"2025-04-01T09:33:08","name":"ipa: simple: Initialize ccmEnabled to false","version":1,"mbox":"https://patchwork.libcamera.org/series/5098/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23086/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23086/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80EC2C323E\n\tfor ;\n\tTue, 1 Apr 2025 09:33:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA1C868980;\n\tTue, 1 Apr 2025 11:33:16 +0200 (CEST)","from mgamail.intel.com (mgamail.intel.com [192.198.163.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0C9268947\n\tfor ;\n\tTue, 1 Apr 2025 11:33:14 +0200 (CEST)","from orviesa003.jf.intel.com ([10.64.159.143])\n\tby fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t01 Apr 2025 02:33:13 -0700","from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.245.112.43]) by ORVIESA003-auth.jf.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2025 02:33:10 -0700"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"DxjLn+cd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1743499994; x=1775035994;\n\th=from:to:cc:subject:date:message-id:mime-version:\n\tcontent-transfer-encoding;\n\tbh=1MJ8GH3VO5tzN+61G4wYUtJ3/CFveBPuvdirr6mOhSk=;\n\tb=DxjLn+cdT++yjrxjD6FDBxXpkfgH827KUpe0dvlkwZkfmEK//7vN5I5+\n\tfcUj00cbRP1qG3u0aGUo47xg4DDRU6ilgi5NRlgxGVCZt+4lCRko3EInH\n\tBRI4X2R+/7VNxWBQzVAsRazy82+MTcm/T6JtSMIUFj/YSdPJKGRVvvzks\n\txqmRzQ9lA+zED5ycBs7ngf7xtKnY425QSIPvZRyu4Z/Dx0yfzmtk1df/1\n\tSRbozpzy5IbUJQErpiUyrSEdZqyPojH6TNuo/BWavF9YDPjZSv5IWXYoi\n\tktyAkF/D2GnnNv3dvKpZxv0HBQMK4Rsg4ZM6CHVSMU/A9UqnDAi/K42Gq w==;","X-CSE-ConnectionGUID":["X0RMQwyQRXyAaexImh3Rgw==","kzMyOMoRQRm1P9VwnHl5ZQ=="],"X-CSE-MsgGUID":["xg18cPe4RgmEMmWKyyKwLA==","aiNavPtfSV+FhHo6lkfYeg=="],"X-IronPort-AV":["E=McAfee;i=\"6700,10204,11390\"; a=\"32411986\"","E=Sophos;i=\"6.14,293,1736841600\"; d=\"scan'208\";a=\"32411986\"","E=Sophos;i=\"6.14,293,1736841600\"; d=\"scan'208\";a=\"131193321\""],"X-ExtLoop1":"1","From":"Stanislaw Gruszka ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ,\n\tKieran Bingham ,\n\tNaushir Patuck ,\n\tSakari Ailus ,\n\tHans de Goede ","Subject":"[PATCH] ipa: simple: Initialize ccmEnabled to false","Date":"Tue, 1 Apr 2025 11:33:08 +0200","Message-Id":"<20250401093308.475810-1-stanislaw.gruszka@linux.intel.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"ccmEnabled variable is not initialized by default, what result of\nusage of CCM when the algorithm itself is not enabled and configured.\n\nThe bug manifest itself as seldom reproducible corrupted video stream.\nFix by initialize the variable in IPAContext class initialization list.\n\nFixes: ac3068655643 (\"libcamera: software_isp: Track whether CCM is enabled\")\nSigned-off-by: Stanislaw Gruszka \n---\n src/ipa/simple/ipa_context.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 7dc2cd7ae828..afccf557121e 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -82,7 +82,7 @@ struct IPAFrameContext : public FrameContext {\n \n struct IPAContext {\n \tIPAContext(unsigned int frameContextSize)\n-\t\t: frameContexts(frameContextSize)\n+\t\t: frameContexts(frameContextSize), ccmEnabled(false)\n \t{\n \t}\n \n","prefixes":[]}