{"id":23084,"url":"https://patchwork.libcamera.org/api/1.1/patches/23084/?format=json","web_url":"https://patchwork.libcamera.org/patch/23084/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250331150900.523485-1-barnabas.pocze@ideasonboard.com>","date":"2025-03-31T15:09:00","name":"[v1] libcamera: camera_manager: Take camera id in `std::string_view`","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cdaa314b0a1d2544e6e808279c5b87ba45eed43d","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23084/mbox/","series":[{"id":5096,"url":"https://patchwork.libcamera.org/api/1.1/series/5096/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5096","date":"2025-03-31T15:09:00","name":"[v1] libcamera: camera_manager: Take camera id in `std::string_view`","version":1,"mbox":"https://patchwork.libcamera.org/series/5096/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23084/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23084/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19858C3213\n\tfor ;\n\tMon, 31 Mar 2025 15:09:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0AAE368986;\n\tMon, 31 Mar 2025 17:09:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F79368967\n\tfor ;\n\tMon, 31 Mar 2025 17:09:06 +0200 (CEST)","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68F3E703\n\tfor ;\n\tMon, 31 Mar 2025 17:07:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wTzDQgeX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743433634;\n\tbh=OFfsDA8WNntZi6EsXcENBm8TQ9sioC6iJYG3jT0zen0=;\n\th=From:To:Subject:Date:From;\n\tb=wTzDQgeXgnokO0c1q/z9bAJcPNpi+/Frd2xGW8Hxch3Br8THOoBAl6S08Q1vdOkHk\n\twuIUSDP27kVZLAAngO87tzMhMTJnCoXkvoX0dOKfDddr5rDkGM0sIeOP/nQPHrKSeQ\n\t8VIVP2oNOwIkgP4lXqEMC3SZGkGTJj3FMBtwuaJ4=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: camera_manager: Take camera id in\n\t`std::string_view`","Date":"Mon, 31 Mar 2025 17:09:00 +0200","Message-ID":"<20250331150900.523485-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Do not force the caller to have an `std::string` object as a\nsimple string view is sufficient to do the lookup.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/camera_manager.h | 3 ++-\n src/libcamera/camera_manager.cpp | 2 +-\n src/py/libcamera/py_camera_manager.h | 2 +-\n 3 files changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\nindex b50df7825..27835500f 100644\n--- a/include/libcamera/camera_manager.h\n+++ b/include/libcamera/camera_manager.h\n@@ -9,6 +9,7 @@\n \n #include \n #include \n+#include \n #include \n #include \n \n@@ -31,7 +32,7 @@ public:\n \tvoid stop();\n \n \tstd::vector> cameras() const;\n-\tstd::shared_ptr get(const std::string &id);\n+\tstd::shared_ptr get(std::string_view id);\n \n \tstatic const std::string &version() { return version_; }\n \ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex b28bd0bd2..e62e7193c 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -381,7 +381,7 @@ std::vector> CameraManager::cameras() const\n *\n * \\return Shared pointer to Camera object or nullptr if camera not found\n */\n-std::shared_ptr CameraManager::get(const std::string &id)\n+std::shared_ptr CameraManager::get(std::string_view id)\n {\n \tPrivate *const d = _d();\n \ndiff --git a/src/py/libcamera/py_camera_manager.h b/src/py/libcamera/py_camera_manager.h\nindex 3574db236..af69b915e 100644\n--- a/src/py/libcamera/py_camera_manager.h\n+++ b/src/py/libcamera/py_camera_manager.h\n@@ -20,7 +20,7 @@ public:\n \t~PyCameraManager();\n \n \tpybind11::list cameras();\n-\tstd::shared_ptr get(const std::string &name) { return cameraManager_->get(name); }\n+\tstd::shared_ptr get(std::string_view name) { return cameraManager_->get(name); }\n \n \tstatic const std::string &version() { return CameraManager::version(); }\n \n","prefixes":["v1"]}