{"id":23083,"url":"https://patchwork.libcamera.org/api/1.1/patches/23083/?format=json","web_url":"https://patchwork.libcamera.org/patch/23083/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250331150611.523218-1-barnabas.pocze@ideasonboard.com>","date":"2025-03-31T15:06:11","name":"[v1] libcamera: camera_manager: Simplify camera lookup","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8d26b3cac001bbd950d78a4ae87b2be8149d5b0a","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23083/mbox/","series":[{"id":5095,"url":"https://patchwork.libcamera.org/api/1.1/series/5095/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5095","date":"2025-03-31T15:06:11","name":"[v1] libcamera: camera_manager: Simplify camera lookup","version":1,"mbox":"https://patchwork.libcamera.org/series/5095/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23083/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23083/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 077E5C323E\n\tfor ;\n\tMon, 31 Mar 2025 15:06:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E8B76897A;\n\tMon, 31 Mar 2025 17:06:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA05168967\n\tfor ;\n\tMon, 31 Mar 2025 17:06:15 +0200 (CEST)","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21D6A703\n\tfor ;\n\tMon, 31 Mar 2025 17:04:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BxSyzOIJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743433464;\n\tbh=ZxE6z/Du8SoyIDGD3RnoWmpTOgez2vc4+2uDPJ1hngM=;\n\th=From:To:Subject:Date:From;\n\tb=BxSyzOIJv5XvG6eYgMMWBqF7/wWcV3wV6Da56JvSy1JF5WzXZaUqUjo4MGfo7+PU8\n\trORw2hVpphCZDkHhOHbBlYWEN056kCq9jY6/EVFvHNHYUuZKMXpxWQx1/NPFSJHqpk\n\tJ/nf0JoE9tU7rZ2zrJVPclfQX9kmaDgUAoVonU5w=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: camera_manager: Simplify camera lookup","Date":"Mon, 31 Mar 2025 17:06:11 +0200","Message-ID":"<20250331150611.523218-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`std::find()` works just fine because `std::shared_ptr` has\n`operator==()` with the expected semantics.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/camera_manager.cpp | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 400109f12..b28bd0bd2 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -239,10 +239,7 @@ void CameraManager::Private::removeCamera(std::shared_ptr camera)\n \t{\n \t\tMutexLocker locker(mutex_);\n \n-\t\tauto iter = std::find_if(cameras_.begin(), cameras_.end(),\n-\t\t\t\t\t [camera](std::shared_ptr &c) {\n-\t\t\t\t\t\t return c.get() == camera.get();\n-\t\t\t\t\t });\n+\t\tauto iter = std::find(cameras_.begin(), cameras_.end(), camera);\n \t\tif (iter == cameras_.end())\n \t\t\treturn;\n \n","prefixes":["v1"]}