{"id":23080,"url":"https://patchwork.libcamera.org/api/1.1/patches/23080/?format=json","web_url":"https://patchwork.libcamera.org/patch/23080/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250331144352.736700-8-stefan.klug@ideasonboard.com>","date":"2025-03-31T14:43:46","name":"[7/9] pipeline: rkisp1: Add color space information to debug log","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b1fc5bc17f109af811e49a18b568c6665ea134bd","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23080/mbox/","series":[{"id":5094,"url":"https://patchwork.libcamera.org/api/1.1/series/5094/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5094","date":"2025-03-31T14:43:39","name":"Wdr preparations","version":1,"mbox":"https://patchwork.libcamera.org/series/5094/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23080/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23080/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E54A2C3213\n\tfor ;\n\tMon, 31 Mar 2025 14:44:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 965CC6899C;\n\tMon, 31 Mar 2025 16:44:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D520168996\n\tfor ;\n\tMon, 31 Mar 2025 16:44:15 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:823a:c275:e8b5:b937])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F65A725;\n\tMon, 31 Mar 2025 16:42:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"blYx+tNv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743432144;\n\tbh=FrkIQwe2uBxEDe8gYFJvxMqx2t8Jfz0qWEy1DpNiwYE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=blYx+tNvaPioGDRCH12FcB/X4I8Jh6BiC5JSQGzlFTkoCSXiQ3tM3TlF7rVkpczKM\n\t6F+CEveg1+/n1FEravHwvPD+LDjN4ExxxVoOECkhVNIQr1uuQRXKvTiWy/4H1s0/xk\n\tb959A0dDWPMb4eh3vshSNCpJQ0E6TKAjAjbhrcr0=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 7/9] pipeline: rkisp1: Add color space information to debug\n\tlog","Date":"Mon, 31 Mar 2025 16:43:46 +0200","Message-ID":"<20250331144352.736700-8-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250331144352.736700-1-stefan.klug@ideasonboard.com>","References":"<20250331144352.736700-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not\napplied correctly. Add the color space to the debug log output to be\nable to detect that now and later.\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 132ab40fdbf7..bd74b73d1e68 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \n \tLOG(RkISP1, Debug)\n \t\t<< \"ISP output pad configured with \" << format\n-\t\t<< \" crop \" << outputCrop;\n+\t\t<< \" crop \" << outputCrop\n+\t\t<< \" color space \" << ColorSpace::toString(format.colorSpace);\n \n \tIPACameraSensorInfo sensorInfo;\n \tret = data->sensor_->sensorInfo(&sensorInfo);\n","prefixes":["7/9"]}