{"id":2303,"url":"https://patchwork.libcamera.org/api/1.1/patches/2303/?format=json","web_url":"https://patchwork.libcamera.org/patch/2303/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191108205409.18845-8-laurent.pinchart@ideasonboard.com>","date":"2019-11-08T20:53:52","name":"[libcamera-devel,v2,07/24] libcamera: controls: Make ControlId constructor public","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d3cee52d3739b4a9af9f1938db20b42667288c25","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2303/mbox/","series":[{"id":568,"url":"https://patchwork.libcamera.org/api/1.1/series/568/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=568","date":"2019-11-08T20:53:45","name":"Control serialization and IPA C API","version":2,"mbox":"https://patchwork.libcamera.org/series/568/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2303/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2303/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1E0D61516\n\tfor ;\n\tFri, 8 Nov 2019 21:54:24 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5991631D;\n\tFri, 8 Nov 2019 21:54:24 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1573246464;\n\tbh=T+KwLux/OSOYDRaBtiIFJ3C9yYPkiGWFWzXvJP3/kXY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IWqFzdzycqSSqfkR6LBWkovWaEhA4AN8fd3yxR674E5GqMGbLJdTbS4+ws7qmxwZC\n\tzqHItl/alYa3+yTE7fSj/U+1YhGEgNeLG6snXpe0Kj0p/VkL4+coMqgH/8m9A8TGvb\n\toKkEu2pUc5TEedBCLvf+EA55B1diRNPvsNBfVPOQ=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 8 Nov 2019 22:53:52 +0200","Message-Id":"<20191108205409.18845-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 07/24] libcamera: controls: Make\n\tControlId constructor public","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 08 Nov 2019 20:54:26 -0000"},"content":"From: Jacopo Mondi \n\nIn order to be able to create a ControlId from serialized data, make its\nconstructor public.\n\nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/controls.h | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 548c06c65bb6..6bad36cbc369 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -59,16 +59,15 @@ private:\n class ControlId\n {\n public:\n-\tunsigned int id() const { return id_; }\n-\tconst std::string &name() const { return name_; }\n-\tControlType type() const { return type_; }\n-\n-protected:\n \tControlId(unsigned int id, const std::string &name, ControlType type)\n \t\t: id_(id), name_(name), type_(type)\n \t{\n \t}\n \n+\tunsigned int id() const { return id_; }\n+\tconst std::string &name() const { return name_; }\n+\tControlType type() const { return type_; }\n+\n private:\n \tControlId &operator=(const ControlId &) = delete;\n \tControlId(const ControlId &) = delete;\n","prefixes":["libcamera-devel","v2","07/24"]}