{"id":2302,"url":"https://patchwork.libcamera.org/api/1.1/patches/2302/?format=json","web_url":"https://patchwork.libcamera.org/patch/2302/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191108205409.18845-7-laurent.pinchart@ideasonboard.com>","date":"2019-11-08T20:53:51","name":"[libcamera-devel,v2,06/24] libcamera: controls: Add move constructor to ControlInfoMap","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"932a9065b34ab3f5161520c89e336a73fb8a2723","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2302/mbox/","series":[{"id":568,"url":"https://patchwork.libcamera.org/api/1.1/series/568/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=568","date":"2019-11-08T20:53:45","name":"Control serialization and IPA C API","version":2,"mbox":"https://patchwork.libcamera.org/series/568/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2302/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2302/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62F6761373\n\tfor ;\n\tFri, 8 Nov 2019 21:54:24 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0DC4A2D1\n\tfor ;\n\tFri, 8 Nov 2019 21:54:24 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1573246464;\n\tbh=O+T5l8wGjneoI9bPSa6I1IA4dwhgv70DhQpQ0caJs/w=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=TqGaZJ73j0hEhXtU02Jsddb2ro6FwFLgaeJ+F8lRaMel8M8HLeUnsJhrabQ4Q5l0m\n\tERw38PGFrn5AM4JG9zOb9YX0RjXqQDrslak3Z+B8UYX0DglSayqzavC6RkLdtQeNrD\n\tq1pUhVJ7V46Z1l5l8rCco1IYkIq3P0mzyqHOp43s=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 8 Nov 2019 22:53:51 +0200","Message-Id":"<20191108205409.18845-7-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>","References":"<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 06/24] libcamera: controls: Add move\n\tconstructor to ControlInfoMap","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 08 Nov 2019 20:54:25 -0000"},"content":"The ControlInfoMap class has a move assignment operator from a plain\nmap, but on corresponding move constructor. Add one.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/controls.h | 1 +\n src/libcamera/controls.cpp | 13 +++++++++++++\n 2 files changed, 14 insertions(+)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex f9979a466eaa..548c06c65bb6 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -146,6 +146,7 @@ public:\n \tControlInfoMap() = default;\n \tControlInfoMap(const ControlInfoMap &other) = default;\n \tControlInfoMap(std::initializer_list init);\n+\tControlInfoMap(Map &&info);\n \n \tControlInfoMap &operator=(const ControlInfoMap &other) = default;\n \tControlInfoMap &operator=(std::initializer_list init);\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 021d5f0990e0..ae6ca2a7cf7e 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -445,6 +445,19 @@ ControlInfoMap::ControlInfoMap(std::initializer_list init)\n \tgenerateIdmap();\n }\n \n+/**\n+ * \\brief Construct a ControlInfoMap from a plain map\n+ * \\param[in] info The control info plain map\n+ *\n+ * Construct a new ControlInfoMap and populate its contents with those of\n+ * \\a info using move semantics. Upon return the \\a info map will be empty.\n+ */\n+ControlInfoMap::ControlInfoMap(Map &&info)\n+\t: Map(std::move(info))\n+{\n+\tgenerateIdmap();\n+}\n+\n /**\n * \\fn ControlInfoMap &ControlInfoMap::operator=(const ControlInfoMap &other)\n * \\brief Copy assignment operator, replace the contents with a copy of \\a other\n","prefixes":["libcamera-devel","v2","06/24"]}