{"id":23019,"url":"https://patchwork.libcamera.org/api/1.1/patches/23019/?format=json","web_url":"https://patchwork.libcamera.org/patch/23019/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250325180821.1456154-9-barnabas.pocze@ideasonboard.com>","date":"2025-03-25T18:08:20","name":"[RFC,v3,8/9] libcamera: process: Use `close_range()` when available","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3b4359577240c6611daedad695461c4f8e60f253","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/23019/mbox/","series":[{"id":5079,"url":"https://patchwork.libcamera.org/api/1.1/series/5079/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5079","date":"2025-03-25T18:08:12","name":"libcamera: process: Remove `ProcessManager` singleton","version":3,"mbox":"https://patchwork.libcamera.org/series/5079/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/23019/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/23019/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7696CC3323\n\tfor ;\n\tTue, 25 Mar 2025 18:09:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 457E96895F;\n\tTue, 25 Mar 2025 19:09:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 757686895F\n\tfor ;\n\tTue, 25 Mar 2025 19:08:48 +0100 (CET)","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CBBCA353\n\tfor ;\n\tTue, 25 Mar 2025 19:07:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tgJt/Ixy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742926021;\n\tbh=qRGu2Bth2fPbi9yFuKL/gq8+YmejefhAxhWGC8edVHY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=tgJt/IxyH+HoYo8B9gSiBwdT33Wg1OCoGywhJIkdtifW6Sdszs9+gpJbCEZtbEy85\n\tYmogVyQEd8d+noYk8+tfRdQ+hD38KGYOhvGb39sv51XPZ2wAdUECFlM9XkSqxO2i4C\n\ttRYllR+LBJFYAtl5Dv9zrpuBe4XJp3zQDUF3keWA=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v3 8/9] libcamera: process: Use `close_range()` when\n\tavailable","Date":"Tue, 25 Mar 2025 19:08:20 +0100","Message-ID":"<20250325180821.1456154-9-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>","References":"<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the `close_range()` system call when available as it is\nsimpler and faster than iterating `/proc/self/fd/`.\n\nSigned-off-by: Barnabás Pőcze \n---\n meson.build | 4 ++++\n src/libcamera/process.cpp | 20 ++++++++++++++++++++\n 2 files changed, 24 insertions(+)","diff":"diff --git a/meson.build b/meson.build\nindex 668ec3969..00291d628 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -103,6 +103,10 @@ if cc.has_header_symbol('stdlib.h', 'secure_getenv', prefix : '#define _GNU_SOUR\n config_h.set('HAVE_SECURE_GETENV', 1)\n endif\n \n+if cc.has_header_symbol('unistd.h', 'close_range', prefix : '#define _GNU_SOURCE')\n+ config_h.set('HAVE_CLOSE_RANGE', 1)\n+endif\n+\n common_arguments = [\n '-Wmissing-declarations',\n '-Wshadow',\ndiff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 01503e485..5fa813300 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -70,6 +70,26 @@ void closeAllFdsExcept(Span fds)\n \n \tASSERT(v.empty() || v.front() >= 0);\n \n+#if HAVE_CLOSE_RANGE\n+\tstatic const bool hasCloseRange = [] {\n+\t\treturn close_range(~0u, 0, 0) < 0 && errno == EINVAL;\n+\t}();\n+\n+\tif (hasCloseRange) {\n+\t\tunsigned int prev = 0;\n+\n+\t\tfor (unsigned int curr : v) {\n+\t\t\tASSERT(prev <= curr);\n+\t\t\tif (prev < curr)\n+\t\t\t\tclose_range(prev, curr - 1, 0);\n+\t\t\tprev = curr + 1;\n+\t\t}\n+\n+\t\tclose_range(prev, ~0u, 0);\n+\t\treturn;\n+\t}\n+#endif\n+\n \tDIR *dir = opendir(\"/proc/self/fd\");\n \tif (!dir)\n \t\treturn;\n","prefixes":["RFC","v3","8/9"]}