{"id":22970,"url":"https://patchwork.libcamera.org/api/1.1/patches/22970/?format=json","web_url":"https://patchwork.libcamera.org/patch/22970/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250317181134.214074-1-barnabas.pocze@ideasonboard.com>","date":"2025-03-17T18:11:34","name":"[v1] libcamera: media_device: Ignore `lockf()` return value","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"42567952c036b641772189c9f6af195d0cf7a5db","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22970/mbox/","series":[{"id":5065,"url":"https://patchwork.libcamera.org/api/1.1/series/5065/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5065","date":"2025-03-17T18:11:34","name":"[v1] libcamera: media_device: Ignore `lockf()` return value","version":1,"mbox":"https://patchwork.libcamera.org/series/5065/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22970/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22970/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2239C32F5\n\tfor ;\n\tMon, 17 Mar 2025 18:11:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA68568942;\n\tMon, 17 Mar 2025 19:11:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57E23617F8\n\tfor ;\n\tMon, 17 Mar 2025 19:11:38 +0100 (CET)","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E426352\n\tfor ;\n\tMon, 17 Mar 2025 19:09:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wUSMdojX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742234996;\n\tbh=GMJ7QH/V6/+tdk1QGcfWSfr9G789le/qWs37JvSrKkY=;\n\th=From:To:Subject:Date:From;\n\tb=wUSMdojXcCzepijM/+SRkHV+MnqGVmgmwCkdaHrSsuBxrUgMsHLsVOF2xHinwGMx0\n\t71iDEEwczxta9rOQKu+HwbgP1HUElEXgtNLyz68FUouE3Pj144AMvgIOSAkagkPDh7\n\tltqwDGoObqKPfIMqZCOku6zUV0Ffh7EanY8UI+/M=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: media_device: Ignore `lockf()` return value","Date":"Mon, 17 Mar 2025 19:11:34 +0100","Message-ID":"<20250317181134.214074-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When `_FORTIFY_SOURCE` is enabled, the `lockf()` function might be marked\nwith the `warn_unused_result` attribute, leading to compilation failure.\nFix that by explicitly ignoring the return value.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/media_device.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\nindex d71dad74d..75abd91d7 100644\n--- a/src/libcamera/media_device.cpp\n+++ b/src/libcamera/media_device.cpp\n@@ -13,6 +13,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n \n@@ -164,7 +165,7 @@ void MediaDevice::unlock()\n \tif (!fd_.isValid())\n \t\treturn;\n \n-\tlockf(fd_.get(), F_ULOCK, 0);\n+\tstd::ignore = lockf(fd_.get(), F_ULOCK, 0);\n }\n \n /**\n","prefixes":["v1"]}