{"id":22963,"url":"https://patchwork.libcamera.org/api/1.1/patches/22963/?format=json","web_url":"https://patchwork.libcamera.org/patch/22963/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250314202943.112109-4-mzamazal@redhat.com>","date":"2025-03-14T20:29:31","name":"[RFC,3/7] apps: cam: Remove unused imports","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e08a65b9c7015cc0b451214706ce5cde09226956","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22963/mbox/","series":[{"id":5062,"url":"https://patchwork.libcamera.org/api/1.1/series/5062/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5062","date":"2025-03-14T20:29:28","name":"Support different outputs for cam streams","version":1,"mbox":"https://patchwork.libcamera.org/series/5062/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22963/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22963/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94916C32F7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 14 Mar 2025 20:30:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D2B26894C;\n\tFri, 14 Mar 2025 21:30:15 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECEA468949\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 14 Mar 2025 21:30:08 +0100 (CET)","from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-692-HWyx7sKGNUSMAiteJ1nRFg-1;\n\tFri, 14 Mar 2025 16:30:04 -0400","from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 8DFF51956087; Fri, 14 Mar 2025 20:30:03 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.19])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 066E01954B32; Fri, 14 Mar 2025 20:30:01 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"BbrNBAlI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1741984207;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=+1eeTxAc3etLJP48plHj1awILyyANHtp9dmw2aUu+as=;\n\tb=BbrNBAlI1MU2WSsNVPOdQdC8e2vyeJv45hrRICayC9eraWFOuzoZvuMj60bbfG18g6F0EK\n\tWNIzxD1oyFHRbbIMaoQeMZTctozVyYkYeH6ccbgUtfZWPN1voljBR5xDAEceM5/E9QnBaw\n\t611LhJp1uG9ZdYJprSuIyWwu1d5oY3k=","X-MC-Unique":"HWyx7sKGNUSMAiteJ1nRFg-1","X-Mimecast-MFC-AGG-ID":"HWyx7sKGNUSMAiteJ1nRFg_1741984203","From":"Milan Zamazal <mzamazal@redhat.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","Subject":"[RFC PATCH 3/7] apps: cam: Remove unused imports","Date":"Fri, 14 Mar 2025 21:29:31 +0100","Message-ID":"<20250314202943.112109-4-mzamazal@redhat.com>","In-Reply-To":"<20250314202943.112109-1-mzamazal@redhat.com>","References":"<20250314202943.112109-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.40","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"bvYCUe_3hwmK8JWACrL4NNNd22nopeOdKmbPOqF_EgU_1741984203","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Some imports in `cam' source files are reported by LSP as not directly\nused, let's remove them.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/apps/cam/kms_sink.cpp | 1 -\n src/apps/cam/main.cpp     | 1 -\n src/apps/cam/sdl_sink.cpp | 4 ----\n 3 files changed, 6 deletions(-)","diff":"diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\nindex def7878b..6490a5c0 100644\n--- a/src/apps/cam/kms_sink.cpp\n+++ b/src/apps/cam/kms_sink.cpp\n@@ -7,7 +7,6 @@\n \n #include \"kms_sink.h\"\n \n-#include <algorithm>\n #include <array>\n #include <assert.h>\n #include <iostream>\ndiff --git a/src/apps/cam/main.cpp b/src/apps/cam/main.cpp\nindex fa266eca..9d84ef8e 100644\n--- a/src/apps/cam/main.cpp\n+++ b/src/apps/cam/main.cpp\n@@ -8,7 +8,6 @@\n #include \"main.h\"\n \n #include <atomic>\n-#include <iomanip>\n #include <iostream>\n #include <signal.h>\n #include <string.h>\ndiff --git a/src/apps/cam/sdl_sink.cpp b/src/apps/cam/sdl_sink.cpp\nindex 8355dd5e..e8a54f7a 100644\n--- a/src/apps/cam/sdl_sink.cpp\n+++ b/src/apps/cam/sdl_sink.cpp\n@@ -9,11 +9,7 @@\n \n #include <assert.h>\n #include <fcntl.h>\n-#include <iomanip>\n #include <iostream>\n-#include <signal.h>\n-#include <sstream>\n-#include <string.h>\n #include <unistd.h>\n \n #include <libcamera/camera.h>\n","prefixes":["RFC","3/7"]}