{"id":22950,"url":"https://patchwork.libcamera.org/api/1.1/patches/22950/?format=json","web_url":"https://patchwork.libcamera.org/patch/22950/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250311-qttools-unneeded-v1-1-834c30be7e7a@cherry.de>","date":"2025-03-11T13:01:47","name":"README.rst: remove unnecessary dependency for qcam","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a86fa6af37bc63dc1ced7edf2a322a5166b1f1b9","submitter":{"id":120,"url":"https://patchwork.libcamera.org/api/1.1/people/120/?format=json","name":"Quentin Schulz","email":"foss+libcamera@0leil.net"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22950/mbox/","series":[{"id":5058,"url":"https://patchwork.libcamera.org/api/1.1/series/5058/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5058","date":"2025-03-11T13:01:47","name":"README.rst: remove unnecessary dependency for qcam","version":1,"mbox":"https://patchwork.libcamera.org/series/5058/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22950/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22950/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD9B1C0F2A\n\tfor ;\n\tTue, 11 Mar 2025 13:02:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AECE687FA;\n\tTue, 11 Mar 2025 14:02:02 +0100 (CET)","from smtp-bc0b.mail.infomaniak.ch (smtp-bc0b.mail.infomaniak.ch\n\t[45.157.188.11])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 183EE61800\n\tfor ;\n\tTue, 11 Mar 2025 14:02:01 +0100 (CET)","from smtp-4-0000.mail.infomaniak.ch (unknown\n\t[IPv6:2001:1600:7:10:40ca:feff:fe05:0])\n\tby smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id\n\t4ZBv6c5hNYzSjr; Tue, 11 Mar 2025 14:02:00 +0100 (CET)","from unknown by smtp-4-0000.mail.infomaniak.ch (Postfix) with\n\tESMTPA id 4ZBv6c1vHGz2tf; Tue, 11 Mar 2025 14:02:00 +0100 (CET)"],"From":"Quentin Schulz ","Date":"Tue, 11 Mar 2025 14:01:47 +0100","Subject":"[PATCH] README.rst: remove unnecessary dependency for qcam","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250311-qttools-unneeded-v1-1-834c30be7e7a@cherry.de>","X-B4-Tracking":"v=1; b=H4sIADo00GcC/x3MTQqAIBBA4avIrBvQsh+6SrSQnGogtNQiiO6et\n\tPwW7z0QKTBF6MUDgS6O7F2GKgRMq3ELIdtsKGVZy0opPFLyfot4OkdkyaJuuqqVWivTaMjZHmj\n\tm+18O4/t+d7B9B2IAAAA=","X-Change-ID":"20250311-qttools-unneeded-468370441a64","To":"libcamera-devel@lists.libcamera.org","Cc":"Quentin Schulz ","X-Mailer":"b4 0.14.2","X-Infomaniak-Routing":"alpha","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Quentin Schulz \n\nThe introducing commit (dff416a84b78 (\"README: Add missing package for\nQt5 tools\"); for Qt 5 originally) stated that without the dependency we\nwould get the following messages:\n\n Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO\n Program lrelease-qt5 found: NO\n Program lrelease found: NO found but need: '== 5.14.2'\n\nThat is still the case but this actually is neither breaking the build\nnor is it doing anything to the outcome of the build as qcam is bit to\nbit identical with and without that package.\n\nTherefore, let's not mislead users to install an unnecessary package.\n\nSigned-off-by: Quentin Schulz \n---\nThis was tested within a debian:bookworm container with and without the\npackage, checked out both at master and introducing commit. qcam is bit\nto bit identical in both cases.\n---\n README.rst | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\n---\nbase-commit: 39419ce431dbd4f34d8772bd31bb7f44a3534f86\nchange-id: 20250311-qttools-unneeded-468370441a64\n\nBest regards,","diff":"diff --git a/README.rst b/README.rst\nindex ae5126e25542a37d0c50287399486c56d2888af8..9dfef7eadb4640f77c28f82d42fadd54aa025641 100644\n--- a/README.rst\n+++ b/README.rst\n@@ -85,7 +85,7 @@ for cam: [optional]\n - libsdl2-dev: Enables the SDL sink\n \n for qcam: [optional]\n- libtiff-dev qt6-base-dev qt6-tools-dev-tools\n+ libtiff-dev qt6-base-dev\n \n for tracing with lttng: [optional]\n liblttng-ust-dev python3-jinja2 lttng-tools\n","prefixes":[]}