{"id":2295,"url":"https://patchwork.libcamera.org/api/1.1/patches/2295/?format=json","web_url":"https://patchwork.libcamera.org/patch/2295/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191108194739.1632-1-laurent.pinchart@ideasonboard.com>","date":"2019-11-08T19:47:39","name":"[libcamera-devel] libcamera: Fix compilation with uClibc and uClibc-ng","commit_ref":"b465ecb3e32b8b71ed4137656c2b8e67030fa2e1","pull_url":null,"state":"accepted","archived":false,"hash":"16de11c8857244b396e76cdd7c90a1712e8e267b","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2295/mbox/","series":[{"id":567,"url":"https://patchwork.libcamera.org/api/1.1/series/567/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=567","date":"2019-11-08T19:47:39","name":"[libcamera-devel] libcamera: Fix compilation with uClibc and uClibc-ng","version":1,"mbox":"https://patchwork.libcamera.org/series/567/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2295/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2295/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE81A60180\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  8 Nov 2019 20:47:52 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 378882D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  8 Nov 2019 20:47:52 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1573242472;\n\tbh=u5rV18DL3t3itZtWNNS3yUIjv2T0lw4iuNm8UggopI0=;\n\th=From:To:Subject:Date:From;\n\tb=s4H3QGovukznWiqWmPQV2CF8+0Ml9kqRQ7dVxVKpW0Pvt9QpSX3cb2Kkpoz6EFAAp\n\t2R8uw50tS/kJF6iR+jmZF7pTFLfQ/+XThZWRnvonRmfGa1d30RXhfQTTzhpkA31lPB\n\tlgBwGUqwCmP6jDklvOVNab3a8oiURokgbSKX6tOg=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri,  8 Nov 2019 21:47:39 +0200","Message-Id":"<20191108194739.1632-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.23.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: Fix compilation with uClibc\n\tand uClibc-ng","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 08 Nov 2019 19:47:52 -0000"},"content":"Neither uClibc nor uClibc-ng support O_TMPFILE. Define it in utils.h if\nnot defined.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/include/utils.h | 9 +++++++++\n 1 file changed, 9 insertions(+)\n\nIs utils.h a good location, or should we create a compat.h (maybe even\none that is automatically included) for this purpose ?","diff":"diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\nindex 3efb11c119c2..a80f7d096bf7 100644\n--- a/src/libcamera/include/utils.h\n+++ b/src/libcamera/include/utils.h\n@@ -16,6 +16,15 @@\n \n #define ARRAY_SIZE(a)\t(sizeof(a) / sizeof(a[0]))\n \n+#ifndef __DOXYGEN__\n+\n+/* uClibc and uClibc-ng don't provide O_TMPFILE */\n+#ifndef O_TMPFILE\n+#define O_TMPFILE\t(020000000 | O_DIRECTORY)\n+#endif\n+\n+#endif\n+\n namespace libcamera {\n \n namespace utils {\n","prefixes":["libcamera-devel"]}