{"id":22949,"url":"https://patchwork.libcamera.org/api/1.1/patches/22949/?format=json","web_url":"https://patchwork.libcamera.org/patch/22949/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250310170356.185368-1-barnabas.pocze@ideasonboard.com>","date":"2025-03-10T17:03:56","name":"[v1] libcamera: base: span: Explicitly default copy assignment","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"47b032bfabe9d028026c1291405fe0cde24c9265","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22949/mbox/","series":[{"id":5057,"url":"https://patchwork.libcamera.org/api/1.1/series/5057/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5057","date":"2025-03-10T17:03:56","name":"[v1] libcamera: base: span: Explicitly default copy assignment","version":1,"mbox":"https://patchwork.libcamera.org/series/5057/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22949/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22949/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21A5FC32F1\n\tfor ;\n\tMon, 10 Mar 2025 17:04:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CDF6268826;\n\tMon, 10 Mar 2025 18:04:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3ED7687FA\n\tfor ;\n\tMon, 10 Mar 2025 18:04:00 +0100 (CET)","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE747227\n\tfor ;\n\tMon, 10 Mar 2025 18:02:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"moy1RGzw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741626144;\n\tbh=as5+oycz/vhk++PoMmE3FFmHotRQ8V7sMzLzy+7nIB0=;\n\th=From:To:Subject:Date:From;\n\tb=moy1RGzwDxuqNesIR8G1cAhXPnvW6cYxOvSBtidLwkJKjlWIPzfq1jSie/mG7+lBq\n\tWl3mJcQhe2uTeZkX3X1FUCzsIhWyUW9LiSJZsQoiqDFRQ+eBBaQWsPbQRWiIKm18+A\n\tuAToY+x1LVTovaFT4UXBhweWiE16MvrPD9NnBqcc=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: base: span: Explicitly default copy assignment","Date":"Mon, 10 Mar 2025 18:03:56 +0100","Message-ID":"<20250310170356.185368-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The `dynamic_extent` specialization is currently not trivially copyable\nunlike its standard counterpart, `std::span`. This is because the copy\nassignment operator is user-defined. Explicitly default it just like\nit is done in the main template definition.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/base/span.h | 8 +-------\n 1 file changed, 1 insertion(+), 7 deletions(-)","diff":"diff --git a/include/libcamera/base/span.h b/include/libcamera/base/span.h\nindex 92cce4f05..806db106e 100644\n--- a/include/libcamera/base/span.h\n+++ b/include/libcamera/base/span.h\n@@ -346,13 +346,7 @@ public:\n \t}\n \n \tconstexpr Span(const Span &other) noexcept = default;\n-\n-\tconstexpr Span &operator=(const Span &other) noexcept\n-\t{\n-\t\tdata_ = other.data_;\n-\t\tsize_ = other.size_;\n-\t\treturn *this;\n-\t}\n+\tconstexpr Span &operator=(const Span &other) noexcept = default;\n \n \tconstexpr iterator begin() const { return data(); }\n \tconstexpr const_iterator cbegin() const { return begin(); }\n","prefixes":["v1"]}