{"id":22942,"url":"https://patchwork.libcamera.org/api/1.1/patches/22942/?format=json","web_url":"https://patchwork.libcamera.org/patch/22942/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250310170254.185172-1-barnabas.pocze@ideasonboard.com>","date":"2025-03-10T17:02:54","name":"[v1] libcamera: controls: Check size of enum","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ebe716edbdfe67fa000916fdc4ead621bbcf8bb4","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22942/mbox/","series":[{"id":5050,"url":"https://patchwork.libcamera.org/api/1.1/series/5050/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5050","date":"2025-03-10T17:02:54","name":"[v1] libcamera: controls: Check size of enum","version":1,"mbox":"https://patchwork.libcamera.org/series/5050/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22942/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22942/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6413EC32F1\n\tfor ;\n\tMon, 10 Mar 2025 17:03:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12CD8687F0;\n\tMon, 10 Mar 2025 18:03:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9982B61809\n\tfor ;\n\tMon, 10 Mar 2025 18:03:00 +0100 (CET)","from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BBEC6227\n\tfor ;\n\tMon, 10 Mar 2025 18:01:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UU+6yzIB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741626084;\n\tbh=6GpX06e/HJL2ITugR7E5XcJa5A3HJ5vbdja2fSWYEgU=;\n\th=From:To:Subject:Date:From;\n\tb=UU+6yzIBhBOWDh1HoP4jHZ7kiiMY2tNeQU9XWWY/bh3GMCN8fbF4H2DIIcN51aeMh\n\tVYb7G/xbSycuLmmjHwBhdQ1GXat83SwwV+u/3A+nxgnSts585jXtwhx9JembLC5McO\n\t1jrPUD+mECNMovtiYCRRSWvUmHoBTjjUHIQIOwsg=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: controls: Check size of enum","Date":"Mon, 10 Mar 2025 18:02:54 +0100","Message-ID":"<20250310170254.185172-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Only enums whose sizes match that of `int32_t` can be directly\nsupported. Otherwise the expected size and the real size would\ndisagree, leading to an assertion failure in `ControlValue::set()`.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/controls.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 7c7828ae5..4bfe9615c 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -125,7 +125,7 @@ struct control_type> : public control_type> {\n };\n \n template\n-struct control_type>> : public control_type {\n+struct control_type && sizeof(T) == sizeof(int32_t)>> : public control_type {\n };\n \n } /* namespace details */\n","prefixes":["v1"]}