{"id":22940,"url":"https://patchwork.libcamera.org/api/1.1/patches/22940/?format=json","web_url":"https://patchwork.libcamera.org/patch/22940/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250310110630.34857-1-mzamazal@redhat.com>","date":"2025-03-10T11:06:30","name":"apps: cam: Fix colorSpace access crash in KMSSink::configure","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d4959c5902d74937a5eda31792b051f868b1ca06","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22940/mbox/","series":[{"id":5048,"url":"https://patchwork.libcamera.org/api/1.1/series/5048/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5048","date":"2025-03-10T11:06:30","name":"apps: cam: Fix colorSpace access crash in KMSSink::configure","version":1,"mbox":"https://patchwork.libcamera.org/series/5048/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22940/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22940/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A63BAC32E7\n\tfor ;\n\tMon, 10 Mar 2025 11:06:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A075B68823;\n\tMon, 10 Mar 2025 12:06:47 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66AF2687EB\n\tfor ;\n\tMon, 10 Mar 2025 12:06:45 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-266-I22qRKhSOjKh2rjQanEnFQ-1;\n\tMon, 10 Mar 2025 07:06:42 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 39BCE19560B8 for ;\n\tMon, 10 Mar 2025 11:06:41 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.56])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id E64AF1800366; Mon, 10 Mar 2025 11:06:38 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"R+eUD92e\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1741604804;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=s1v2dYON195G4b8lizVjo+VKRGdFzFbxalCkHMwJMA0=;\n\tb=R+eUD92e0/CRwHPmpABzeiyoc0KbpnZb9gvIH9XOQO5oa13PhrbGNrKeQd3pSkTyWBWqyP\n\tg0Z3v38877hxeB+fwXtu/K4F056V/eP2WWC8pNRPa8CMFJqvY5wLDWS8vV92Z9T4clsPOO\n\tsp3NbnMNeLQspoN0RMv69a+Z8NuMmj4=","X-MC-Unique":"I22qRKhSOjKh2rjQanEnFQ-1","X-Mimecast-MFC-AGG-ID":"I22qRKhSOjKh2rjQanEnFQ_1741604801","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","Subject":"[PATCH] apps: cam: Fix colorSpace access crash in KMSSink::configure","Date":"Mon, 10 Mar 2025 12:06:30 +0100","Message-ID":"<20250310110630.34857-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"b8cJNfoQ9N37dJtVpGYY4zBAZxEFcDsWEkDjMBoWZIY_1741604801","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"cfg.colorSpace may be unset in KMSSink::configure, resulting in a crash\nwhen it is accessed. If cfg.colorSpace is unset, simply return, the\nsame way as when YcbcrEncoding is set to None.\n\nSigned-off-by: Milan Zamazal \n---\n src/apps/cam/kms_sink.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\nindex 672c985a..aa9459cf 100644\n--- a/src/apps/cam/kms_sink.cpp\n+++ b/src/apps/cam/kms_sink.cpp\n@@ -153,7 +153,8 @@ int KMSSink::configure(const libcamera::CameraConfiguration &config)\n \tcolorEncoding_ = std::nullopt;\n \tcolorRange_ = std::nullopt;\n \n-\tif (cfg.colorSpace->ycbcrEncoding == libcamera::ColorSpace::YcbcrEncoding::None)\n+\tif (!cfg.colorSpace ||\n+\t cfg.colorSpace->ycbcrEncoding == libcamera::ColorSpace::YcbcrEncoding::None)\n \t\treturn 0;\n \n \t/*\n","prefixes":[]}