{"id":22929,"url":"https://patchwork.libcamera.org/api/1.1/patches/22929/?format=json","web_url":"https://patchwork.libcamera.org/patch/22929/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250305135256.801351-5-stanislaw.gruszka@linux.intel.com>","date":"2025-03-05T13:52:55","name":"[v6,4/5] pipeline: simple: Create DelayedControls instance once only","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"81213dc8c1e900ec36adaddfda23efdba6a181d6","submitter":{"id":211,"url":"https://patchwork.libcamera.org/api/1.1/people/211/?format=json","name":"Stanislaw Gruszka","email":"stanislaw.gruszka@linux.intel.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22929/mbox/","series":[{"id":5046,"url":"https://patchwork.libcamera.org/api/1.1/series/5046/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5046","date":"2025-03-05T13:52:51","name":"libcamera: start frame events changes","version":6,"mbox":"https://patchwork.libcamera.org/series/5046/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22929/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22929/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 792BBC3257\n\tfor ;\n\tWed, 5 Mar 2025 13:53:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FF68688AE;\n\tWed, 5 Mar 2025 14:53:24 +0100 (CET)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9D7A68823\n\tfor ;\n\tWed, 5 Mar 2025 14:53:21 +0100 (CET)","from orviesa004.jf.intel.com ([10.64.159.144])\n\tby orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t05 Mar 2025 05:53:22 -0800","from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.245.112.97]) by orviesa004-auth.jf.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 05:53:19 -0800"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"Fteimdnc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1741182802; x=1772718802;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=X3265kruYMN74Wz+fEsqq5xfOV0S2TnNFYuszevpovw=;\n\tb=FteimdncfDFNBHTNyHs1HH7N41uMB6zq2GDm4yH2uDxWyvIprHuqrLA5\n\tRwwXjnGJtAUzDd+m4LZpQdVrL04lcF85W44LyIA2EIOdTI1nh/pgxrV6g\n\tUTXApLVBMKT0T3CzDSKPG2ZmLBJsLMPCamnUEQdCFUyy2nXSXvA3VwXsN\n\tkt8qzKLF0156ppF2PL1HqLrzKx0ZN04kOZ0j1FLVRW4O0ufxhqEhGgLSl\n\tuyKvu87eiZzYLflox5/iylVJXcyiZ2ViYvEPPtpomtGlN0YXV1eYBH/hB\n\tx8dF+OI89f9I0jKKUg8dDqJ6NppSRVrR+pbbtnRzNcWQu+MQvi0l0orWL w==;","X-CSE-ConnectionGUID":["GY04Xb91T8+UnhlItrp7GQ==","k97e7uQnTkK2TekvrlDA+A=="],"X-CSE-MsgGUID":["2ouQMS58RPKJ3wMJnFZNZA==","IA4UaEsOQtquPuDT4bjR/Q=="],"X-IronPort-AV":["E=McAfee;i=\"6700,10204,11363\"; a=\"53134794\"","E=Sophos;i=\"6.14,223,1736841600\"; d=\"scan'208\";a=\"53134794\"","E=Sophos;i=\"6.14,223,1736841600\"; d=\"scan'208\";a=\"123735805\""],"X-ExtLoop1":"1","From":"Stanislaw Gruszka ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ,\n\tKieran Bingham ,\n\tNaushir Patuck ,\n\tSakari Ailus ,\n\tHans de Goede ","Subject":"[PATCH v6 4/5] pipeline: simple: Create DelayedControls instance\n\tonce only","Date":"Wed, 5 Mar 2025 14:52:55 +0100","Message-Id":"<20250305135256.801351-5-stanislaw.gruszka@linux.intel.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20250305135256.801351-1-stanislaw.gruszka@linux.intel.com>","References":"<20250305135256.801351-1-stanislaw.gruszka@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Laurent Pinchart \n\nThe DelayedControls instance for the camera sensor is created in\nSimplePipelineHandler::configure(). Constant deletion and reconstruction\nof a new object is unnecessary, as the control delays are an intrinsic\nproperty of the sensor and are known at initialization time. Move the\nDelayedControls creation to the SimpleCameraData class constructor.\n\nSigned-off-by: Laurent Pinchart \nSigned-off-by: Stanislaw Gruszka \n---\n src/libcamera/pipeline/simple/simple.cpp | 16 +++++++---------\n 1 file changed, 7 insertions(+), 9 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 7be49017..58aa3dba 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -489,6 +489,13 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n \tif (!sensor_)\n \t\treturn;\n \n+\tconst CameraSensorProperties::SensorDelays &delays = sensor_->sensorDelays();\n+\tstd::unordered_map params = {\n+\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n+\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n+\t};\n+\tdelayedCtrls_ = std::make_unique(sensor_->device(), params);\n+\n \tLOG(SimplePipeline, Debug)\n \t\t<< \"Found pipeline: \"\n \t\t<< utils::join(entities_, \" -> \",\n@@ -1302,15 +1309,6 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tif (outputCfgs.empty())\n \t\treturn 0;\n \n-\tconst CameraSensorProperties::SensorDelays &delays = data->sensor_->sensorDelays();\n-\tstd::unordered_map params = {\n-\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n-\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n-\t};\n-\tdata->delayedCtrls_ =\n-\t\tstd::make_unique(data->sensor_->device(),\n-\t\t\t\t\t\t params);\n-\n \tStreamConfiguration inputCfg;\n \tinputCfg.pixelFormat = pipeConfig->captureFormat;\n \tinputCfg.size = pipeConfig->captureSize;\n","prefixes":["v6","4/5"]}