{"id":22913,"url":"https://patchwork.libcamera.org/api/1.1/patches/22913/?format=json","web_url":"https://patchwork.libcamera.org/patch/22913/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250303193330.785575-1-barnabas.pocze@ideasonboard.com>","date":"2025-03-03T19:33:30","name":"[v1] libcamera: base: mutex: Remove unnecessary constructors","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c8c9cb31e8ab1958db8e8a9d2ded498a59ab7427","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22913/mbox/","series":[{"id":5038,"url":"https://patchwork.libcamera.org/api/1.1/series/5038/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5038","date":"2025-03-03T19:33:30","name":"[v1] libcamera: base: mutex: Remove unnecessary constructors","version":1,"mbox":"https://patchwork.libcamera.org/series/5038/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22913/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22913/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BEDCBD808\n\tfor ;\n\tMon, 3 Mar 2025 19:33:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF8DA687EB;\n\tMon, 3 Mar 2025 20:33:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF42568772\n\tfor ;\n\tMon, 3 Mar 2025 20:33:33 +0100 (CET)","from pb-laptop.local (185.221.143.4.nat.pool.zt.hu [185.221.143.4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 12ED9122C\n\tfor ;\n\tMon, 3 Mar 2025 20:32:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kehOY30N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741030322;\n\tbh=jVaFuo1jBGDwkojKUOvu6MQaCATcOkDOfA+FyLTPSlQ=;\n\th=From:To:Subject:Date:From;\n\tb=kehOY30NenAJ9/KkH2HKMeU8cPDJ2g/f5OH179FWrv2Q3aDHx+NL239jYh/klid1/\n\t2uoJzXfNfjriH1t1jmGOnA8AURIRGRRQTr6n1oFy1B+RiQG4i2iyZpVCwM+HilzEfF\n\tp98FdIR1nB7WDCf29x/MKWDtRyDmRN7NpVvONYFc=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: base: mutex: Remove unnecessary constructors","Date":"Mon, 3 Mar 2025 20:33:30 +0100","Message-ID":"<20250303193330.785575-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The compiler defined default constructor works perfectly fine.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/base/mutex.h | 8 --------\n 1 file changed, 8 deletions(-)","diff":"diff --git a/include/libcamera/base/mutex.h b/include/libcamera/base/mutex.h\nindex fa9a8d0dc..20ebe6fee 100644\n--- a/include/libcamera/base/mutex.h\n+++ b/include/libcamera/base/mutex.h\n@@ -23,10 +23,6 @@ namespace libcamera {\n class LIBCAMERA_TSA_CAPABILITY(\"mutex\") Mutex final\n {\n public:\n-\tconstexpr Mutex()\n-\t{\n-\t}\n-\n \tvoid lock() LIBCAMERA_TSA_ACQUIRE()\n \t{\n \t\tmutex_.lock();\n@@ -84,10 +80,6 @@ private:\n class ConditionVariable final\n {\n public:\n-\tConditionVariable()\n-\t{\n-\t}\n-\n \tvoid notify_one() noexcept\n \t{\n \t\tcv_.notify_one();\n","prefixes":["v1"]}