{"id":22839,"url":"https://patchwork.libcamera.org/api/1.1/patches/22839/?format=json","web_url":"https://patchwork.libcamera.org/patch/22839/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250224012325.24246-1-laurent.pinchart@ideasonboard.com>","date":"2025-02-24T01:23:25","name":"pipeline: simple: Create DelayedControls instance once only","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9dface2a204123e0fe7e9c2337039d4d266b3e43","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22839/mbox/","series":[{"id":5014,"url":"https://patchwork.libcamera.org/api/1.1/series/5014/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5014","date":"2025-02-24T01:23:25","name":"pipeline: simple: Create DelayedControls instance once only","version":1,"mbox":"https://patchwork.libcamera.org/series/5014/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22839/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22839/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D658C324E\n\tfor ;\n\tMon, 24 Feb 2025 01:23:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B64E686BF;\n\tMon, 24 Feb 2025 02:23:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 991F561855\n\tfor ;\n\tMon, 24 Feb 2025 02:23:42 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44A6F7EA;\n\tMon, 24 Feb 2025 02:22:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bivYiSQ2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740360136;\n\tbh=nJAsTsbwcU+d9D1XZKpJHr1LYjzyypigjFUrtuHuazU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=bivYiSQ2/36YfQ/UFwp8+c1b2yVxOvI+sei+yz+R3Nsnqqct31TMOPfVvFGgNeLEY\n\tzuvB1N0D7HkFatki+q9/zriZP1UC8LDAsQlDqTlIwgixFtlBVvEWGSQ+Ah8Bi+1vip\n\tFg8cdfUxCrobrEk1Wc6tPDQJ7719wQS6EUQZ2sV4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stanislaw Gruszka ","Subject":"[PATCH] pipeline: simple: Create DelayedControls instance once only","Date":"Mon, 24 Feb 2025 03:23:25 +0200","Message-ID":"<20250224012325.24246-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.3","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The DelayedControls instance for the camera sensor is created in\nSimplePipelineHandler::configure(). Constant deletion and reconstruction\nof a new object is unnecessary, as the control delays are an intrinsic\nproperty of the sensor and are known at initialization time. Move the\nDelayedControls creation to the SimpleCameraData class constructor.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/simple/simple.cpp | 15 +++++++--------\n 1 file changed, 7 insertions(+), 8 deletions(-)\n\n\nbase-commit: d476f8358be1536d4edd680c6024f784ff022f5d\n--\nRegards,\n\nLaurent Pinchart","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 6e039bf35fc1..bd3a8a6ec6b7 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -488,6 +488,13 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n \tif (!sensor_)\n \t\treturn;\n\n+\tconst CameraSensorProperties::SensorDelays &delays = sensor_->sensorDelays();\n+\tstd::unordered_map params = {\n+\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n+\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n+\t};\n+\tdelayedCtrls_ = std::make_unique(sensor_->device(), params);\n+\n \tLOG(SimplePipeline, Debug)\n \t\t<< \"Found pipeline: \"\n \t\t<< utils::join(entities_, \" -> \",\n@@ -1277,14 +1284,6 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tif (outputCfgs.empty())\n \t\treturn 0;\n\n-\tconst CameraSensorProperties::SensorDelays &delays = data->sensor_->sensorDelays();\n-\tstd::unordered_map params = {\n-\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n-\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n-\t};\n-\tdata->delayedCtrls_ =\n-\t\tstd::make_unique(data->sensor_->device(),\n-\t\t\t\t\t\t params);\n \tdata->video_->frameStart.connect(data->delayedCtrls_.get(),\n \t\t\t\t\t &DelayedControls::applyControls);\n\n","prefixes":[]}