{"id":22806,"url":"https://patchwork.libcamera.org/api/1.1/patches/22806/?format=json","web_url":"https://patchwork.libcamera.org/patch/22806/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250217185433.306833-7-pobrn@protonmail.com>","date":"2025-02-17T18:55:02","name":"[v3,6/8] libcamera: base: log: Pass dynamic prefix through","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"48dd48a742c39ffae6ce4321b9f682d6b242e567","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/1.1/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22806/mbox/","series":[{"id":5007,"url":"https://patchwork.libcamera.org/api/1.1/series/5007/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5007","date":"2025-02-17T18:54:35","name":"libcamera: base: log: Misc. changes","version":3,"mbox":"https://patchwork.libcamera.org/series/5007/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22806/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22806/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70BA6C3200\n\tfor ;\n\tMon, 17 Feb 2025 18:55:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2129C68696;\n\tMon, 17 Feb 2025 19:55:10 +0100 (CET)","from mail-40134.protonmail.ch (mail-40134.protonmail.ch\n\t[185.70.40.134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B7276868D\n\tfor ;\n\tMon, 17 Feb 2025 19:55:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"Y7pOS9Hq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1739818507; x=1740077707;\n\tbh=FV4vPqZlU6kReFob6wa3fv269jNCccPDdKLA4RCB100=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=Y7pOS9HqTiFEuBl2IjRIlb0GT/rj4RkqMGzELVpAHYSM1Mr8pAE8+SqsfkLl+e+ZV\n\t7udH0CXMf19ozD6CXpWKsNcjO/z0kd+jf4K1r8S83InVrKzUvLuVy+8z9KZ9LsNMAr\n\tEMWUqAlsW3t47A0BKk9uCrQB8O8bQacxILdOAANOvG9yd2qasxoFm34OP41zqc6EBv\n\t0dGU3/xCKZ5lv3/5dYKxWmPEke7vxX6ckVHMMKoi9frfUTa74+EX8TWWaMhGrV009r\n\tJpqzxkIqLo90Y64ybhr3W+9VRpkxoAmzkIi55KdNzCpNRTG2PaqT2CyGoRdQoijCIh\n\tc3cymiP/MdVuQ==","Date":"Mon, 17 Feb 2025 18:55:02 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Laurent Pinchart ","Subject":"[PATCH v3 6/8] libcamera: base: log: Pass dynamic prefix through","Message-ID":"<20250217185433.306833-7-pobrn@protonmail.com>","In-Reply-To":"<20250217185433.306833-1-pobrn@protonmail.com>","References":"<20250217185433.306833-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"86fd220242882396c841d43bb447aa34fa478d82","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use move construction to essentially pass through the string\nreturned by `Loggable::logPrefix()` to avoid an unnecessary copy.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Laurent Pinchart \n---\n include/libcamera/base/log.h | 2 +-\n src/libcamera/base/log.cpp | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\nindex 353520e10..195426c41 100644\n--- a/include/libcamera/base/log.h\n+++ b/include/libcamera/base/log.h\n@@ -64,7 +64,7 @@ class LogMessage\n public:\n \tLogMessage(const char *fileName, unsigned int line,\n \t\t const LogCategory &category, LogSeverity severity,\n-\t\t const std::string &prefix = std::string());\n+\t\t std::string prefix = {});\n \t~LogMessage();\n \n \t[[nodiscard]] std::ostream &stream() { return msgStream_; }\ndiff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 55019def8..2c233be36 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -858,11 +858,11 @@ const LogCategory &LogCategory::defaultCategory()\n */\n LogMessage::LogMessage(const char *fileName, unsigned int line,\n \t\t const LogCategory &category, LogSeverity severity,\n-\t\t const std::string &prefix)\n+\t\t std::string prefix)\n \t: category_(category), severity_(severity),\n \t timestamp_(utils::clock::now()),\n \t fileInfo_((std::ostringstream() << utils::basename(fileName) << \":\" << line).str()),\n-\t prefix_(prefix)\n+\t prefix_(std::move(prefix))\n {\n }\n \n","prefixes":["v3","6/8"]}