{"id":22783,"url":"https://patchwork.libcamera.org/api/1.1/patches/22783/?format=json","web_url":"https://patchwork.libcamera.org/patch/22783/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250214161031.240481-3-stefan.klug@ideasonboard.com>","date":"2025-02-14T16:09:48","name":"[v2,2/2] libcamera: formats: Deduplicate PixelFormatInfo::info() code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3666fe917a205f75dc6c44732c4f446ba70eac35","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22783/mbox/","series":[{"id":5003,"url":"https://patchwork.libcamera.org/api/1.1/series/5003/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5003","date":"2025-02-14T16:09:46","name":"Silence warning when creating a PixelFormatInfo from a null format","version":2,"mbox":"https://patchwork.libcamera.org/series/5003/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22783/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22783/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F875C3272\n\tfor ;\n\tFri, 14 Feb 2025 16:10:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BCE368653;\n\tFri, 14 Feb 2025 17:10:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2AB968648\n\tfor ;\n\tFri, 14 Feb 2025 17:10:40 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:2ff9:b837:9e53:886e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 994A010C7;\n\tFri, 14 Feb 2025 17:09:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QUQCw4rn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739549361;\n\tbh=7Ok4/3Ga4nvZ8nOUJ6xGdViQjK7GhgFDLhXvG5IQoqo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QUQCw4rnw26nK3pIGWPpIbMWa9kwbca9nlaRjvDuYnxhTET4pEN3M6S8CeRWpcAkY\n\tyVqx88gAXNVIbITMbzH9ETa7FToyAAHBxkPVWLiIjGPjl0y/bWLX7A+xnEDlCpT5qs\n\tWM27QOOktCo934m0QK5sHEoOiCxzv6lBY+EvleXI=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tLaurent Pinchart ","Subject":"[PATCH v2 2/2] libcamera: formats: Deduplicate\n\tPixelFormatInfo::info() code","Date":"Fri, 14 Feb 2025 17:09:48 +0100","Message-ID":"<20250214161031.240481-3-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250214161031.240481-1-stefan.klug@ideasonboard.com>","References":"<20250214161031.240481-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use PixelFormatInfo::info(const PixelFormat &format) to implement\nPixelFormatInfo::info(const V4L2PixelFormat &format).\n\nThis has one noteworthy side effect: If info(V4L2PixelFormat &format) is\ncalled with a valid but unsupported (by libcamera) format, we now get\nthe same warning as in the info(PixelFormat &format) case.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/formats.cpp | 9 +--------\n 1 file changed, 1 insertion(+), 8 deletions(-)","diff":"diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex b4518e61d04a..df7413f58ba8 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -1024,14 +1024,7 @@ const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n const PixelFormatInfo &PixelFormatInfo::info(const V4L2PixelFormat &format)\n {\n \tPixelFormat pixelFormat = format.toPixelFormat(false);\n-\tif (!pixelFormat.isValid())\n-\t\treturn pixelFormatInfoInvalid;\n-\n-\tconst auto iter = pixelFormatInfo.find(pixelFormat);\n-\tif (iter == pixelFormatInfo.end())\n-\t\treturn pixelFormatInfoInvalid;\n-\n-\treturn iter->second;\n+\treturn info(pixelFormat);\n }\n \n /**\n","prefixes":["v2","2/2"]}