{"id":22776,"url":"https://patchwork.libcamera.org/api/1.1/patches/22776/?format=json","web_url":"https://patchwork.libcamera.org/patch/22776/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250211172115.210087-1-stefan.klug@ideasonboard.com>","date":"2025-02-11T17:20:56","name":"ipa: rkisp1: agc: Fix build on debian 11 (gcc-9)","commit_ref":"f63f4d71d4c917b62242cb9b7e06edae80d6c204","pull_url":null,"state":"accepted","archived":false,"hash":"570dab14e1bd9192e721a00750f05063b7d0c3f2","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22776/mbox/","series":[{"id":4998,"url":"https://patchwork.libcamera.org/api/1.1/series/4998/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4998","date":"2025-02-11T17:20:56","name":"ipa: rkisp1: agc: Fix build on debian 11 (gcc-9)","version":1,"mbox":"https://patchwork.libcamera.org/series/4998/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22776/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22776/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0181C32F5\n\tfor ;\n\tTue, 11 Feb 2025 17:21:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDEE568626;\n\tTue, 11 Feb 2025 18:21:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 842FA685BE\n\tfor ;\n\tTue, 11 Feb 2025 18:21:23 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:266b:fb7d:9d59:9e92])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B43073E;\n\tTue, 11 Feb 2025 18:20:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fNmuyBiU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739294406;\n\tbh=4/Ua7Z2hfOG+FLdW+SZ7WVVJEzUR/CtpdYosSFTqeFk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=fNmuyBiUZiOZHKDBRdsj9aFr+C36c/1teX3zVgwlZa0RrT4jYwAuzxYjA63b96R6D\n\tF91VzGd6LHlKbqLHSzRyNwpNapwvqoS/r38qUJlAnVzmDvSgE4Q/tjOQrM12ghMAkV\n\twpSLW5wEu2loQej832HH7xg0htNEcpqxsHBA3qKA=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH] ipa: rkisp1: agc: Fix build on debian 11 (gcc-9)","Date":"Tue, 11 Feb 2025 18:20:56 +0100","Message-ID":"<20250211172115.210087-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Apparently not every compiler is able to deduce types the same way. Fix\ncompile on gcc-9 by explicitly specifying the type.\n\nFixes: ee918b370a08 (\"ipa: rkisp1: agc: Initialize enum controls with a list of values\")\nSigned-off-by: Stefan Klug \n---\n\nHi all,\n\nUnfortunately I broke the CI build of mainline :-(. This patch fixes it.\nA corresponding CI run is here:\nhttps://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1362476\n\nBest regards,\nStefan\n\n src/ipa/rkisp1/algorithms/agc.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex e7c6de757593..45ec72188b3a 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -151,11 +151,11 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n \tcontext.ctrlMap[&controls::ExposureTimeMode] =\n \t\tControlInfo({ { ControlValue(controls::ExposureTimeModeAuto),\n \t\t\t\tControlValue(controls::ExposureTimeModeManual) } },\n-\t\t\t controls::ExposureTimeModeAuto);\n+\t\t\t ControlValue(controls::ExposureTimeModeAuto));\n \tcontext.ctrlMap[&controls::AnalogueGainMode] =\n \t\tControlInfo({ { ControlValue(controls::AnalogueGainModeAuto),\n \t\t\t\tControlValue(controls::AnalogueGainModeManual) } },\n-\t\t\t controls::AnalogueGainModeAuto);\n+\t\t\t ControlValue(controls::AnalogueGainModeAuto));\n \t/* \\todo Move this to the Camera class */\n \tcontext.ctrlMap[&controls::AeEnable] = ControlInfo(false, true, true);\n \tcontext.ctrlMap.merge(controls());\n","prefixes":[]}