{"id":22756,"url":"https://patchwork.libcamera.org/api/1.1/patches/22756/?format=json","web_url":"https://patchwork.libcamera.org/patch/22756/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250206161607.50738-11-mzamazal@redhat.com>","date":"2025-02-06T16:16:01","name":"[v7,10/15] config: Allow enabling software ISP in runtime","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7181b394ad2e32d4b5e4abb52594fab8e39fff40","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22756/mbox/","series":[{"id":4993,"url":"https://patchwork.libcamera.org/api/1.1/series/4993/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4993","date":"2025-02-06T16:15:51","name":"Add global configuration file","version":7,"mbox":"https://patchwork.libcamera.org/series/4993/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22756/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22756/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0033FC32EF\n\tfor ;\n\tThu, 6 Feb 2025 16:16:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A866068611;\n\tThu, 6 Feb 2025 17:16:48 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 26A8B685F9\n\tfor ;\n\tThu, 6 Feb 2025 17:16:45 +0100 (CET)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-678-F9pm1727PfCct1sOLz5Nnw-1;\n\tThu, 06 Feb 2025 11:16:40 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id BC9921801A20; Thu, 6 Feb 2025 16:16:39 +0000 (UTC)","from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.43.17.31])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id ECDD3180035E; Thu, 6 Feb 2025 16:16:37 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"BHV/6dvV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1738858604;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=/32w5+seVutp+t5Wwj7rwsOTCP42SEKJWURJDQsCnZw=;\n\tb=BHV/6dvVtWTfIGlhHtQnJ0x4JrByBSyWAn790bOf7HpHngrbPOBXuxX0WgT/vcTjbKT7Ra\n\teCvHb9hivaQpNfcRodHRmoC0TfN+cGxdQHY8ui9a6+Nc578HlvFJorkFBuqg92tVpr4nBV\n\tfjmSDyxfnD+vUFwfleFacD5DVM5ip74=","X-MC-Unique":"F9pm1727PfCct1sOLz5Nnw-1","X-Mimecast-MFC-AGG-ID":"F9pm1727PfCct1sOLz5Nnw","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, Naushir Patuck\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Laurent Pinchart\n\t","Subject":"[PATCH v7 10/15] config: Allow enabling software ISP in runtime","Date":"Thu, 6 Feb 2025 17:16:01 +0100","Message-ID":"<20250206161607.50738-11-mzamazal@redhat.com>","In-Reply-To":"<20250206161607.50738-1-mzamazal@redhat.com>","References":"<20250206161607.50738-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"t_568bDqjH1nj_Dzo2reeFmk7kLtp54lwDJ3tPM66ws_1738858599","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch allows enabling or disabling software ISP in runtime in\naddition to compile time. This can be useful for software ISP testing\non various platforms as well as for overriding the defaults in case the\ndefaults don't work well (e.g. hardware ISP may or may not work on\ni.MX8MP depending on the kernel and libcamera patches present in the\ngiven system).\n\nThe configuration is specified as follows:\n\n configuration:\n pipelines:\n simple:\n supported_devices:\n - driver: DRIVER-NAME\n software_isp: BOOLEAN\n - ...\n\nFor example:\n\n configuration:\n pipelines:\n simple:\n supported_devices:\n - driver: mxc-isi\n software_isp: true\n\nThe overall configuration of enabling or disabling software ISP may get\ndropped in future but this patch is still useful in the meantime.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 6e039bf3..b32ce752 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -35,6 +35,7 @@\n #include \"libcamera/internal/converter.h\"\n #include \"libcamera/internal/delayed_controls.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/software_isp/software_isp.h\"\n@@ -1560,6 +1561,17 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n \t}\n \n \tswIspEnabled_ = info->swIspEnabled;\n+\tfor (GlobalConfiguration::Configuration entry :\n+\t GlobalConfiguration::configuration()\n+\t\t [\"pipelines\"][\"simple\"][\"supported_devices\"]\n+\t\t\t .asList()) {\n+\t\tauto name = entry[\"driver\"].get();\n+\t\tif (name == info->driver) {\n+\t\t\tswIspEnabled_ = entry[\"software_isp\"].get().value_or(swIspEnabled_);\n+\t\t\tLOG(SimplePipeline, Debug) << \"Overriding software ISP to \" << swIspEnabled_;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n \n \t/* Locate the sensors. */\n \tstd::vector sensors = locateSensors(media);\n","prefixes":["v7","10/15"]}