{"id":22725,"url":"https://patchwork.libcamera.org/api/1.1/patches/22725/?format=json","web_url":"https://patchwork.libcamera.org/patch/22725/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250203104318.135628-4-pobrn@protonmail.com>","date":"2025-02-03T10:43:34","name":"[v1,3/3] libcamera: pipeline: virtual: Set `FrameError` on error","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4cf7ea091fbcc3b1f92548c318ff03f5b39792f3","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/1.1/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22725/mbox/","series":[{"id":4987,"url":"https://patchwork.libcamera.org/api/1.1/series/4987/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4987","date":"2025-02-03T10:43:20","name":"libcamera: pipeline: virtual: Fill buffer's metadata","version":1,"mbox":"https://patchwork.libcamera.org/series/4987/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22725/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22725/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56BDEC3260\n\tfor ;\n\tMon, 3 Feb 2025 10:43:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B5326858E;\n\tMon, 3 Feb 2025 11:43:40 +0100 (CET)","from mail-40133.protonmail.ch (mail-40133.protonmail.ch\n\t[185.70.40.133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE75768585\n\tfor ;\n\tMon, 3 Feb 2025 11:43:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"Xj7Duvp8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738579417; x=1738838617;\n\tbh=5ejtu9YPowddirCWzAzbUxwojEFr/JrgsPcW4/tgres=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=Xj7Duvp8POA21R/RtI2AdCF7CzgnthfF/Y9ZY9uSgJzthcd7tezNH0pNrnyySaY5u\n\tbOp5F2HYYPGU5ET0NlN17jV7RbLAHL7f6y5oCQ3rsOvUuicVMdXnvYPQSdJO/thOVE\n\tWOvr0JSyB4PF/Yuy64EfVPUnjlWkERszqmDiVEWnF21rJ9kBewjUJnFp+LGTUYoWNS\n\t4WE34Q2v8Hx7GgDPLQg1KXqsvYNiQ7ltorlKTU0/j9fFDRBzJTrz3sWlvqxmTS9Dg7\n\tk7BRh3uQ5PA8raJLR6c0Qn3iS6ZFgTAbDA/bl7CCxulV26NqV8ZsdrU6PsVyGwDIkL\n\tMKO5EkR6wq3PA==","Date":"Mon, 03 Feb 2025 10:43:34 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH v1 3/3] libcamera: pipeline: virtual: Set `FrameError` on\n\terror","Message-ID":"<20250203104318.135628-4-pobrn@protonmail.com>","In-Reply-To":"<20250203104318.135628-1-pobrn@protonmail.com>","References":"<20250203104318.135628-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"85e122d89b17603ddd8333d6914737fffd49adb4","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Do not cancel, simply set the buffer's status to `FrameError`\nto notify the user about the error condition.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/pipeline/virtual/virtual.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\nindex 1a75f35aa..cbba08c82 100644\n--- a/src/libcamera/pipeline/virtual/virtual.cpp\n+++ b/src/libcamera/pipeline/virtual/virtual.cpp\n@@ -322,7 +322,7 @@ int PipelineHandlerVirtual::queueRequestDevice([[maybe_unused]] Camera *camera,\n \n \t\t\t\tif (streamConfig.frameGenerator->generateFrame(\n \t\t\t\t\t stream->configuration().size, buffer))\n-\t\t\t\t\tbuffer->_d()->cancel();\n+\t\t\t\t\tfmd.status = FrameMetadata::Status::FrameError;\n \n \t\t\t\tcompleteBuffer(request, buffer);\n \t\t\t\tbreak;\n","prefixes":["v1","3/3"]}