{"id":22711,"url":"https://patchwork.libcamera.org/api/1.1/patches/22711/?format=json","web_url":"https://patchwork.libcamera.org/patch/22711/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250130195811.1230581-3-pobrn@protonmail.com>","date":"2025-01-30T19:58:25","name":"[RFC,v2,2/9] libcamera: base: log: Use `std::from_chars()`","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8b8f918ef3d1d6bcba515f95f9d12ff6a96f1fbe","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/1.1/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22711/mbox/","series":[{"id":4982,"url":"https://patchwork.libcamera.org/api/1.1/series/4982/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4982","date":"2025-01-30T19:58:14","name":"libcamera: base: log: Misc. changes","version":2,"mbox":"https://patchwork.libcamera.org/series/4982/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22711/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22711/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CBCFBD808\n\tfor ;\n\tThu, 30 Jan 2025 19:58:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AEE468559;\n\tThu, 30 Jan 2025 20:58:31 +0100 (CET)","from mail-40131.protonmail.ch (mail-40131.protonmail.ch\n\t[185.70.40.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A3D56851B\n\tfor ;\n\tThu, 30 Jan 2025 20:58:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"isG4+t0C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738267108; x=1738526308;\n\tbh=Yvna53yt/HQw1uHbYeWGvCuXgx4bhd5mjGikNp4XWSo=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=isG4+t0CAWWtokWTrGVuor1s74eNU3lkVtXWm5AGA3G+0f3Av1NvZ+9xCLA6zgW7Y\n\thecIuEBo5eEtnVGZhesValIBH6lpLBAJRCvXAOqVyrLpMRWLbH47FwM5Eh2a/r4+PF\n\twlg4OP3Gww557dm0W+tUraIbBtCN+/VElNBpmHTv2pLZ/K+dHEN1bAefDKKzb0fj0e\n\tvX55OVLoeTZ7NTihEbD8HdfXiXivrBA+xKntIxGDUrRor975K77wLRGwB6sHr0m1lm\n\tsfhxikhYji91W/7H3d02aBHn9H6QWVfmLYuRE6KlgPil+6hR0w+yJ3GZJa1gWvCXdD\n\tzQYjjU57XMLug==","Date":"Thu, 30 Jan 2025 19:58:25 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Laurent Pinchart ","Subject":"[RFC PATCH v2 2/9] libcamera: base: log: Use `std::from_chars()`","Message-ID":"<20250130195811.1230581-3-pobrn@protonmail.com>","In-Reply-To":"<20250130195811.1230581-1-pobrn@protonmail.com>","References":"<20250130195811.1230581-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"c221c145c7abd54da2e19574ba62b6cc8b2780d4","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the `std::from_chars()` function from `` to\nparse the integral log level instead of `strtoul` as it\nprovides an easier to use interface and better type safety.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/base/log.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 1917c3254..31053aee1 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -8,6 +8,7 @@\n #include \n \n #include \n+#include \n #include \n #include \n #include \n@@ -685,12 +686,11 @@ LogSeverity Logger::parseLogLevel(const std::string &level)\n \t\t\"FATAL\",\n \t};\n \n-\tint severity;\n+\tunsigned int severity;\n \n \tif (std::isdigit(level[0])) {\n-\t\tchar *endptr;\n-\t\tseverity = strtoul(level.c_str(), &endptr, 10);\n-\t\tif (*endptr != '\\0' || severity > LogFatal)\n+\t\tauto [end, ec] = std::from_chars(level.data(), level.data() + level.size(), severity);\n+\t\tif (ec != std::errc() || *end != '\\0' || severity > LogFatal)\n \t\t\tseverity = LogInvalid;\n \t} else {\n \t\tseverity = LogInvalid;\n","prefixes":["RFC","v2","2/9"]}