{"id":22671,"url":"https://patchwork.libcamera.org/api/1.1/patches/22671/?format=json","web_url":"https://patchwork.libcamera.org/patch/22671/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250130115001.1129305-15-pobrn@protonmail.com>","date":"2025-01-30T11:51:11","name":"[RFC,v3,14/21] apps: lc-compliance: Use array instead of `std::vector`","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"42d0e5d3fdbd6e4aef4f298cbd8158c000989e68","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/1.1/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22671/mbox/","series":[{"id":4978,"url":"https://patchwork.libcamera.org/api/1.1/series/4978/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4978","date":"2025-01-30T11:50:08","name":"apps: lc-compliance: Multi-stream tests","version":3,"mbox":"https://patchwork.libcamera.org/series/4978/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22671/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22671/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B978ABDB1C\n\tfor ;\n\tThu, 30 Jan 2025 11:51:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71ADF6856B;\n\tThu, 30 Jan 2025 12:51:19 +0100 (CET)","from mail-10631.protonmail.ch (mail-10631.protonmail.ch\n\t[79.135.106.31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF61C68564\n\tfor ;\n\tThu, 30 Jan 2025 12:51:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"QKKFiseY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738237877; x=1738497077;\n\tbh=Ks/jrvruHnGDH5S7fiRidPqZKOiy3H1qrm/Mj2zPtpo=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=QKKFiseYqdB0zI93HYmfkhLKp2OI7TMq11STQKNrxLt+bN4yknzDT7TKf2E+zwMNn\n\tVrYQzcGFAUwONNPAlOzq6hokC7cfLKzjHEkPRXz3KGNoBRM+s40aPt6fWbDfyvxRfk\n\tBtsKMTJ31JfOp+aOhsYjCjuv15N/eK4YiY0KU4+RIdjccANdE7MNnDKeONWELCYMZM\n\t/vJDhXlBli7NQTqupp+mMbSDWo8DYQSBY0OQ9eI+/5dtqn3vV2v6xuTx0YQ/lRVClX\n\twqrlzmrykLfWv+6UBJ5OkDzrCae7fupO+yhN6cAxRgKcTZoY5iZGOKDdApHux2FQjV\n\tsgQ0RN+aByOaw==","Date":"Thu, 30 Jan 2025 11:51:11 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Jacopo Mondi ,\n\tPaul Elder ","Subject":"[RFC PATCH v3 14/21] apps: lc-compliance: Use array instead of\n\t`std::vector`","Message-ID":"<20250130115001.1129305-15-pobrn@protonmail.com>","In-Reply-To":"<20250130115001.1129305-1-pobrn@protonmail.com>","References":"<20250130115001.1129305-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"98f34ba44523224312d70e8e7867d9a04654486c","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no reason to use `std::vector` for this static data,\na simple array will do fine.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \nReviewed-by: Paul Elder \n---\n src/apps/lc-compliance/tests/capture_test.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp\nindex db196a949..97465a612 100644\n--- a/src/apps/lc-compliance/tests/capture_test.cpp\n+++ b/src/apps/lc-compliance/tests/capture_test.cpp\n@@ -18,8 +18,9 @@ namespace {\n \n using namespace libcamera;\n \n-const std::vector NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n-const std::vector ROLES = {\n+const int NUMREQUESTS[] = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n+\n+const StreamRole ROLES[] = {\n \tStreamRole::Raw,\n \tStreamRole::StillCapture,\n \tStreamRole::VideoRecording,\n","prefixes":["RFC","v3","14/21"]}