{"id":22652,"url":"https://patchwork.libcamera.org/api/1.1/patches/22652/?format=json","web_url":"https://patchwork.libcamera.org/patch/22652/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250124215806.158024-14-mzamazal@redhat.com>","date":"2025-01-24T21:58:04","name":"[RFC,v2,13/13] apps: cam: Write raw file if PPM cannot be written","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c2ab522b8f5729500c9b6f56c3804fbdfb226691","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22652/mbox/","series":[{"id":4970,"url":"https://patchwork.libcamera.org/api/1.1/series/4970/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4970","date":"2025-01-24T21:57:51","name":"Enable raw streams with software ISP","version":2,"mbox":"https://patchwork.libcamera.org/series/4970/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22652/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22652/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C641C322E\n\tfor ;\n\tFri, 24 Jan 2025 21:59:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A8056856F;\n\tFri, 24 Jan 2025 22:59:02 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A50E6857A\n\tfor ;\n\tFri, 24 Jan 2025 22:58:55 +0100 (CET)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-359-bdL8TsYyMpGnKEch5v0Nzg-1;\n\tFri, 24 Jan 2025 16:58:50 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 7EF6F1801F11 for ;\n\tFri, 24 Jan 2025 21:58:49 +0000 (UTC)","from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.39.192.49])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 2ADCF1800358; Fri, 24 Jan 2025 21:58:47 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"JG376bKE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1737755933;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=lwce1DZOVj1hcy0X3NaOakK2sv5Id5eOhgvaBoGXNb0=;\n\tb=JG376bKEIO8hl+cFZJbq6iD5U+O+YMv4ZNmFbxqzlwmQd/tcR1V03M2QN9lw2bZleki5/6\n\t/BYF9aDXzwEPkrHANLC5K2C7pHwTjXUfJcZ35mpJtvdWF2wG222pPRxCVspSpr+2+BhZ0Z\n\tCKEYJbK5WZH3NBpoJPwoEADjbFtaa2E=","X-MC-Unique":"bdL8TsYyMpGnKEch5v0Nzg-1","X-Mimecast-MFC-AGG-ID":"bdL8TsYyMpGnKEch5v0Nzg","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","Subject":"[RFC PATCH v2 13/13] apps: cam: Write raw file if PPM cannot be\n\twritten","Date":"Fri, 24 Jan 2025 22:58:04 +0100","Message-ID":"<20250124215806.158024-14-mzamazal@redhat.com>","In-Reply-To":"<20250124215806.158024-1-mzamazal@redhat.com>","References":"<20250124215806.158024-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"ZDXTlqgnUaUC4iUHfmq8WDcEiU3tmTouZPkjzIrtl7o_1737755929","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`cam' application can be requested to write its output as a PPM file.\nHowever, this is supported only for certain formats (only BGR888\ncurrently). If the output format cannot be written, `cam' reports an\nerror and doesn't write anything.\n\nThis is all right with a single stream input but impractical with\nmultiple streams of different output formats (e.g. a processed stream +\na raw stream) where some of them can be written in the supported format\nwhile the other not. In such a case, it's better to write the supported\nformats as PPM files and the unsupported formats as raw files, with the\ncorresponding warning on stderr. `.raw' extension is added to the file\nname in such a case to make clear it's not a PPM file.\n\nThis is a sort of hack but serves the purpose for the moment.\n\nSigned-off-by: Milan Zamazal \n---\n src/apps/cam/file_sink.cpp | 16 +++++++++++-----\n 1 file changed, 11 insertions(+), 5 deletions(-)","diff":"diff --git a/src/apps/cam/file_sink.cpp b/src/apps/cam/file_sink.cpp\nindex 76e21db9..1a866137 100644\n--- a/src/apps/cam/file_sink.cpp\n+++ b/src/apps/cam/file_sink.cpp\n@@ -7,6 +7,7 @@\n \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -133,11 +134,16 @@ void FileSink::writeBuffer(const Stream *stream, FrameBuffer *buffer,\n \tif (fileType_ == FileType::Ppm) {\n \t\tret = PPMWriter::write(filename.c_str(), stream->configuration(),\n \t\t\t\t image->data(0));\n-\t\tif (ret < 0)\n-\t\t\tstd::cerr << \"failed to write PPM file `\" << filename\n-\t\t\t\t << \"'\" << std::endl;\n-\n-\t\treturn;\n+\t\tif (ret == -EINVAL) {\n+\t\t\tfilename += \".raw\";\n+\t\t\tstd::cerr << \"cannot write file in PPM format, writing `\"\n+\t\t\t\t << filename << \"' instead\" << std::endl;\n+\t\t} else {\n+\t\t\tif (ret < 0)\n+\t\t\t\tstd::cerr << \"failed to write PPM file `\" << filename\n+\t\t\t\t\t << \"'\" << std::endl;\n+\t\t\treturn;\n+\t\t}\n \t}\n \n \tfd = open(filename.c_str(), O_CREAT | O_WRONLY |\n","prefixes":["RFC","v2","13/13"]}