{"id":22642,"url":"https://patchwork.libcamera.org/api/1.1/patches/22642/?format=json","web_url":"https://patchwork.libcamera.org/patch/22642/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250124215806.158024-4-mzamazal@redhat.com>","date":"2025-01-24T21:57:54","name":"[RFC,v2,03/13] libcamera: simple: Don't use raw output formats with conversions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"cc918bb82203b87316e20e9916c79d177626df87","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22642/mbox/","series":[{"id":4970,"url":"https://patchwork.libcamera.org/api/1.1/series/4970/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4970","date":"2025-01-24T21:57:51","name":"Enable raw streams with software ISP","version":2,"mbox":"https://patchwork.libcamera.org/series/4970/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22642/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22642/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 406D5BD78E\n\tfor ;\n\tFri, 24 Jan 2025 21:58:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CDAA86855F;\n\tFri, 24 Jan 2025 22:58:39 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3ABFB6855F\n\tfor ;\n\tFri, 24 Jan 2025 22:58:35 +0100 (CET)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-614-2x2o4rxyMHWCcmigIOrZ6w-1;\n\tFri, 24 Jan 2025 16:58:32 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 92828180034F for ;\n\tFri, 24 Jan 2025 21:58:31 +0000 (UTC)","from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.39.192.49])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 77C91180035D; Fri, 24 Jan 2025 21:58:30 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"IK0SiQGm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1737755913;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=mUcRycCaCnNZu76AweWdRzH2/YrkoDlX5MLDSt6j0Hs=;\n\tb=IK0SiQGmOqbReWc+ko+f94+OLgUCu0m8O4udoSy0IidN3uyX4VrqPx1m2/nbJO61+hHuoD\n\th7Bn3Goq3l9TZkPIevlKbJYay/WCVX6PxTbrFyFkG4DCgv7gLXGvV+uQPntjdPQMvyRlGt\n\tMUt06OhuyOmU+t7kAbc5z8gtnA4mMHY=","X-MC-Unique":"2x2o4rxyMHWCcmigIOrZ6w-1","X-Mimecast-MFC-AGG-ID":"2x2o4rxyMHWCcmigIOrZ6w","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","Subject":"[RFC PATCH v2 03/13] libcamera: simple: Don't use raw output formats\n\twith conversions","Date":"Fri, 24 Jan 2025 22:57:54 +0100","Message-ID":"<20250124215806.158024-4-mzamazal@redhat.com>","In-Reply-To":"<20250124215806.158024-1-mzamazal@redhat.com>","References":"<20250124215806.158024-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"qqalu-1o6ZRECYyG-8-pVXh89uaireqghIvxd6S0HMM_1737755911","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In order to support raw streams, we need to add raw formats to software\nISP configurations. In this preparatory patch, the raw formats are\nexcluded from software ISP output configurations.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 6e9bc630..06df909b 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -26,6 +26,7 @@\n \n #include \n #include \n+#include \n #include \n #include \n \n@@ -209,6 +210,12 @@ static const SimplePipelineInfo supportedDevices[] = {\n \t{ \"sun6i-csi\", {}, false },\n };\n \n+bool isRawFormat(const PixelFormat &format)\n+{\n+\treturn libcamera::PixelFormatInfo::info(format).colourEncoding ==\n+\t libcamera::PixelFormatInfo::ColourEncodingRAW;\n+}\n+\n } /* namespace */\n \n class SimpleCameraData : public Camera::Private\n@@ -1284,7 +1291,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \n \t\tcfg.setStream(&data->streams_[i]);\n \n-\t\tif (data->useConversion_)\n+\t\tif (data->useConversion_ &&\n+\t\t (!data->swIsp_ || !isRawFormat(cfg.pixelFormat)))\n \t\t\toutputCfgs.push_back(cfg);\n \t}\n \n","prefixes":["RFC","v2","03/13"]}