{"id":2264,"url":"https://patchwork.libcamera.org/api/1.1/patches/2264/?format=json","web_url":"https://patchwork.libcamera.org/patch/2264/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191028022525.796995-5-niklas.soderlund@ragnatech.se>","date":"2019-10-28T02:25:17","name":"[libcamera-devel,RFC,04/12] libcamera: pipelines: Switch to helper to resolve request from buffer","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b9580340d98a5e2d3d368e8a388d39701c7caca9","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2264/mbox/","series":[{"id":561,"url":"https://patchwork.libcamera.org/api/1.1/series/561/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=561","date":"2019-10-28T02:25:13","name":"libcamera: Rework buffer API","version":1,"mbox":"https://patchwork.libcamera.org/series/561/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2264/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2264/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 894B661506\n\tfor ;\n\tMon, 28 Oct 2019 03:25:51 +0100 (CET)","from localhost.localdomain (unknown [93.2.121.143])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 408b182b-f92a-11e9-903a-005056917f90;\n\tMon, 28 Oct 2019 03:25:48 +0100 (CET)"],"X-Halon-ID":"408b182b-f92a-11e9-903a-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 28 Oct 2019 03:25:17 +0100","Message-Id":"<20191028022525.796995-5-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20191028022525.796995-1-niklas.soderlund@ragnatech.se>","References":"<20191028022525.796995-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC 04/12] libcamera: pipelines: Switch to\n\thelper to resolve request from buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 28 Oct 2019 02:25:51 -0000"},"content":"Use the pipeline helper instead of the soon to be removed request\nrecorded in the buffer.\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n src/libcamera/pipeline/uvcvideo.cpp | 2 +-\n src/libcamera/pipeline/vimc.cpp | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex ff90b729e558c3a3..8aa5f34febf16585 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -948,7 +948,7 @@ void IPU3CameraData::imguInputBufferReady(Buffer *buffer)\n */\n void IPU3CameraData::imguOutputBufferReady(Buffer *buffer)\n {\n-\tRequest *request = buffer->request();\n+\tRequest *request = requestFromBuffer(buffer);\n \n \tif (!pipe_->completeBuffer(camera_, request, buffer))\n \t\t/* Request not completed yet, return here. */\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex cefdb54a06d440fb..0803572754364beb 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -991,7 +991,7 @@ void PipelineHandlerRkISP1::bufferReady(Buffer *buffer)\n {\n \tASSERT(activeCamera_);\n \tRkISP1CameraData *data = cameraData(activeCamera_);\n-\tRequest *request = buffer->request();\n+\tRequest *request = data->requestFromBuffer(buffer);\n \n \tdata->timeline_.bufferReady(buffer);\n \ndiff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\nindex 5aa6a8f9e0b2b7a4..679d82d38227b991 100644\n--- a/src/libcamera/pipeline/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo.cpp\n@@ -375,7 +375,7 @@ int UVCCameraData::init(MediaEntity *entity)\n \n void UVCCameraData::bufferReady(Buffer *buffer)\n {\n-\tRequest *request = buffer->request();\n+\tRequest *request = requestFromBuffer(buffer);\n \n \tpipe_->completeBuffer(camera_, request, buffer);\n \tpipe_->completeRequest(camera_, request);\ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex 49b850cf0153020f..56898716a8cde074 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -460,7 +460,7 @@ int VimcCameraData::init(MediaDevice *media)\n \n void VimcCameraData::bufferReady(Buffer *buffer)\n {\n-\tRequest *request = buffer->request();\n+\tRequest *request = requestFromBuffer(buffer);\n \n \tpipe_->completeBuffer(camera_, request, buffer);\n \tpipe_->completeRequest(camera_, request);\n","prefixes":["libcamera-devel","RFC","04/12"]}