{"id":22628,"url":"https://patchwork.libcamera.org/api/1.1/patches/22628/?format=json","web_url":"https://patchwork.libcamera.org/patch/22628/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250123114204.79321-14-stefan.klug@ideasonboard.com>","date":"2025-01-23T11:41:03","name":"[v2,13/17] utils: tuning: rkisp1: Add lux module","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"754dd249066114249ab959cff4f289693da5d210","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22628/mbox/","series":[{"id":4966,"url":"https://patchwork.libcamera.org/api/1.1/series/4966/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4966","date":"2025-01-23T11:40:50","name":"Add Bayesian AWB algorithm to libipa and rkisp1","version":2,"mbox":"https://patchwork.libcamera.org/series/4966/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22628/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22628/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADA57C3317\n\tfor ;\n\tThu, 23 Jan 2025 11:42:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 68B3868576;\n\tThu, 23 Jan 2025 12:42:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86E4D6856F\n\tfor ;\n\tThu, 23 Jan 2025 12:42:49 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c0a:33cd:b453:5d3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17D53F91;\n\tThu, 23 Jan 2025 12:41:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oFnw9cOm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737632506;\n\tbh=WLlK/akDfgfPIhxQ93UTYBGHsk+MFtxGzlYat4o/WMc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=oFnw9cOmJR4s7iJ7F+N6UKS5mu6T6btC4GUOzbfpVierNPLz1AaOWpcbL6E9vvSFV\n\titPo/lEEDmnruJ2hhKjmn5E5Ma01ACRBreNTRhH4xfsaQUzX7+0yOsUi1AdHrUt9AE\n\t7Yg2GYF/d3tCFAwu2vqpRkJE/dIbEhSXrfTwMhNM=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 13/17] utils: tuning: rkisp1: Add lux module","Date":"Thu, 23 Jan 2025 12:41:03 +0100","Message-ID":"<20250123114204.79321-14-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250123114204.79321-1-stefan.klug@ideasonboard.com>","References":"<20250123114204.79321-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that the lux module is available, add it to the rkisp1 tuner.\n\nWhile at it, sort the imports correctly.\n\nSigned-off-by: Stefan Klug \n\n---\n\nChanges in v2:\n- Added this patch\n---\n utils/tuning/rkisp1.py | 14 +++++++++-----\n 1 file changed, 9 insertions(+), 5 deletions(-)","diff":"diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\nindex 9f40fd8bd63b..207b717a029c 100755\n--- a/utils/tuning/rkisp1.py\n+++ b/utils/tuning/rkisp1.py\n@@ -6,18 +6,19 @@\n #\n # Tuning script for rkisp1\n \n-import coloredlogs\n import logging\n import sys\n \n+import coloredlogs\n import libtuning as lt\n-from libtuning.parsers import YamlParser\n from libtuning.generators import YamlOutput\n-from libtuning.modules.lsc import LSCRkISP1\n from libtuning.modules.agc import AGCRkISP1\n from libtuning.modules.awb import AWBRkISP1\n from libtuning.modules.ccm import CCMRkISP1\n+from libtuning.modules.lsc import LSCRkISP1\n+from libtuning.modules.lux import LuxRkISP1\n from libtuning.modules.static import StaticModule\n+from libtuning.parsers import YamlParser\n \n coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')\n \n@@ -45,12 +46,15 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n # This is the function that will be used to smooth the color ratio\n # values. This can also be a custom function.\n smoothing_function=lt.smoothing.MedianBlur(3),)\n+lux = LuxRkISP1(debug=[lt.Debug.Plot])\n \n tuner = lt.Tuner('RkISP1')\n-tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc])\n+tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])\n tuner.set_input_parser(YamlParser())\n tuner.set_output_formatter(YamlOutput())\n-tuner.set_output_order([agc, awb, blc, ccm, color_processing,\n+\n+# Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.\n+tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,\n filter, gamma_out, lsc])\n \n if __name__ == '__main__':\n","prefixes":["v2","13/17"]}