{"id":22603,"url":"https://patchwork.libcamera.org/api/1.1/patches/22603/?format=json","web_url":"https://patchwork.libcamera.org/patch/22603/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250121185044.300816-3-pobrn@protonmail.com>","date":"2025-01-21T18:50:58","name":"[RFC,v1,2/7] libcamera: base: log: Use `std::from_chars()`","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"424f94b8a95371abb3825f6274296381f3a11eae","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/1.1/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22603/mbox/","series":[{"id":4960,"url":"https://patchwork.libcamera.org/api/1.1/series/4960/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4960","date":"2025-01-21T18:50:47","name":"libcamera: base: log: Misc. changes","version":1,"mbox":"https://patchwork.libcamera.org/series/4960/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22603/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22603/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED7A4BD16B\n\tfor ;\n\tTue, 21 Jan 2025 18:51:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3F836855D;\n\tTue, 21 Jan 2025 19:51:03 +0100 (CET)","from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F9FD60380\n\tfor ;\n\tTue, 21 Jan 2025 19:51:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"DR5nmybS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1737485461; x=1737744661;\n\tbh=pzEZ4IbBHAq23BnuKGlTxXSMQlmVd18qIypC2hErXjI=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=DR5nmybSCJq70EKEuhtRksOvSB/U02N8s0x3Lo8bm/jrjsHdHRb5YrpOzeKdQ2Igm\n\tAw4JoNX/Akxj/AcFnfkyHE0G+bXcu8/L76DZQ+8Ezobob5i76HGCumZ5bFp/d/Ffep\n\tP0zoYAtl4cSHrwJChF8qmAeEY7t1kF2WEnknQSvba+1ZkfOVdUdFpBuqJ4KOLVAVCe\n\tPJgZdrOg2xwSaluOr217Cz45O5DXvPKFqlCBKnu6mYmG1x9fs1KcX7vtoaPNtuDZzW\n\tfYVpLBZ+3XdVPBheBoXjyLgmwPTTe0tMbZ+PDM0OjRytWLq3MRmvySXxviTqA1CmlN\n\tOCwFmEGbAzQbA==","Date":"Tue, 21 Jan 2025 18:50:58 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[RFC PATCH v1 2/7] libcamera: base: log: Use `std::from_chars()`","Message-ID":"<20250121185044.300816-3-pobrn@protonmail.com>","In-Reply-To":"<20250121185044.300816-1-pobrn@protonmail.com>","References":"<20250121185044.300816-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"6031d72237e92d7b78308b19f636b7f4ce7ea943","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the `std::from_chars()` function from `` to\nparse the integral log level instead of `strtoul` as it\nprovides an easier to use interface and better type safety.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/base/log.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 61a43d525..1024fed7f 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -8,6 +8,7 @@\n #include \n \n #include \n+#include \n #include \n #include \n #include \n@@ -686,12 +687,11 @@ LogSeverity Logger::parseLogLevel(const std::string &level)\n \t\t\"FATAL\",\n \t};\n \n-\tint severity;\n+\tunsigned int severity;\n \n \tif (std::isdigit(level[0])) {\n-\t\tchar *endptr;\n-\t\tseverity = strtoul(level.c_str(), &endptr, 10);\n-\t\tif (*endptr != '\\0' || severity > LogFatal)\n+\t\tauto [end, ec] = std::from_chars(level.data(), level.data() + level.size(), severity, 10);\n+\t\tif (ec != std::errc() || *end != '\\0' || severity > LogFatal)\n \t\t\tseverity = LogInvalid;\n \t} else {\n \t\tseverity = LogInvalid;\n","prefixes":["RFC","v1","2/7"]}