{"id":22573,"url":"https://patchwork.libcamera.org/api/1.1/patches/22573/?format=json","web_url":"https://patchwork.libcamera.org/patch/22573/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250114182143.1773762-13-pobrn@protonmail.com>","date":"2025-01-14T18:22:47","name":"[RFC,v2,12/16] apps: lc-compliance: Add message to `GTEST_SKIP()`","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5efb73bad5cf66522218ca8fd8648e8d27ea3887","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/1.1/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22573/mbox/","series":[{"id":4951,"url":"https://patchwork.libcamera.org/api/1.1/series/4951/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4951","date":"2025-01-14T18:21:46","name":"apps: lc-compliance: Multi-stream tests","version":2,"mbox":"https://patchwork.libcamera.org/series/4951/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22573/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22573/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4981DC3304\n\tfor ;\n\tTue, 14 Jan 2025 18:22:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 073F968545;\n\tTue, 14 Jan 2025 19:22:53 +0100 (CET)","from mail-10631.protonmail.ch (mail-10631.protonmail.ch\n\t[79.135.106.31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFD1E68521\n\tfor ;\n\tTue, 14 Jan 2025 19:22:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"whD6m168\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1736878970; x=1737138170;\n\tbh=tmCTVUWVvSTdiqZyWSIPZBhQc6EskgTjxCnrRw+re4Q=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=whD6m168pxvavQD0DFP6VqvjzkxPRcpxlwpzTRQFYLFq0JDPLcB/qS+WvkaB74oR1\n\tcF6c2K+jlr0QV+EBFXwO3u9oDHtu0m/UPz2fi4fJBjap/+/EER8DU5S0wXg06Qetp0\n\tr+7YOITDH+/CaSrqZzaNe//JCPVISxWVAwVEhteOk04qxpNPSFp13A9IId8GghWD5a\n\t74niS4iTWjVVS76oHZrfcmUMcgL2cxqQy8s8ZNXo2M95SBme4O7PKtAKBo1kF5TBI9\n\tp2zig8gvhBdlsQZg7mdet4+DdwXdWaUC+vuljva6xvy7Cq0nuVA7qn0o7bMv2Hq1C0\n\tnnGnA7BOKv7EA==","Date":"Tue, 14 Jan 2025 18:22:47 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[RFC PATCH v2 12/16] apps: lc-compliance: Add message to\n\t`GTEST_SKIP()`","Message-ID":"<20250114182143.1773762-13-pobrn@protonmail.com>","In-Reply-To":"<20250114182143.1773762-1-pobrn@protonmail.com>","References":"<20250114182143.1773762-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"8c5bb2fa7ee2c35ca8236f68d94a9139c71bdcf4","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Just like other gtest macros, `GTEST_SKIP()` returns an object\nto which a formatted message can be added using the usual `<<`\nstream operator. So use it instead of printing to `std::cout`.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/apps/lc-compliance/helpers/capture.cpp | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)","diff":"diff --git a/src/apps/lc-compliance/helpers/capture.cpp b/src/apps/lc-compliance/helpers/capture.cpp\nindex 91c4d4400..43db15d2d 100644\n--- a/src/apps/lc-compliance/helpers/capture.cpp\n+++ b/src/apps/lc-compliance/helpers/capture.cpp\n@@ -26,10 +26,8 @@ void Capture::configure(StreamRole role)\n {\n \tconfig_ = camera_->generateConfiguration({ role });\n \n-\tif (!config_) {\n-\t\tstd::cout << \"Role not supported by camera\" << std::endl;\n-\t\tGTEST_SKIP();\n-\t}\n+\tif (!config_)\n+\t\tGTEST_SKIP() << \"Role not supported by camera\";\n \n \tif (config_->validate() != CameraConfiguration::Valid) {\n \t\tconfig_.reset();\n@@ -85,10 +83,8 @@ void CaptureBalanced::capture(unsigned int numRequests)\n \n \t/* No point in testing less requests then the camera depth. */\n \tif (buffers.size() > numRequests) {\n-\t\tstd::cout << \"Camera needs \" + std::to_string(buffers.size())\n-\t\t\t+ \" requests, can't test only \"\n-\t\t\t+ std::to_string(numRequests) << std::endl;\n-\t\tGTEST_SKIP();\n+\t\tGTEST_SKIP() << \"Camera needs \" << buffers.size()\n+\t\t\t << \" requests, can't test only \" << numRequests;\n \t}\n \n \tqueueCount_ = 0;\n","prefixes":["RFC","v2","12/16"]}