{"id":22485,"url":"https://patchwork.libcamera.org/api/1.1/patches/22485/?format=json","web_url":"https://patchwork.libcamera.org/patch/22485/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250109000942.1616565-13-paul.elder@ideasonboard.com>","date":"2025-01-09T00:09:42","name":"[v6,12/12] ipa: raspberry: Report new AeEnable control as available","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"09118a173c476054362ce18995c15c53b8b5f2d3","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22485/mbox/","series":[{"id":4936,"url":"https://patchwork.libcamera.org/api/1.1/series/4936/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4936","date":"2025-01-09T00:09:30","name":"AEGC controls","version":6,"mbox":"https://patchwork.libcamera.org/series/4936/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22485/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22485/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30D43C3319\n\tfor ;\n\tThu, 9 Jan 2025 00:10:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 746706854F;\n\tThu, 9 Jan 2025 01:10:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B395C68500\n\tfor ;\n\tThu, 9 Jan 2025 01:10:12 +0100 (CET)","from pyrite.hamster-moth.ts.net (unknown\n\t[IPv6:2604:2d80:9e93:ad00:3d82:7e4f:ab9b:8a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A0AC11F1;\n\tThu, 9 Jan 2025 01:09:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ve12ljxS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736381359;\n\tbh=QfykDUOINS/cQGLJPiSZ7a9QcoQb3YgBabHxTfBk0xo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ve12ljxSUwGlk6kKCiSQTuLT8EgQVKGUcTuM9PGCtFhqGeL1qMaT0l57hwT4yS+wB\n\ti/zMjWDuQMJVJA54ockJb1q0bVoUGcljZEn7ouB39J8OOf+/UEeMaBtgFzi/+pLuDE\n\tAZVR9v7IPJcfsLiPGgc+5MOZDkLFNo62BXZqhozo=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ,\n\tlaurent.pinchart@ideasonboard.com, stefan.klug@ideasonboard.com","Subject":"[PATCH v6 12/12] ipa: raspberry: Report new AeEnable control as\n\tavailable","Date":"Wed, 8 Jan 2025 18:09:42 -0600","Message-Id":"<20250109000942.1616565-13-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20250109000942.1616565-1-paul.elder@ideasonboard.com>","References":"<20250109000942.1616565-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Even though the new AeEnable control internally switches on and off the\nsub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to\nbe declared as available. Report this control as available in the\nrpi IPA.\n\nSupport for the control does not need to be added as it is handled by\nthe Camera class. It does not need to be handled in metadata either as\nthe new version of AeEnable is not returned in metadata.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v6\n---\n src/ipa/rpi/common/ipa_base.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 4334d22e1..44ce38caa 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -55,6 +55,8 @@ constexpr Duration controllerMinFrameDuration = 1.0s / 30.0;\n \n /* List of controls handled by the Raspberry Pi IPA */\n const ControlInfoMap::Map ipaControls{\n+\t/* \\todo Move this to the Camera class */\n+\t{ &controls::AeEnable, ControlInfo(false, true) },\n \t{ &controls::ExposureTimeMode,\n \t ControlInfo(static_cast(controls::ExposureTimeModeAuto),\n \t\t static_cast(controls::ExposureTimeModeManual)) },\n","prefixes":["v6","12/12"]}