{"id":22468,"url":"https://patchwork.libcamera.org/api/1.1/patches/22468/?format=json","web_url":"https://patchwork.libcamera.org/patch/22468/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250108111030.3257931-2-naush@raspberrypi.com>","date":"2025-01-08T11:09:33","name":"[v3,1/4] ipa: rpi: Use r-value references in the set()/setLocked() functions","commit_ref":"031a57bcd2bb5b85b8085e25ac7d54cea17f5348","pull_url":null,"state":"accepted","archived":false,"hash":"d237d1f42ed2e212fdd602dc3a771d1545b22150","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22468/mbox/","series":[{"id":4934,"url":"https://patchwork.libcamera.org/api/1.1/series/4934/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4934","date":"2025-01-08T11:09:32","name":"Raspberry Pi: Various changes","version":3,"mbox":"https://patchwork.libcamera.org/series/4934/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22468/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22468/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C879BD80A\n\tfor ;\n\tWed, 8 Jan 2025 11:10:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C83FA68503;\n\tWed, 8 Jan 2025 12:10:39 +0100 (CET)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB5CB608AB\n\tfor ;\n\tWed, 8 Jan 2025 12:10:35 +0100 (CET)","by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-43616bf3358so25445795e9.3\n\tfor ;\n\tWed, 08 Jan 2025 03:10:35 -0800 (PST)","from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-436e2ddefcbsm17141325e9.22.2025.01.08.03.10.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 Jan 2025 03:10:34 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"b6no12eL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1736334635; x=1736939435;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=B7RQnbyjyrsg/0lgDdzviLQ9dDzroinzgu5Rz/x5ULU=;\n\tb=b6no12eLYuke4tNoQZrZ3KSfqIUJ466y/wBVUmolBH4CwLLM6Bj4/XHCXd1vAQbpf+\n\tj9wIR5OgN9q/4GMC5REB/Svlws+0H7LFqg1fIe/0nZ8Ph94g6zUXUHy9ykk9TiZl6wYI\n\tZwLGG49qaUCfwAZrvPzlcsCTfeX7gL4GyGegZgsqqR1t48sSO0JeJjzor6yowZft23SE\n\trTVZzJEjo5qg+h73lHaQOAxtMuZXEgqTYPGfqXBC2DvNMnVKeXChjnewM/9srPD8yJwp\n\t2fw0mOoW9c8vaBn0VhpcC5BT0b1Ahi6nON61MKyoWHH1Ev4UbnrFLJnwgyMzR8S2QDco\n\tpLlQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1736334635; x=1736939435;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=B7RQnbyjyrsg/0lgDdzviLQ9dDzroinzgu5Rz/x5ULU=;\n\tb=q7Jx/iTQC6zZOafyl8Wqtj5Xn7xIO9ybQ/eda/g3LfiKTeU2rf8k+c5D2JfPSl+gda\n\tmRt2ZkC1yrxRGqM7e2oDbt7uIwCyMN1bqf1odeiuJwP9IrnqzZT4lB+2aGMAt87ZePpe\n\tGoaCKquL4N5FN3ofRpD23nZDjQrrWLe2NiPxNNBeUJhaS2Wf7Ue6U7eN/CXOKBr/NUI7\n\tVqSBRB2S965cE5AWdq8exubH93xsRFBkQ9rpWhCSe40XkX9eAMRXKUatryHjUSXoF5jh\n\tSxg3stwNnnNZxuhBMk9XKQvonqf3UCxQf4MzjGoWtWeA524A9ozoexrGAvnYWgNjINjl\n\tbUfw==","X-Gm-Message-State":"AOJu0YxAFHgtEYdfFqVQsiYam5Y84NHEzlznzyfgYVacJjwOfrdXQO+s\n\tpEN2YTxW+iJYIxB1IdNeJIWlih1cOau+FAjD14OGnJ2RON5HpW0b0VCZy2Gj1saKmYrnPI7eKO5\n\tTuKk=","X-Gm-Gg":"ASbGnctECFCS0MTdIVQCoLZT5a9gfOlx2qz+lngrw1LajZyUPMr3aMut8UHyH2u4b5h\n\tO7XMO5r1IRnCfxcHJzB9R+ypjyiLqC1ccn1KlJLc9XuQiW1w1NHt0ILA8nArWunGjc2XQwHnlHj\n\tqt18+Vyl4iJBWVlCGqX5L9rQAO3c8Z6en5Iel4j9Zbu8KnkLGxIKHZ1WFXW+3+kbvSIlqmFGgIw\n\tDB/S/ygDkKZdpOeKH/pkNFEH+5snLuH2DcqH0DcFb0kpJIq+Ur/Bi3uSj84s87Qb/E3cP3asnsv","X-Google-Smtp-Source":"AGHT+IHUohmKQwxxP9Il3iBIfwzMhgcd/FnfmEq2eJG6P6bD1Y5Wl0B+EqUe2YwbcWaGIJrH7hrvKg==","X-Received":"by 2002:a05:600c:a09:b0:434:f1d5:144a with SMTP id\n\t5b1f17b1804b1-436e2557087mr7850405e9.0.1736334635039; \n\tWed, 08 Jan 2025 03:10:35 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ,\n\tDavid Plowman ,\n\tLaurent Pinchart ","Subject":"[PATCH v3 1/4] ipa: rpi: Use r-value references in the\n\tset()/setLocked() functions","Date":"Wed, 8 Jan 2025 11:09:33 +0000","Message-ID":"<20250108111030.3257931-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250108111030.3257931-1-naush@raspberrypi.com>","References":"<20250108111030.3257931-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use an r-value reference in set() and setLocked(), allowing more\nefficient metadata handling with std::forward and std::move if needed.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nReviewed-by: Laurent Pinchart \n---\n src/ipa/rpi/controller/metadata.h | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/rpi/controller/metadata.h b/src/ipa/rpi/controller/metadata.h\nindex b4650d25170f..b884490918c7 100644\n--- a/src/ipa/rpi/controller/metadata.h\n+++ b/src/ipa/rpi/controller/metadata.h\n@@ -12,6 +12,7 @@\n #include \n #include \n #include \n+#include \n \n #include \n \n@@ -36,10 +37,10 @@ public:\n \t}\n \n \ttemplate\n-\tvoid set(std::string const &tag, T const &value)\n+\tvoid set(std::string const &tag, T &&value)\n \t{\n \t\tstd::scoped_lock lock(mutex_);\n-\t\tdata_[tag] = value;\n+\t\tdata_[tag] = std::forward(value);\n \t}\n \n \ttemplate\n@@ -104,10 +105,10 @@ public:\n \t}\n \n \ttemplate\n-\tvoid setLocked(std::string const &tag, T const &value)\n+\tvoid setLocked(std::string const &tag, T &&value)\n \t{\n \t\t/* Use this only if you're holding the lock yourself. */\n-\t\tdata_[tag] = value;\n+\t\tdata_[tag] = std::forward(value);\n \t}\n \n \t/*\n","prefixes":["v3","1/4"]}